Fix to get google tasks to drag/drop. Also removed google tasks help screen, we're gonna make another one

astrid/plugin-src/com/todoroo/astrid/gtasks/GtasksListFragment.java

@@ -13,7 +13,6 @@ import com.todoroo.andlib.data.TodorooCursor;
 import com.todoroo.andlib.service.Autowired;
 import com.todoroo.andlib.utility.DateUtilities;
 import com.todoroo.andlib.utility.DialogUtilities;
-import com.todoroo.andlib.utility.Preferences;
 import com.todoroo.astrid.dao.StoreObjectDao;
 import com.todoroo.astrid.data.StoreObject;
 import com.todoroo.astrid.data.Task;
@@ -64,18 +63,15 @@ public class GtasksListFragment extends SubtasksListFragment {
         };
     }
 
+    @Override
+    protected boolean allowResorting() {
+        return false;
+    }
+
     @Override
     public void onActivityCreated(Bundle icicle) {
         super.onActivityCreated(icicle);
 
-        if(!Preferences.getBoolean(GtasksPreferenceService.PREF_SHOWN_LIST_HELP, false)) {
-            Preferences.setBoolean(GtasksPreferenceService.PREF_SHOWN_LIST_HELP, true);
-            DialogUtilities.okDialog(getActivity(),
-                    getString(R.string.gtasks_help_title),
-                    android.R.drawable.ic_dialog_info,
-                    getString(R.string.gtasks_help_body), null);
-        }
-
         long storeObjectId = getActivity().getIntent().getLongExtra(TOKEN_STORE_ID, 0);
         list = storeObjectDao.fetch(storeObjectId, LIST_PROPERTIES);
         ((OrderedListFragmentHelper<StoreObject>)helper).setList(list);

astrid/plugin-src/com/todoroo/astrid/subtasks/SubtasksListFragment.java

@@ -1,5 +1,6 @@
 package com.todoroo.astrid.subtasks;
 
+import android.os.Bundle;
 import android.view.View;
 import android.view.ViewGroup;
 
@@ -20,9 +21,10 @@ public class SubtasksListFragment extends TaskListFragment {
 
     protected OrderedListFragmentHelper<?> helper;
 
-    public SubtasksListFragment() {
-        super();
+    @Override
+    public void onActivityCreated(Bundle savedInstanceState) {
         helper = createFragmentHelper();
+        super.onActivityCreated(savedInstanceState);
     }
 
     protected OrderedListFragmentHelper<?> createFragmentHelper() {

astrid/res/values/strings-gtasks.xml

@@ -25,10 +25,6 @@
     <!-- short help title for Gtasks -->
     <string name="gtasks_help_title">Welcome to Google Tasks!</string>
     
-    <!-- short help for GTasks list activity -->
-    <string name="gtasks_help_body">Drag the grabber on the left side of a task 
-    to rearrange it. Swipe the grabber left or right to change indentation.</string>
-
     <string name="CFC_gtasks_list_text">In List: ?</string>
 
     <string name="CFC_gtasks_list_name">In GTasks List...</string>

astrid/src/com/todoroo/astrid/activity/TaskListFragment.java

@@ -437,7 +437,7 @@ public class TaskListFragment extends ListFragment implements OnScrollListener,
         }
     }
 
-    private boolean allowResorting() {
+    protected boolean allowResorting() {
         return true;
     }