From d96aefe4fee802d524f71d5042d626acb69d5b2f Mon Sep 17 00:00:00 2001 From: Alex Baker Date: Wed, 25 Sep 2013 23:31:36 -0500 Subject: [PATCH] Remove astrid lite, set configuration preference --- .../astrid/activity/EditPreferences.java | 50 ++----- .../astrid/service/StatisticsConstants.java | 2 - .../astrid/service/UpgradeService.java | 3 - .../utility/AstridLitePreferenceSpec.java | 122 ------------------ .../astrid/utility/AstridPreferences.java | 15 +-- .../com/todoroo/astrid/utility/Constants.java | 5 - astrid/src/main/res/values-de/strings.xml | 4 - astrid/src/main/res/values-es/strings.xml | 4 - astrid/src/main/res/values-fr/strings.xml | 6 - astrid/src/main/res/values-iw/strings.xml | 6 - astrid/src/main/res/values-ko/strings.xml | 6 - astrid/src/main/res/values-nl/strings.xml | 5 - astrid/src/main/res/values-pl/strings.xml | 5 - astrid/src/main/res/values-ru/strings.xml | 5 - astrid/src/main/res/values-uk/strings.xml | 2 - astrid/src/main/res/values/keys.xml | 9 +- astrid/src/main/res/values/strings-core.xml | 13 -- astrid/src/main/res/xml/preferences.xml | 6 - 18 files changed, 14 insertions(+), 254 deletions(-) delete mode 100644 astrid/src/main/java/com/todoroo/astrid/utility/AstridLitePreferenceSpec.java diff --git a/astrid/src/main/java/com/todoroo/astrid/activity/EditPreferences.java b/astrid/src/main/java/com/todoroo/astrid/activity/EditPreferences.java index 7740f8b09..e930cda36 100644 --- a/astrid/src/main/java/com/todoroo/astrid/activity/EditPreferences.java +++ b/astrid/src/main/java/com/todoroo/astrid/activity/EditPreferences.java @@ -5,12 +5,6 @@ */ package com.todoroo.astrid.activity; -import java.util.ArrayList; -import java.util.HashMap; -import java.util.LinkedHashMap; -import java.util.List; -import java.util.Map.Entry; - import android.content.DialogInterface; import android.content.DialogInterface.OnClickListener; import android.content.Intent; @@ -27,7 +21,6 @@ import android.preference.PreferenceManager; import android.preference.PreferenceScreen; import android.text.TextUtils; -import org.tasks.R; import com.todoroo.andlib.service.Autowired; import com.todoroo.andlib.service.ContextManager; import com.todoroo.andlib.service.DependencyInjectionService; @@ -47,13 +40,9 @@ import com.todoroo.astrid.helper.MetadataHelper; import com.todoroo.astrid.service.AddOnService; import com.todoroo.astrid.service.MarketStrategy.AmazonMarketStrategy; import com.todoroo.astrid.service.StartupService; -import com.todoroo.astrid.service.StatisticsConstants; import com.todoroo.astrid.service.TaskService; import com.todoroo.astrid.sync.SyncProviderPreferences; import com.todoroo.astrid.ui.TaskListFragmentPager; -import com.todoroo.astrid.utility.AstridDefaultPreferenceSpec; -import com.todoroo.astrid.utility.AstridLitePreferenceSpec; -import com.todoroo.astrid.utility.AstridPreferenceSpec; import com.todoroo.astrid.utility.Constants; import com.todoroo.astrid.utility.Flags; import com.todoroo.astrid.voice.VoiceInputAssistant; @@ -61,6 +50,14 @@ import com.todoroo.astrid.voice.VoiceOutputService; import com.todoroo.astrid.voice.VoiceRecognizer; import com.todoroo.astrid.widget.TasksWidget; +import org.tasks.R; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map.Entry; + /** * Displays the preference screen for users to edit their preferences * @@ -106,31 +103,6 @@ public class EditPreferences extends TodorooPreferenceActivity { } } - private class SetDefaultsClickListener implements OnPreferenceClickListener { - private final AstridPreferenceSpec spec; - private final int nameId; - private final String statistic; - public SetDefaultsClickListener(AstridPreferenceSpec spec, int nameId, String statistic) { - this.spec = spec; - this.nameId = nameId; - this.statistic = statistic; - } - - @Override - public boolean onPreferenceClick(Preference preference) { - DialogUtilities.okCancelDialog(EditPreferences.this, getString(R.string.EPr_config_dialog_title), - getString(R.string.EPr_config_dialog_text, getString(nameId)), new OnClickListener() { - @Override - public void onClick(DialogInterface dialog, int which) { - spec.resetDefaults(); - setResult(RESULT_CODE_PERFORMANCE_PREF_CHANGED); - finish(); - } - }, null); - return true; - } - } - @Override public int getPreferenceResource() { return R.xml.preferences; @@ -498,12 +470,6 @@ public class EditPreferences extends TodorooPreferenceActivity { findPreference(getString(R.string.p_hide_plus_button)).setOnPreferenceChangeListener(new SetResultOnPreferenceChangeListener(RESULT_CODE_PERFORMANCE_PREF_CHANGED)); - findPreference(getString(R.string.p_config_default)).setOnPreferenceClickListener( - new SetDefaultsClickListener(new AstridDefaultPreferenceSpec(), R.string.EPr_config_dialog_default_id, StatisticsConstants.PREFS_RESET_DEFAULT)); - - findPreference(getString(R.string.p_config_lite)).setOnPreferenceClickListener( - new SetDefaultsClickListener(new AstridLitePreferenceSpec(), R.string.EPr_config_lite, StatisticsConstants.PREFS_RESET_LITE)); - int[] menuPrefs = { R.string.p_show_menu_search, R.string.p_show_menu_sync, R.string.p_show_menu_sort, }; for (int key : menuPrefs) { diff --git a/astrid/src/main/java/com/todoroo/astrid/service/StatisticsConstants.java b/astrid/src/main/java/com/todoroo/astrid/service/StatisticsConstants.java index 76fc57057..57f055196 100644 --- a/astrid/src/main/java/com/todoroo/astrid/service/StatisticsConstants.java +++ b/astrid/src/main/java/com/todoroo/astrid/service/StatisticsConstants.java @@ -71,8 +71,6 @@ public class StatisticsConstants { public static final String PREMIUM_PAGE_VIEWED = "premium-page-viewed"; public static final String FEATURED_LIST_CLONED = "featured-list-cloned"; public static final String RANDOM_REMINDER_SAVED = "random-rmdr-save"; - public static final String PREFS_RESET_DEFAULT = "prefs-reset-default"; - public static final String PREFS_RESET_LITE = "prefs-reset-lite"; public static final String ACTFM_LOGIN_SIMPLE = "actfm-login-simple"; public static final String ACTFM_LOGIN_SIMPLE_REJECTED = "actfm-login-simple-rejected"; diff --git a/astrid/src/main/java/com/todoroo/astrid/service/UpgradeService.java b/astrid/src/main/java/com/todoroo/astrid/service/UpgradeService.java index 4ea2b5d13..d86b352b8 100644 --- a/astrid/src/main/java/com/todoroo/astrid/service/UpgradeService.java +++ b/astrid/src/main/java/com/todoroo/astrid/service/UpgradeService.java @@ -791,9 +791,6 @@ public final class UpgradeService { * @param changes */ private void newVersionString(StringBuilder changeLog, String version, String[] changes) { - if (Constants.ASTRID_LITE) { - version = "0" + version.substring(1); - } changeLog.append("Version ").append(version).append(":