From d446e009b43546947c9efaa02a759e731660f8a1 Mon Sep 17 00:00:00 2001
From: Alex Baker <alex@tasks.org>
Date: Tue, 13 May 2025 10:55:00 -0500
Subject: [PATCH] Fix lint

---
 .../notifications/NotificationManager.kt      | 23 ++++++++++++++++++-
 .../ThrottledNotificationManager.kt           |  2 ++
 2 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/app/src/main/java/org/tasks/notifications/NotificationManager.kt b/app/src/main/java/org/tasks/notifications/NotificationManager.kt
index 828826530..56484c655 100644
--- a/app/src/main/java/org/tasks/notifications/NotificationManager.kt
+++ b/app/src/main/java/org/tasks/notifications/NotificationManager.kt
@@ -1,9 +1,11 @@
 package org.tasks.notifications
 
+import android.Manifest
 import android.annotation.SuppressLint
 import android.app.PendingIntent
 import android.content.Context
 import android.content.Intent
+import androidx.annotation.RequiresPermission
 import androidx.core.app.NotificationCompat
 import androidx.core.app.NotificationManagerCompat.InterruptionFilter
 import com.todoroo.andlib.utility.AndroidUtilities.preUpsideDownCake
@@ -82,7 +84,11 @@ class NotificationManager @Inject constructor(
         }
     }
 
+    @SuppressLint("MissingPermission")
     suspend fun restoreNotifications(cancelExisting: Boolean) {
+        if (!permissionChecker.hasNotificationPermission()) {
+            return
+        }
         val notifications = notificationDao.getAllOrdered()
         if (cancelExisting) {
             for (notification in notifications) {
@@ -114,11 +120,16 @@ class NotificationManager @Inject constructor(
         }
     }
 
+    @SuppressLint("MissingPermission")
     suspend fun notifyTasks(
         newNotifications: List<Notification>,
         alert: Boolean,
         nonstop: Boolean,
-        fiveTimes: Boolean) {
+        fiveTimes: Boolean
+    ) {
+        if (!permissionChecker.hasNotificationPermission()) {
+            return
+        }
         val existingNotifications = notificationDao.getAllOrdered()
         notificationDao.insertAll(newNotifications)
         val totalCount = existingNotifications.size + newNotifications.size
@@ -167,6 +178,7 @@ class NotificationManager @Inject constructor(
         localBroadcastManager.broadcastRefresh()
     }
 
+    @SuppressLint("MissingPermission")
     private suspend fun createNotifications(
         notifications: List<Notification>,
         alert: Boolean,
@@ -204,6 +216,7 @@ class NotificationManager @Inject constructor(
         }
     }
 
+    @SuppressLint("MissingPermission")
     suspend fun notify(
             notificationId: Long,
             builder: NotificationCompat.Builder,
@@ -211,6 +224,9 @@ class NotificationManager @Inject constructor(
             nonstop: Boolean,
             fiveTimes: Boolean,
     ) {
+        if (!permissionChecker.hasNotificationPermission()) {
+            return
+        }
         if (preUpsideDownCake()) {
             builder.setLocalOnly(!preferences.getBoolean(R.string.p_wearable_notifications, true))
         }
@@ -245,6 +261,7 @@ class NotificationManager @Inject constructor(
         }
     }
 
+    @RequiresPermission(Manifest.permission.POST_NOTIFICATIONS)
     private suspend fun updateSummary(
             notify: Boolean,
             nonStop: Boolean,
@@ -415,7 +432,11 @@ class NotificationManager @Inject constructor(
                 .extend(wearableExtender)
     }
 
+    @SuppressLint("MissingPermission")
     suspend fun updateTimerNotification() {
+        if (!permissionChecker.hasNotificationPermission()) {
+            return
+        }
         val count = taskDao.activeTimers()
         if (count == 0) {
             cancel(Constants.NOTIFICATION_TIMER.toLong())
diff --git a/app/src/main/java/org/tasks/notifications/ThrottledNotificationManager.kt b/app/src/main/java/org/tasks/notifications/ThrottledNotificationManager.kt
index 0ab54afb2..c3c887d46 100644
--- a/app/src/main/java/org/tasks/notifications/ThrottledNotificationManager.kt
+++ b/app/src/main/java/org/tasks/notifications/ThrottledNotificationManager.kt
@@ -2,6 +2,7 @@ package org.tasks.notifications
 
 import android.app.Notification
 import android.content.Context
+import androidx.annotation.RequiresPermission
 import androidx.core.app.NotificationManagerCompat
 import androidx.core.app.NotificationManagerCompat.InterruptionFilter
 import dagger.hilt.android.qualifiers.ApplicationContext
@@ -25,6 +26,7 @@ class ThrottledNotificationManager @Inject constructor(
         }
     }
 
+    @RequiresPermission(android.Manifest.permission.POST_NOTIFICATIONS)
     fun notify(id: Int, notification: Notification) {
         throttle.run {
             notificationManagerCompat.notify(id, notification)