From d3ce1a41ac52738c3ede33fe818a72b1248440f8 Mon Sep 17 00:00:00 2001
From: Alex Baker <alex@tasks.org>
Date: Mon, 26 Oct 2020 11:45:31 -0500
Subject: [PATCH] Use postValue in CompletableViewModel

---
 app/src/main/java/org/tasks/ui/CompletableViewModel.kt | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/app/src/main/java/org/tasks/ui/CompletableViewModel.kt b/app/src/main/java/org/tasks/ui/CompletableViewModel.kt
index ca2f3edb4..1f79dc893 100644
--- a/app/src/main/java/org/tasks/ui/CompletableViewModel.kt
+++ b/app/src/main/java/org/tasks/ui/CompletableViewModel.kt
@@ -1,13 +1,12 @@
 package org.tasks.ui
 
 import androidx.lifecycle.*
-import io.reactivex.disposables.CompositeDisposable
 import kotlinx.coroutines.launch
+import timber.log.Timber
 
 abstract class CompletableViewModel<T> : ViewModel() {
     private val data = MutableLiveData<T>()
     private val error = MutableLiveData<Throwable>()
-    private val disposables = CompositeDisposable()
 
     var inProgress = false
         private set
@@ -28,16 +27,15 @@ abstract class CompletableViewModel<T> : ViewModel() {
         if (!inProgress) {
             inProgress = true
             try {
-                data.value = callable.invoke()
+                data.postValue(callable.invoke())
             } catch (e: Exception) {
-                error.value = e
+                Timber.e(e)
+                error.postValue(e)
             }
             inProgress = false
         }
     }
 
-    override fun onCleared() = disposables.dispose()
-
     fun removeObserver(owner: LifecycleOwner) {
         data.removeObservers(owner)
         error.removeObservers(owner)