No more managed cursors. They are causing trouble in ICS. Lots of trouble.

pull/14/head
Tim Su 14 years ago
parent 5cb3db64a7
commit c7a1f91230

@ -981,7 +981,6 @@ public class TaskListFragment extends ListFragment implements OnScrollListener,
taskAdapter.flushCaches(); taskAdapter.flushCaches();
taskAdapter.notifyDataSetChanged(); taskAdapter.notifyDataSetChanged();
} }
getActivity().startManagingCursor(taskCursor);
if (oldListItemSelected != ListView.INVALID_POSITION if (oldListItemSelected != ListView.INVALID_POSITION
&& oldListItemSelected < taskCursor.getCount()) && oldListItemSelected < taskCursor.getCount())
@ -1011,7 +1010,6 @@ public class TaskListFragment extends ListFragment implements OnScrollListener,
// perform query // perform query
TodorooCursor<Task> currentCursor = taskService.fetchFiltered( TodorooCursor<Task> currentCursor = taskService.fetchFiltered(
sqlQueryTemplate.get(), null, TaskAdapter.PROPERTIES); sqlQueryTemplate.get(), null, TaskAdapter.PROPERTIES);
getActivity().startManagingCursor(currentCursor);
// set up list adapters // set up list adapters
taskAdapter = new TaskAdapter(this, R.layout.task_adapter_row, taskAdapter = new TaskAdapter(this, R.layout.task_adapter_row,
@ -1059,7 +1057,6 @@ public class TaskListFragment extends ListFragment implements OnScrollListener,
currentCursor = taskService.fetchFiltered(sqlQueryTemplate.get(), null, currentCursor = taskService.fetchFiltered(sqlQueryTemplate.get(), null,
TaskAdapter.PROPERTIES); TaskAdapter.PROPERTIES);
getListView().setFilterText(""); getListView().setFilterText("");
getActivity().startManagingCursor(currentCursor);
taskAdapter.changeCursor(currentCursor); taskAdapter.changeCursor(currentCursor);

@ -243,7 +243,6 @@ public class TaskAdapter extends CursorAdapter implements Filterable {
// perform query // perform query
TodorooCursor<Task> newCursor = taskService.fetchFiltered( TodorooCursor<Task> newCursor = taskService.fetchFiltered(
query.get(), constraint, TaskAdapter.PROPERTIES); query.get(), constraint, TaskAdapter.PROPERTIES);
fragment.getActivity().startManagingCursor(newCursor);
return newCursor; return newCursor;
} }

@ -146,7 +146,6 @@ public class ContactListAdapter extends CursorAdapter {
String sort = Email.TIMES_CONTACTED + " DESC LIMIT 20"; String sort = Email.TIMES_CONTACTED + " DESC LIMIT 20";
Cursor peopleCursor = mContent.query(uri, PEOPLE_PROJECTION, Cursor peopleCursor = mContent.query(uri, PEOPLE_PROJECTION,
null, null, sort); null, null, sort);
activity.startManagingCursor(peopleCursor);
if(!completeSharedTags) if(!completeSharedTags)
return peopleCursor; return peopleCursor;
@ -159,7 +158,6 @@ public class ContactListAdapter extends CursorAdapter {
Cursor tagCursor = tagDataService.query(Query.select(TagData.ID, TagData.NAME, TagData.PICTURE, TagData.THUMB). Cursor tagCursor = tagDataService.query(Query.select(TagData.ID, TagData.NAME, TagData.PICTURE, TagData.THUMB).
where(Criterion.and(TagData.USER_ID.eq(0), TagData.MEMBER_COUNT.gt(0), where(Criterion.and(TagData.USER_ID.eq(0), TagData.MEMBER_COUNT.gt(0),
crit)).orderBy(Order.desc(TagData.NAME))); crit)).orderBy(Order.desc(TagData.NAME)));
activity.startManagingCursor(tagCursor);
return new MergeCursor(new Cursor[] { tagCursor, peopleCursor }); return new MergeCursor(new Cursor[] { tagCursor, peopleCursor });
} }

Loading…
Cancel
Save