From c2d1b0276190d046abc60ed3c13b8e96af6e1b42 Mon Sep 17 00:00:00 2001
From: Alex Baker <baker.alex@gmail.com>
Date: Wed, 25 Jun 2014 08:12:07 -0500
Subject: [PATCH] Remove array conversions from in criterion

---
 api/src/main/java/com/todoroo/andlib/sql/Field.java      | 2 +-
 .../com/todoroo/astrid/gtasks/GtasksMetadataService.java | 3 +--
 .../todoroo/astrid/gtasks/sync/GtasksSyncV2Provider.java | 3 +--
 .../java/com/todoroo/astrid/subtasks/SubtasksHelper.java | 9 +++++----
 .../com/todoroo/astrid/utility/SyncMetadataService.java  | 5 +----
 5 files changed, 9 insertions(+), 13 deletions(-)

diff --git a/api/src/main/java/com/todoroo/andlib/sql/Field.java b/api/src/main/java/com/todoroo/andlib/sql/Field.java
index d74330cf8..708b3a005 100644
--- a/api/src/main/java/com/todoroo/andlib/sql/Field.java
+++ b/api/src/main/java/com/todoroo/andlib/sql/Field.java
@@ -78,7 +78,7 @@ public class Field extends DBObject<Field> {
         return UnaryCriterion.like(this, value, escape);
     }
 
-    public <T> Criterion in(final T[] value) {
+    public <T> Criterion in(final Iterable<T> value) {
         final Field field = this;
         return new Criterion(Operator.in) {
 
diff --git a/astrid/src/main/java/com/todoroo/astrid/gtasks/GtasksMetadataService.java b/astrid/src/main/java/com/todoroo/astrid/gtasks/GtasksMetadataService.java
index 257c94378..8c6798b3f 100644
--- a/astrid/src/main/java/com/todoroo/astrid/gtasks/GtasksMetadataService.java
+++ b/astrid/src/main/java/com/todoroo/astrid/gtasks/GtasksMetadataService.java
@@ -126,8 +126,7 @@ public final class GtasksMetadataService extends SyncMetadataService<GtasksTaskC
             taskIds.remove(metadata.get(Metadata.TASK));
         }
 
-        return taskDao.query(Query.select(Task.ID).where(
-                Task.ID.in(taskIds.toArray(new Long[taskIds.size()]))));
+        return taskDao.query(Query.select(Task.ID).where(Task.ID.in(taskIds)));
     }
 
     // --- list iterating helpers
diff --git a/astrid/src/main/java/com/todoroo/astrid/gtasks/sync/GtasksSyncV2Provider.java b/astrid/src/main/java/com/todoroo/astrid/gtasks/sync/GtasksSyncV2Provider.java
index fcf77ce42..58d3c75bf 100644
--- a/astrid/src/main/java/com/todoroo/astrid/gtasks/sync/GtasksSyncV2Provider.java
+++ b/astrid/src/main/java/com/todoroo/astrid/gtasks/sync/GtasksSyncV2Provider.java
@@ -279,10 +279,9 @@ public class GtasksSyncV2Provider extends SyncV2Provider {
                 storeObjectDao.persist(list);
 
                 if(lastSyncDate == 0 && !isImport) {
-                    Long[] localIdArray = localIds.toArray(new Long[localIds.size()]);
                     Criterion delete = Criterion.and(Metadata.KEY.eq(GtasksMetadata.METADATA_KEY),
                             GtasksMetadata.LIST_ID.eq(listId),
-                            Criterion.not(Metadata.TASK.in(localIdArray)));
+                            Criterion.not(Metadata.TASK.in(localIds)));
                     taskDeleter.deleteWhere(
                             Task.ID.in(Query.select(Metadata.TASK).from(Metadata.TABLE).
                                     where(delete)));
diff --git a/astrid/src/main/java/com/todoroo/astrid/subtasks/SubtasksHelper.java b/astrid/src/main/java/com/todoroo/astrid/subtasks/SubtasksHelper.java
index 40686f777..93fcdfc27 100644
--- a/astrid/src/main/java/com/todoroo/astrid/subtasks/SubtasksHelper.java
+++ b/astrid/src/main/java/com/todoroo/astrid/subtasks/SubtasksHelper.java
@@ -27,6 +27,7 @@ import org.tasks.preferences.Preferences;
 
 import java.util.ArrayList;
 import java.util.HashMap;
+import java.util.List;
 
 public class SubtasksHelper {
 
@@ -103,7 +104,7 @@ public class SubtasksHelper {
     }
 
     @Deprecated
-    private static Long[] getIdArray(String serializedTree) {
+    private static List<Long> getIdList(String serializedTree) {
         ArrayList<Long> ids = new ArrayList<>();
         String[] digitsOnly = serializedTree.split("[\\[\\],\\s]"); // Split on [ ] , or whitespace chars
         for (String idString : digitsOnly) {
@@ -115,7 +116,7 @@ public class SubtasksHelper {
                 log.error(e.getMessage(), e);
             }
         }
-        return ids.toArray(new Long[ids.size()]);
+        return ids;
     }
 
     public static String[] getStringIdArray(String serializedTree) {
@@ -133,7 +134,7 @@ public class SubtasksHelper {
      * Takes a subtasks string containing local ids and remaps it to one containing UUIDs
      */
     public static String convertTreeToRemoteIds(TaskService taskService, String localTree) {
-        Long[] localIds = getIdArray(localTree);
+        List<Long> localIds = getIdList(localTree);
         HashMap<Long, String> idMap = getIdMap(taskService, localIds, Task.ID, Task.UUID);
         idMap.put(-1L, "-1"); //$NON-NLS-1$
 
@@ -178,7 +179,7 @@ public class SubtasksHelper {
         });
     }
 
-    private static <A, B> HashMap<A, B> getIdMap(TaskService taskService, A[] keys, Property<A> keyProperty, Property<B> valueProperty) {
+    private static <A, B> HashMap<A, B> getIdMap(TaskService taskService, Iterable<A> keys, Property<A> keyProperty, Property<B> valueProperty) {
         HashMap<A, B> map = new HashMap<>();
         TodorooCursor<Task> tasks = taskService.query(Query.select(keyProperty, valueProperty).where(keyProperty.in(keys)));
         try {
diff --git a/astrid/src/main/java/com/todoroo/astrid/utility/SyncMetadataService.java b/astrid/src/main/java/com/todoroo/astrid/utility/SyncMetadataService.java
index 8bda33a41..29df8809c 100644
--- a/astrid/src/main/java/com/todoroo/astrid/utility/SyncMetadataService.java
+++ b/astrid/src/main/java/com/todoroo/astrid/utility/SyncMetadataService.java
@@ -105,10 +105,7 @@ abstract public class SyncMetadataService<TYPE extends SyncContainer> {
             try {
                 ArrayList<Long> matchingRows = new ArrayList<>();
                 joinRows(tasks, metadata, matchingRows, both);
-
-                return
-                taskDao.query(Query.select(properties).where(Task.ID.in(
-                        matchingRows.toArray(new Long[matchingRows.size()]))));
+                return taskDao.query(Query.select(properties).where(Task.ID.in(matchingRows)));
             } finally {
                 metadata.close();
             }