From c1c3d56365bdcf0cbdf90798870b35ae2434b3de Mon Sep 17 00:00:00 2001 From: Sam Bosley Date: Tue, 23 Oct 2012 12:42:34 -0700 Subject: [PATCH] Adjust statistics gathering for subtasks --- .../todoroo/astrid/service/StartupService.java | 15 +++++++++------ .../astrid/service/StatisticsConstants.java | 1 + 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/astrid/src/com/todoroo/astrid/service/StartupService.java b/astrid/src/com/todoroo/astrid/service/StartupService.java index 184569bd3..cb59ae9a7 100644 --- a/astrid/src/com/todoroo/astrid/service/StartupService.java +++ b/astrid/src/com/todoroo/astrid/service/StartupService.java @@ -308,12 +308,15 @@ public class StartupService { private void checkForSubtasksUse() { if (!Preferences.getBoolean(PREF_SUBTASKS_CHECK, false)) { - checkMetadataStat(Criterion.and(MetadataCriteria.withKey(SubtasksMetadata.METADATA_KEY), - SubtasksMetadata.ORDER.gt(0)), StatisticsConstants.SUBTASKS_ORDER_USED); - checkMetadataStat(Criterion.and(MetadataCriteria.withKey(SubtasksMetadata.METADATA_KEY), - SubtasksMetadata.INDENT.gt(0)), StatisticsConstants.SUBTASKS_INDENT_USED); - checkMetadataStat(Criterion.and(MetadataCriteria.withKey(GtasksMetadata.METADATA_KEY), - GtasksMetadata.INDENT.gt(0)), StatisticsConstants.GTASKS_INDENT_USED); + if (taskService.countTasks() > 3) { + StatisticsService.reportEvent(StatisticsConstants.SUBTASKS_HAS_TASKS); + checkMetadataStat(Criterion.and(MetadataCriteria.withKey(SubtasksMetadata.METADATA_KEY), + SubtasksMetadata.ORDER.gt(0)), StatisticsConstants.SUBTASKS_ORDER_USED); + checkMetadataStat(Criterion.and(MetadataCriteria.withKey(SubtasksMetadata.METADATA_KEY), + SubtasksMetadata.INDENT.gt(0)), StatisticsConstants.SUBTASKS_INDENT_USED); + checkMetadataStat(Criterion.and(MetadataCriteria.withKey(GtasksMetadata.METADATA_KEY), + GtasksMetadata.INDENT.gt(0)), StatisticsConstants.GTASKS_INDENT_USED); + } Preferences.setBoolean(PREF_SUBTASKS_CHECK, true); } } diff --git a/astrid/src/com/todoroo/astrid/service/StatisticsConstants.java b/astrid/src/com/todoroo/astrid/service/StatisticsConstants.java index 1bbb43fe5..7de243e8f 100644 --- a/astrid/src/com/todoroo/astrid/service/StatisticsConstants.java +++ b/astrid/src/com/todoroo/astrid/service/StatisticsConstants.java @@ -74,6 +74,7 @@ public class StatisticsConstants { public static final String SHARE_PAGE_VIEWED = "share-page-viewed"; public static final String SHARE_BUTTON_CLICKED = "share-button-clicked"; + public static final String SUBTASKS_HAS_TASKS = "subtasks-has-tasks"; public static final String SUBTASKS_ORDER_USED = "subtasks-order-used"; public static final String SUBTASKS_INDENT_USED = "subtasks-indent-used"; public static final String GTASKS_INDENT_USED = "gtasks-indent-used";