Fixed bugs with progress bar callbacks getting mixed up with views in different fragments

astrid/plugin-src/com/todoroo/astrid/actfm/TagUpdatesFragment.java

@@ -226,29 +226,31 @@ public class TagUpdatesFragment extends ListFragment {
     }
 
     private void refreshActivity(boolean manual) {
-        final ProgressBarSyncResultCallback callback = new ProgressBarSyncResultCallback(
-                getActivity(), R.id.progressBar, new Runnable() {
-                    @Override
-                    public void run() {
-                        refreshUpdatesList();
-                    }
-                });
-
-        callback.started();
-        callback.incrementMax(100);
-        Runnable doneRunnable = new Runnable() {
-            @Override
-            public void run() {
-                callback.incrementProgress(50);
-                callback.finished();
+        if (actFmPreferenceService.isLoggedIn()) {
+            final ProgressBarSyncResultCallback callback = new ProgressBarSyncResultCallback(
+                    getActivity(), R.id.progressBar, new Runnable() {
+                        @Override
+                        public void run() {
+                            refreshUpdatesList();
+                        }
+                    });
+
+            callback.started();
+            callback.incrementMax(100);
+            Runnable doneRunnable = new Runnable() {
+                @Override
+                public void run() {
+                    callback.incrementProgress(50);
+                    callback.finished();
+                }
+            };
+            if (tagData != null) {
+                actFmSyncService.fetchUpdatesForTag(tagData, manual, doneRunnable);
+            } else {
+                actFmSyncService.fetchPersonalUpdates(manual, doneRunnable);
             }
-        };
-        if (tagData != null) {
-            actFmSyncService.fetchUpdatesForTag(tagData, manual, doneRunnable);
-        } else {
-            actFmSyncService.fetchPersonalUpdates(manual, doneRunnable);
+            callback.incrementProgress(50);
         }
-        callback.incrementProgress(50);
     }
 
     @SuppressWarnings("nls")

astrid/res/layout/tag_updates_fragment.xml

@@ -6,7 +6,7 @@
     android:orientation="vertical" >
 
     <ProgressBar
-        android:id="@+id/progressBar"
+        android:id="@+id/comments_progressBar"
         style="@android:style/Widget.ProgressBar.Horizontal"
         android:layout_width="fill_parent"
         android:layout_height="5dip"

astrid/src/com/todoroo/astrid/activity/TaskListFragment.java

@@ -594,6 +594,7 @@ public class TaskListFragment extends ListFragment implements OnScrollListener,
                                         AstridApiConstants.BROADCAST_EVENT_REFRESH));
                     }
                 });
+        getView().findViewById(R.id.progressBar).setVisibility(View.GONE);
     }
 
     // Subclasses can override these to customize extras in quickadd intent
@@ -1308,6 +1309,7 @@ public class TaskListFragment extends ListFragment implements OnScrollListener,
     }
 
     protected void performSyncServiceV2Sync(boolean manual) {
+        System.err.println("Autosyncing");
         syncService.synchronizeActiveTasks(manual, syncResultCallback);
         Preferences.setLong(PREF_LAST_AUTO_SYNC, DateUtilities.now());
     }