diff --git a/app/src/main/java/com/todoroo/astrid/api/CaldavFilter.java b/app/src/main/java/com/todoroo/astrid/api/CaldavFilter.java index 2fe6b0d93..0d7a2800c 100644 --- a/app/src/main/java/com/todoroo/astrid/api/CaldavFilter.java +++ b/app/src/main/java/com/todoroo/astrid/api/CaldavFilter.java @@ -4,7 +4,6 @@ import android.os.Parcel; import android.os.Parcelable; import androidx.annotation.NonNull; import com.todoroo.andlib.sql.Criterion; -import com.todoroo.andlib.sql.Field; import com.todoroo.andlib.sql.Join; import com.todoroo.andlib.sql.QueryTemplate; import com.todoroo.astrid.dao.TaskDao; @@ -51,15 +50,15 @@ public class CaldavFilter extends Filter { private static QueryTemplate queryTemplate(CaldavCalendar caldavCalendar) { return new QueryTemplate() - .join(Join.left(CaldavTask.TABLE, Task.ID.eq(Field.field("caldav_tasks.cd_task")))) + .join(Join.left(CaldavTask.TABLE, Task.ID.eq(CaldavTask.TASK))) .where(getCriterion(caldavCalendar)); } public static Criterion getCriterion(CaldavCalendar caldavCalendar) { return Criterion.and( TaskDao.TaskCriteria.activeAndVisible(), - Field.field("caldav_tasks.cd_deleted").eq(0), - Field.field("caldav_tasks.cd_calendar").eq(caldavCalendar.getUuid())); + CaldavTask.DELETED.eq(0), + CaldavTask.CALENDAR.eq(caldavCalendar.getUuid())); } private static Map getValuesForNewTask(CaldavCalendar caldavCalendar) { @@ -89,11 +88,6 @@ public class CaldavFilter extends Filter { calendar = source.readParcelable(getClass().getClassLoader()); } - @Override - public boolean supportsSubtasks() { - return false; - } - @Override public int getMenu() { return R.menu.menu_caldav_list_fragment; diff --git a/app/src/main/java/com/todoroo/astrid/api/GtasksFilter.java b/app/src/main/java/com/todoroo/astrid/api/GtasksFilter.java index d76abbce2..804ee9b70 100644 --- a/app/src/main/java/com/todoroo/astrid/api/GtasksFilter.java +++ b/app/src/main/java/com/todoroo/astrid/api/GtasksFilter.java @@ -4,7 +4,6 @@ import android.os.Parcel; import android.os.Parcelable; import androidx.annotation.NonNull; import com.todoroo.andlib.sql.Criterion; -import com.todoroo.andlib.sql.Field; import com.todoroo.andlib.sql.Join; import com.todoroo.andlib.sql.QueryTemplate; import com.todoroo.astrid.dao.TaskDao; @@ -70,15 +69,15 @@ public class GtasksFilter extends Filter { private static QueryTemplate getQueryTemplate(GoogleTaskList list) { return new QueryTemplate() - .join(Join.left(GoogleTask.TABLE, Task.ID.eq(Field.field("google_tasks.gt_task")))) + .join(Join.left(GoogleTask.TABLE, Task.ID.eq(GoogleTask.TASK))) .where(getCriterion(list)); } public static Criterion getCriterion(GoogleTaskList list) { return Criterion.and( TaskDao.TaskCriteria.activeAndVisible(), - Field.field("google_tasks.gt_deleted").eq(0), - Field.field("google_tasks.gt_list_id").eq(list.getRemoteId())); + GoogleTask.DELETED.eq(0), + GoogleTask.LIST.eq(list.getRemoteId())); } private static Map getValuesForNewTasks(GoogleTaskList list) { diff --git a/app/src/main/java/org/tasks/data/CaldavTask.java b/app/src/main/java/org/tasks/data/CaldavTask.java index 8eeb70312..54b2ff8f8 100644 --- a/app/src/main/java/org/tasks/data/CaldavTask.java +++ b/app/src/main/java/org/tasks/data/CaldavTask.java @@ -14,7 +14,7 @@ public class CaldavTask { public static final String KEY = "caldav"; - @Deprecated public static final Table TABLE = new Table("caldav_tasks"); + public static final Table TABLE = new Table("caldav_tasks"); public static final Property.IntegerProperty PARENT = new Property.IntegerProperty(TABLE, "cd_parent"); @@ -22,6 +22,12 @@ public class CaldavTask { public static final Property.IntegerProperty TASK = new Property.IntegerProperty(TABLE, "cd_task"); + public static final Property.LongProperty DELETED = + new Property.LongProperty(TABLE, "cd_deleted"); + + public static final Property.StringProperty CALENDAR = + new Property.StringProperty(TABLE, "cd_calendar"); + @PrimaryKey(autoGenerate = true) @ColumnInfo(name = "cd_id") private long id; diff --git a/app/src/main/java/org/tasks/data/GoogleTask.java b/app/src/main/java/org/tasks/data/GoogleTask.java index 55452d975..70b4db417 100644 --- a/app/src/main/java/org/tasks/data/GoogleTask.java +++ b/app/src/main/java/org/tasks/data/GoogleTask.java @@ -12,9 +12,8 @@ public class GoogleTask { public static final String KEY = "gtasks"; // $NON-NLS-1$ - @Deprecated public static final Table TABLE = new Table("google_tasks"); + public static final Table TABLE = new Table("google_tasks"); - @Deprecated public static final Property.IntegerProperty ORDER = new Property.IntegerProperty(GoogleTask.TABLE, "gt_order"); @@ -24,6 +23,12 @@ public class GoogleTask { public static final Property.IntegerProperty TASK = new Property.IntegerProperty(TABLE, "gt_task"); + public static final Property.LongProperty DELETED = + new Property.LongProperty(TABLE, "gt_deleted"); + + public static final Property.StringProperty LIST = + new Property.StringProperty(TABLE, "gt_list_id"); + @PrimaryKey(autoGenerate = true) @ColumnInfo(name = "gt_id") private transient long id; diff --git a/app/src/main/java/org/tasks/ui/TaskListViewModel.java b/app/src/main/java/org/tasks/ui/TaskListViewModel.java index bbc07aabf..5938ae056 100644 --- a/app/src/main/java/org/tasks/ui/TaskListViewModel.java +++ b/app/src/main/java/org/tasks/ui/TaskListViewModel.java @@ -23,7 +23,6 @@ import com.todoroo.andlib.data.Table; import com.todoroo.andlib.sql.Criterion; import com.todoroo.andlib.sql.Field; import com.todoroo.andlib.sql.Join; -import com.todoroo.andlib.sql.Order; import com.todoroo.andlib.sql.Query; import com.todoroo.andlib.sql.QueryTemplate; import com.todoroo.astrid.api.CaldavFilter; @@ -57,6 +56,7 @@ public class TaskListViewModel extends ViewModel implements Observer