diff --git a/src/amazon/java/org/tasks/analytics/Tracker.java b/src/amazon/java/org/tasks/analytics/Tracker.java index 60aacb904..f79328899 100644 --- a/src/amazon/java/org/tasks/analytics/Tracker.java +++ b/src/amazon/java/org/tasks/analytics/Tracker.java @@ -33,20 +33,17 @@ public class Tracker { tracker = analytics.newTracker(R.xml.google_analytics); tracker.setAppVersion(Integer.toString(BuildConfig.VERSION_CODE)); final StandardExceptionParser standardExceptionParser = new StandardExceptionParser(context, null); - exceptionParser = new ExceptionParser() { - @Override - public String getDescription(String thread, Throwable throwable) { - StringBuilder stack = new StringBuilder() - .append(standardExceptionParser.getDescription(thread, throwable)) - .append("\n") - .append(throwable.getClass().getName()) + exceptionParser = (thread, throwable) -> { + StringBuilder stack = new StringBuilder() + .append(standardExceptionParser.getDescription(thread, throwable)) + .append("\n") + .append(throwable.getClass().getName()) + .append("\n"); + for (StackTraceElement element : throwable.getStackTrace()) { + stack.append(element.toString()) .append("\n"); - for (StackTraceElement element : throwable.getStackTrace()) { - stack.append(element.toString()) - .append("\n"); - } - return stack.toString(); } + return stack.toString(); }; ExceptionReporter reporter = new ExceptionReporter( tracker, diff --git a/src/googleplay/AndroidManifest.xml b/src/googleplay/AndroidManifest.xml index 151553f91..11eb6fa7f 100644 --- a/src/googleplay/AndroidManifest.xml +++ b/src/googleplay/AndroidManifest.xml @@ -30,7 +30,7 @@ - + + android:exported="true" + android:permission="signature"> diff --git a/src/main/java/com/todoroo/astrid/provider/Astrid3ContentProvider.java b/src/main/java/com/todoroo/astrid/provider/Astrid3ContentProvider.java index bece6cdfc..1a3e4dc44 100644 --- a/src/main/java/com/todoroo/astrid/provider/Astrid3ContentProvider.java +++ b/src/main/java/com/todoroo/astrid/provider/Astrid3ContentProvider.java @@ -5,6 +5,7 @@ */ package com.todoroo.astrid.provider; +import android.annotation.SuppressLint; import android.content.ContentResolver; import android.content.ContentUris; import android.content.ContentValues; @@ -78,6 +79,7 @@ public class Astrid3ContentProvider extends InjectingContentProvider { private static final UriMatcher uriMatcher; + @SuppressLint("StaticFieldLeak") private static Database databaseOverride; // --- instance variables diff --git a/src/main/java/com/todoroo/astrid/reminders/ReminderService.java b/src/main/java/com/todoroo/astrid/reminders/ReminderService.java index 71006844b..cd69b4dd4 100644 --- a/src/main/java/com/todoroo/astrid/reminders/ReminderService.java +++ b/src/main/java/com/todoroo/astrid/reminders/ReminderService.java @@ -5,6 +5,7 @@ */ package com.todoroo.astrid.reminders; +import android.annotation.SuppressLint; import android.app.PendingIntent; import android.content.Context; import android.content.Intent; @@ -345,7 +346,7 @@ public final class ReminderService { // calculate the unique requestCode as a combination of the task-id and alarm-type: // concatenate id+type to keep the combo unique - String rc = String.format("%d%d", task.getId(), type); + @SuppressLint("DefaultLocale") String rc = String.format("%d%d", task.getId(), type); int requestCode; try { requestCode = Integer.parseInt(rc); diff --git a/src/main/res/drawable/ic_add_24dp.xml b/src/main/res/drawable/ic_add_24dp.xml index 51b073bd2..d1880fe4c 100644 --- a/src/main/res/drawable/ic_add_24dp.xml +++ b/src/main/res/drawable/ic_add_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_arrow_back_24dp.xml b/src/main/res/drawable/ic_arrow_back_24dp.xml index d9839b1c6..c61085ceb 100644 --- a/src/main/res/drawable/ic_arrow_back_24dp.xml +++ b/src/main/res/drawable/ic_arrow_back_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_attachment_24dp.xml b/src/main/res/drawable/ic_attachment_24dp.xml index 115de53d8..3bd752d27 100644 --- a/src/main/res/drawable/ic_attachment_24dp.xml +++ b/src/main/res/drawable/ic_attachment_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_camera_alt_black_24dp.xml b/src/main/res/drawable/ic_camera_alt_black_24dp.xml index bd0236887..c9d70e51c 100644 --- a/src/main/res/drawable/ic_camera_alt_black_24dp.xml +++ b/src/main/res/drawable/ic_camera_alt_black_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_cancel_24dp.xml b/src/main/res/drawable/ic_cancel_24dp.xml index 1a1352f61..84d0ca10a 100644 --- a/src/main/res/drawable/ic_cancel_24dp.xml +++ b/src/main/res/drawable/ic_cancel_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_close_24dp.xml b/src/main/res/drawable/ic_close_24dp.xml index 4ee27e28a..87f7b6f4b 100644 --- a/src/main/res/drawable/ic_close_24dp.xml +++ b/src/main/res/drawable/ic_close_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_cloud_queue_24dp.xml b/src/main/res/drawable/ic_cloud_queue_24dp.xml index 1ee8bbe43..69f2695fe 100644 --- a/src/main/res/drawable/ic_cloud_queue_24dp.xml +++ b/src/main/res/drawable/ic_cloud_queue_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_delete_24dp.xml b/src/main/res/drawable/ic_delete_24dp.xml index 7d4a324bc..6c630067a 100644 --- a/src/main/res/drawable/ic_delete_24dp.xml +++ b/src/main/res/drawable/ic_delete_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_event_24dp.xml b/src/main/res/drawable/ic_event_24dp.xml index e3d306ab7..b111abe45 100644 --- a/src/main/res/drawable/ic_event_24dp.xml +++ b/src/main/res/drawable/ic_event_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_event_note_24dp.xml b/src/main/res/drawable/ic_event_note_24dp.xml index 614f4a769..3bc83daa8 100644 --- a/src/main/res/drawable/ic_event_note_24dp.xml +++ b/src/main/res/drawable/ic_event_note_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_filter_list_24dp.xml b/src/main/res/drawable/ic_filter_list_24dp.xml index 61dcd3a32..95eafe1ce 100644 --- a/src/main/res/drawable/ic_filter_list_24dp.xml +++ b/src/main/res/drawable/ic_filter_list_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_flag_24dp.xml b/src/main/res/drawable/ic_flag_24dp.xml index 4a65626f0..fb62f7b74 100644 --- a/src/main/res/drawable/ic_flag_24dp.xml +++ b/src/main/res/drawable/ic_flag_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_help_24dp.xml b/src/main/res/drawable/ic_help_24dp.xml index f45935e6f..939ef35c0 100644 --- a/src/main/res/drawable/ic_help_24dp.xml +++ b/src/main/res/drawable/ic_help_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_history_24dp.xml b/src/main/res/drawable/ic_history_24dp.xml index 5751bac08..603afc433 100644 --- a/src/main/res/drawable/ic_history_24dp.xml +++ b/src/main/res/drawable/ic_history_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_inbox_24dp.xml b/src/main/res/drawable/ic_inbox_24dp.xml index f40fed818..7aacd65b8 100644 --- a/src/main/res/drawable/ic_inbox_24dp.xml +++ b/src/main/res/drawable/ic_inbox_24dp.xml @@ -1,5 +1,7 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_label_24dp.xml b/src/main/res/drawable/ic_label_24dp.xml index 07164af55..3739eec2f 100644 --- a/src/main/res/drawable/ic_label_24dp.xml +++ b/src/main/res/drawable/ic_label_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_lens_black_24dp.xml b/src/main/res/drawable/ic_lens_black_24dp.xml index 036d4b198..68d0c4781 100644 --- a/src/main/res/drawable/ic_lens_black_24dp.xml +++ b/src/main/res/drawable/ic_lens_black_24dp.xml @@ -1,5 +1,7 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_menu_24dp.xml b/src/main/res/drawable/ic_menu_24dp.xml index 89198a3f9..def231a41 100644 --- a/src/main/res/drawable/ic_menu_24dp.xml +++ b/src/main/res/drawable/ic_menu_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_mic_24dp.xml b/src/main/res/drawable/ic_mic_24dp.xml index ac5e85609..51e5b18ec 100644 --- a/src/main/res/drawable/ic_mic_24dp.xml +++ b/src/main/res/drawable/ic_mic_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_notifications_24dp.xml b/src/main/res/drawable/ic_notifications_24dp.xml index 452854311..b3aaf83e5 100644 --- a/src/main/res/drawable/ic_notifications_24dp.xml +++ b/src/main/res/drawable/ic_notifications_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_pause_24dp.xml b/src/main/res/drawable/ic_pause_24dp.xml index b2ff04582..3b1fa7bea 100644 --- a/src/main/res/drawable/ic_pause_24dp.xml +++ b/src/main/res/drawable/ic_pause_24dp.xml @@ -1,5 +1,7 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_play_arrow_24dp.xml b/src/main/res/drawable/ic_play_arrow_24dp.xml index 3100224e2..004d1e373 100644 --- a/src/main/res/drawable/ic_play_arrow_24dp.xml +++ b/src/main/res/drawable/ic_play_arrow_24dp.xml @@ -1,5 +1,7 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_repeat_24dp.xml b/src/main/res/drawable/ic_repeat_24dp.xml index 4dd2efdba..ae95d9a18 100644 --- a/src/main/res/drawable/ic_repeat_24dp.xml +++ b/src/main/res/drawable/ic_repeat_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_save_24dp.xml b/src/main/res/drawable/ic_save_24dp.xml index c26fb3328..d6e80ca88 100644 --- a/src/main/res/drawable/ic_save_24dp.xml +++ b/src/main/res/drawable/ic_save_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_schedule_24dp.xml b/src/main/res/drawable/ic_schedule_24dp.xml index ad969d6d6..6ab9e55cd 100644 --- a/src/main/res/drawable/ic_schedule_24dp.xml +++ b/src/main/res/drawable/ic_schedule_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_search_24dp.xml b/src/main/res/drawable/ic_search_24dp.xml index 173d7cc2f..9f93d61d8 100644 --- a/src/main/res/drawable/ic_search_24dp.xml +++ b/src/main/res/drawable/ic_search_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_settings_24dp.xml b/src/main/res/drawable/ic_settings_24dp.xml index f125782f0..1960419fd 100644 --- a/src/main/res/drawable/ic_settings_24dp.xml +++ b/src/main/res/drawable/ic_settings_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_sort_24dp.xml b/src/main/res/drawable/ic_sort_24dp.xml index 3735be4cb..5c29bbc1e 100644 --- a/src/main/res/drawable/ic_sort_24dp.xml +++ b/src/main/res/drawable/ic_sort_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_timer_24dp.xml b/src/main/res/drawable/ic_timer_24dp.xml index fa9420593..6fe292256 100644 --- a/src/main/res/drawable/ic_timer_24dp.xml +++ b/src/main/res/drawable/ic_timer_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_today_24dp.xml b/src/main/res/drawable/ic_today_24dp.xml index b3e52fa2c..abf24daad 100644 --- a/src/main/res/drawable/ic_today_24dp.xml +++ b/src/main/res/drawable/ic_today_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_visibility_off_24dp.xml b/src/main/res/drawable/ic_visibility_off_24dp.xml index 59a614550..05876daa1 100644 --- a/src/main/res/drawable/ic_visibility_off_24dp.xml +++ b/src/main/res/drawable/ic_visibility_off_24dp.xml @@ -1,6 +1,8 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/drawable/ic_vpn_key_black_24dp.xml b/src/main/res/drawable/ic_vpn_key_black_24dp.xml index a1098cfb1..714981a1f 100644 --- a/src/main/res/drawable/ic_vpn_key_black_24dp.xml +++ b/src/main/res/drawable/ic_vpn_key_black_24dp.xml @@ -1,5 +1,7 @@ - + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android" + tools:ignore="UnusedAttribute"> diff --git a/src/main/res/layout/alarm_edit_row.xml b/src/main/res/layout/alarm_edit_row.xml index c2953e83e..99ea23ca2 100644 --- a/src/main/res/layout/alarm_edit_row.xml +++ b/src/main/res/layout/alarm_edit_row.xml @@ -4,7 +4,8 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:paddingBottom="@dimen/task_edit_double_padding_top_bottom" - android:layout_marginBottom="@dimen/task_edit_double_padding_top_bottom"> + android:layout_marginBottom="@dimen/task_edit_double_padding_top_bottom" + android:baselineAligned="false"> + android:scaleType="fitCenter" /> + android:background="@drawable/speech_bubble_reminder" > + android:orientation="horizontal" + tools:ignore="DisableBaselineAlignment"> + android:orientation="horizontal" + android:baselineAligned="false"> + android:buttonTint="@color/importance_4" + tools:ignore="UnusedAttribute" /> + android:buttonTint="@color/importance_3" + tools:ignore="UnusedAttribute" /> + android:buttonTint="@color/importance_2" + tools:ignore="UnusedAttribute" /> + android:buttonTint="@color/importance_1" + tools:ignore="UnusedAttribute" /> diff --git a/src/main/res/layout/control_set_repeat_display.xml b/src/main/res/layout/control_set_repeat_display.xml index 453d4ed31..749c638e6 100644 --- a/src/main/res/layout/control_set_repeat_display.xml +++ b/src/main/res/layout/control_set_repeat_display.xml @@ -6,7 +6,8 @@ + android:orientation="horizontal" + android:baselineAligned="false"> + android:orientation="horizontal" + android:baselineAligned="false"> @@ -22,6 +23,7 @@ android:layout_toStartOf="@id/clear" android:gravity="start" android:textDirection="locale" - android:textColor="?attr/asTextColor" /> + android:textColor="?attr/asTextColor" + tools:ignore="UnusedAttribute" /> diff --git a/src/main/res/layout/filter_adapter_row.xml b/src/main/res/layout/filter_adapter_row.xml index 2b884c77f..250b92d04 100644 --- a/src/main/res/layout/filter_adapter_row.xml +++ b/src/main/res/layout/filter_adapter_row.xml @@ -1,5 +1,6 @@ + android:textColor="?android:attr/textColorSecondary" + tools:ignore="UnusedAttribute" /> + android:textSize="14sp" + tools:ignore="UnusedAttribute" /> diff --git a/src/main/res/layout/filter_adapter_subheader.xml b/src/main/res/layout/filter_adapter_subheader.xml index ee24a5848..cac10ce56 100644 --- a/src/main/res/layout/filter_adapter_subheader.xml +++ b/src/main/res/layout/filter_adapter_subheader.xml @@ -1,5 +1,6 @@ + android:layout_height="fill_parent" + tools:ignore="UnusedAttribute" /> \ No newline at end of file diff --git a/src/main/res/layout/filter_settings_activity.xml b/src/main/res/layout/filter_settings_activity.xml index abacfe9ca..f272b42d2 100644 --- a/src/main/res/layout/filter_settings_activity.xml +++ b/src/main/res/layout/filter_settings_activity.xml @@ -7,46 +7,41 @@ - + - + android:padding="16dp"> - - - + android:layout_alignParentTop="true" + android:text="@string/name" /> - - - - + + + diff --git a/src/main/res/layout/task_list_body_empty.xml b/src/main/res/layout/task_list_body_empty.xml index 34a5e5368..d8802c1c2 100644 --- a/src/main/res/layout/task_list_body_empty.xml +++ b/src/main/res/layout/task_list_body_empty.xml @@ -1,9 +1,11 @@ + android:elevation="@dimen/elevation_task_list" + tools:ignore="UnusedAttribute"> + android:elevation="@dimen/elevation_task_list" + tools:ignore="UnusedAttribute"> + android:elevation="@dimen/elevation_task_list" + tools:ignore="UnusedAttribute"> + app:theme="?attr/overlay_theme" + tools:ignore="UnusedAttribute" /> diff --git a/src/main/res/values/theme.xml b/src/main/res/values/theme.xml index 2fd7a01fa..98c5608d8 100644 --- a/src/main/res/values/theme.xml +++ b/src/main/res/values/theme.xml @@ -2,7 +2,7 @@ diff --git a/src/main/res/xml/scrollable_widget_provider_info.xml b/src/main/res/xml/scrollable_widget_provider_info.xml index f79781f64..5c9c7392b 100644 --- a/src/main/res/xml/scrollable_widget_provider_info.xml +++ b/src/main/res/xml/scrollable_widget_provider_info.xml @@ -6,6 +6,7 @@ --> + android:resizeMode="horizontal|vertical" + tools:ignore="UnusedAttribute" />