Remove setTaskAdapter overrides

app/src/main/java/com/todoroo/astrid/activity/TaskListFragment.java

@@ -35,7 +35,6 @@ import butterknife.BindView;
 import butterknife.ButterKnife;
 import butterknife.OnClick;
 import com.google.android.material.snackbar.Snackbar;
-import com.todoroo.andlib.data.Property;
 import com.todoroo.andlib.sql.Criterion;
 import com.todoroo.andlib.sql.QueryTemplate;
 import com.todoroo.astrid.adapter.TaskAdapter;
@@ -503,7 +502,7 @@ public class TaskListFragment extends InjectingFragment
   }
 
   /** Fill in the Task List with current items */
-  protected void setTaskAdapter() {
+  private void setTaskAdapter() {
     if (filter == null) {
       return;
     }

app/src/main/java/com/todoroo/astrid/gtasks/GtasksSubtaskListFragment.java

@@ -44,15 +44,9 @@ public class GtasksSubtaskListFragment extends GtasksListFragment {
   }
 
   @Override
-  public void setTaskAdapter() {
+  protected TaskAdapter createTaskAdapter() {
     helper.setList(list);
     helper.beforeSetUpTaskList(filter);
-
-    super.setTaskAdapter();
-  }
-
-  @Override
-  protected TaskAdapter createTaskAdapter() {
     return helper.createTaskAdapter();
   }
 

app/src/main/java/com/todoroo/astrid/subtasks/SubtasksListFragment.java

@@ -48,14 +48,6 @@ public class SubtasksListFragment extends TaskListFragment {
     helper.setTaskListFragment(this);
   }
 
-  @Override
-  public void setTaskAdapter() {
-    helper.setList(initializeTaskListMetadata());
-    helper.beforeSetUpTaskList(filter);
-
-    super.setTaskAdapter();
-  }
-
   private TaskListMetadata initializeTaskListMetadata() {
     String filterId = null;
     String prefId = null;
@@ -86,6 +78,8 @@ public class SubtasksListFragment extends TaskListFragment {
 
   @Override
   protected TaskAdapter createTaskAdapter() {
+    helper.setList(initializeTaskListMetadata());
+    helper.beforeSetUpTaskList(filter);
     return helper.createTaskAdapter();
   }
 

app/src/main/java/com/todoroo/astrid/subtasks/SubtasksTagListFragment.java

@@ -38,7 +38,7 @@ public class SubtasksTagListFragment extends TagListFragment {
   }
 
   @Override
-  public void setTaskAdapter() {
+  protected TaskAdapter createTaskAdapter() {
     String tdId = tagData.getRemoteId();
     TaskListMetadata taskListMetadata =
         taskListMetadataDao.fetchByTagOrFilter(tagData.getRemoteId());
@@ -49,12 +49,6 @@ public class SubtasksTagListFragment extends TagListFragment {
     }
     helper.setList(taskListMetadata);
     helper.beforeSetUpTaskList(filter);
-
-    super.setTaskAdapter();
-  }
-
-  @Override
-  protected TaskAdapter createTaskAdapter() {
     return helper.createTaskAdapter();
   }