From a86ba9d4e429e861f3fd072e085311ec3630e250 Mon Sep 17 00:00:00 2001 From: Alex Baker Date: Fri, 19 Jun 2015 11:24:24 -0500 Subject: [PATCH] Use trash action for delete --- .../astrid/actfm/TagSettingsActivity.java | 39 +++----- .../java/com/todoroo/astrid/api/Addon.java | 94 ------------------ .../drawable-hdpi/ic_delete_white_24dp.png | Bin 0 -> 161 bytes .../drawable-xhdpi/ic_delete_white_24dp.png | Bin 0 -> 151 bytes .../drawable-xxhdpi/ic_delete_white_24dp.png | Bin 0 -> 194 bytes .../res/drawable/ic_delete_white_24dp.png | Bin 0 -> 115 bytes src/main/res/layout/tag_settings_activity.xml | 21 ---- src/main/res/menu/tag_settings_activity.xml | 10 +- src/main/res/values/attrs.xml | 1 + src/main/res/values/styles.xml | 1 + 10 files changed, 26 insertions(+), 140 deletions(-) delete mode 100644 src/main/java/com/todoroo/astrid/api/Addon.java create mode 100644 src/main/res/drawable-hdpi/ic_delete_white_24dp.png create mode 100644 src/main/res/drawable-xhdpi/ic_delete_white_24dp.png create mode 100644 src/main/res/drawable-xxhdpi/ic_delete_white_24dp.png create mode 100644 src/main/res/drawable/ic_delete_white_24dp.png diff --git a/src/main/java/com/todoroo/astrid/actfm/TagSettingsActivity.java b/src/main/java/com/todoroo/astrid/actfm/TagSettingsActivity.java index f854de1b4..5441befd6 100644 --- a/src/main/java/com/todoroo/astrid/actfm/TagSettingsActivity.java +++ b/src/main/java/com/todoroo/astrid/actfm/TagSettingsActivity.java @@ -14,18 +14,14 @@ import android.support.v7.app.AlertDialog; import android.support.v7.widget.Toolbar; import android.view.Menu; import android.view.MenuItem; -import android.view.View; import android.view.inputmethod.InputMethodManager; import android.widget.EditText; -import android.widget.LinearLayout; import com.todoroo.andlib.sql.Criterion; import com.todoroo.andlib.utility.AndroidUtilities; -import com.todoroo.andlib.utility.DateUtilities; import com.todoroo.astrid.api.AstridApiConstants; import com.todoroo.astrid.dao.MetadataDao; import com.todoroo.astrid.dao.TagDataDao; -import com.todoroo.astrid.data.Metadata; import com.todoroo.astrid.data.TagData; import com.todoroo.astrid.helper.UUIDHelper; import com.todoroo.astrid.tags.TagFilterExposer; @@ -40,7 +36,6 @@ import javax.inject.Inject; import butterknife.ButterKnife; import butterknife.InjectView; -import butterknife.OnClick; import static android.text.TextUtils.isEmpty; @@ -59,7 +54,6 @@ public class TagSettingsActivity extends InjectingAppCompatActivity { @InjectView(R.id.tag_name) EditText tagName; @InjectView(R.id.toolbar) Toolbar toolbar; - @InjectView(R.id.delete_container) LinearLayout deleteContainer; @Override protected void onCreate(Bundle savedInstanceState) { @@ -68,22 +62,22 @@ public class TagSettingsActivity extends InjectingAppCompatActivity { setContentView(R.layout.tag_settings_activity); ButterKnife.inject(this); - setSupportActionBar(toolbar); - ActionBar supportActionBar = getSupportActionBar(); - if (supportActionBar != null) { - supportActionBar.setDisplayHomeAsUpEnabled(true); - supportActionBar.setHomeAsUpIndicator(R.drawable.ic_close_white_24dp); - } - tagData = getIntent().getParcelableExtra(TagViewFragment.EXTRA_TAG_DATA); if (tagData == null) { isNewTag = true; tagData = new TagData(); tagData.setUUID(UUIDHelper.newUUID()); - deleteContainer.setVisibility(View.GONE); } - refreshSettingsPage(); + setSupportActionBar(toolbar); + ActionBar supportActionBar = getSupportActionBar(); + if (supportActionBar != null) { + supportActionBar.setDisplayHomeAsUpEnabled(true); + supportActionBar.setHomeAsUpIndicator(R.drawable.ic_close_white_24dp); + supportActionBar.setTitle(isNewTag ? getString(R.string.new_tag) : tagData.getName()); + } + + tagName.setText(tagData.getName()); String autopopulateName = getIntent().getStringExtra(TOKEN_AUTOPOPULATE_NAME); if (!isEmpty(autopopulateName)) { @@ -135,16 +129,12 @@ public class TagSettingsActivity extends InjectingAppCompatActivity { AndroidUtilities.callOverridePendingTransition(this, R.anim.slide_right_in, R.anim.slide_right_out); } - private void refreshSettingsPage() { - tagName.setText(tagData.getName()); - getSupportActionBar().setTitle(isNewTag - ? getString(R.string.new_tag) - : tagData.getName()); - } - @Override public boolean onCreateOptionsMenu(Menu menu) { getMenuInflater().inflate(R.menu.tag_settings_activity, menu); + if (isNewTag) { + menu.findItem(R.id.delete).setVisible(false); + } return super.onCreateOptionsMenu(menu); } @@ -162,11 +152,14 @@ public class TagSettingsActivity extends InjectingAppCompatActivity { case R.id.menu_save: save(); break; + case R.id.delete: + deleteTag(); + break; } return super.onOptionsItemSelected(item); } - @OnClick(R.id.delete) void deleteTag() { + private void deleteTag() { new AlertDialog.Builder(this, R.style.Tasks_Dialog) .setMessage(getString(R.string.delete_tag_confirmation, tagData.getName())) .setPositiveButton(R.string.delete, new DialogInterface.OnClickListener() { diff --git a/src/main/java/com/todoroo/astrid/api/Addon.java b/src/main/java/com/todoroo/astrid/api/Addon.java deleted file mode 100644 index 12b3e17ac..000000000 --- a/src/main/java/com/todoroo/astrid/api/Addon.java +++ /dev/null @@ -1,94 +0,0 @@ -/** - * Copyright (c) 2012 Todoroo Inc - * - * See the file "LICENSE" for the full license governing this code. - */ -package com.todoroo.astrid.api; - -import android.os.Parcel; -import android.os.Parcelable; - -/** - * Represents an add-onn for Astrid. Users can enable or disable add-ons, - * which affect all other extension points that share the same identifier. - * - * @author Tim Su - * - */ -public class Addon implements Parcelable { - - /** - * Add-on Identifier - */ - public String addon = null; - - /** - * Plug-in Title - */ - public String title = null; - - /** - * Plug-in Author - */ - public String author = null; - - /** - * Plug-in Description - */ - public String description = null; - - /** - * Convenience constructor to generate a plug-in object - */ - public Addon(String addon, String title, String author, String description) { - this.addon = addon; - this.title = title; - this.author = author; - this.description = description; - } - - // --- parcelable helpers - - - /** - * {@inheritDoc} - */ - @Override - public int describeContents() { - return 0; - } - - /** - * {@inheritDoc} - */ - @Override - public void writeToParcel(Parcel dest, int flags) { - dest.writeString(addon); - dest.writeString(title); - dest.writeString(author); - dest.writeString(description); - } - - /** - * Parcelable creator - */ - public static final Parcelable.Creator CREATOR = new Parcelable.Creator() { - /** - * {@inheritDoc} - */ - @Override - public Addon createFromParcel(Parcel source) { - return new Addon(source.readString(), source.readString(), - source.readString(), source.readString()); - } - - /** - * {@inheritDoc} - */ - @Override - public Addon[] newArray(int size) { - return new Addon[size]; - } - }; - -} diff --git a/src/main/res/drawable-hdpi/ic_delete_white_24dp.png b/src/main/res/drawable-hdpi/ic_delete_white_24dp.png new file mode 100644 index 0000000000000000000000000000000000000000..4a9f769475ae98c44086a5498057c799cdc1eb2e GIT binary patch literal 161 zcmeAS@N?(olHy`uVBq!ia0vp^Dj>|k0wldT1B8K8hNp{Th{y5d1PNA=hW|4Ewf~tb z9PIip^F(s-FKmRW+J}dc&f#K)gg?ihMxz_^iWbkzL Kb6Mw<&;$SheLUU( literal 0 HcmV?d00001 diff --git a/src/main/res/drawable-xhdpi/ic_delete_white_24dp.png b/src/main/res/drawable-xhdpi/ic_delete_white_24dp.png new file mode 100644 index 0000000000000000000000000000000000000000..388b5b060af924493b057a63216fe7db75d4435a GIT binary patch literal 151 zcmeAS@N?(olHy`uVBq!ia0vp^1|ZDA0wn)(8}b0DI8PVHkch)?FC64-Fko=L=%?Iw zv$u;+&1tXu2b~*Nwk`N$?;xkbvPe<$)w&zy|9BUkVz|Zlf5mTGpk6SDXXMMa|9v2f u@g#fN+oPXnt4Z(ZaQ*pHX6dTRMUVWXo;a(XeY#{ZNU5i*pUXO@geCyi%r-Ls literal 0 HcmV?d00001 diff --git a/src/main/res/drawable-xxhdpi/ic_delete_white_24dp.png b/src/main/res/drawable-xxhdpi/ic_delete_white_24dp.png new file mode 100644 index 0000000000000000000000000000000000000000..3fcdfdb55ebcba8d2fff8be03ea3518c137e3464 GIT binary patch literal 194 zcmeAS@N?(olHy`uVBq!ia0vp^9w5xY0wn)GsXhawIz3$+Lo)8Yy>yn>!GXc$q3uOx zabB)cz0QC}ts}W53MuVBD%UsZPv&gw=#W`?Y0ciWQ2$4FyseJx>{`Oj#KIv^yWsd< zb^!&41_nkD7m4wnX|34#N6cTv0=_gxaj*E+Smb+hj$`D9r9sI`%Q@~%Ssl3i>7S{h gq0!eBm41aw^UfFNx4vv@4|EiRr>mdKI;Vst0RDqR&j0`b literal 0 HcmV?d00001 diff --git a/src/main/res/drawable/ic_delete_white_24dp.png b/src/main/res/drawable/ic_delete_white_24dp.png new file mode 100644 index 0000000000000000000000000000000000000000..e2f5f35558db0965392b15b5d8950261a8c92aab GIT binary patch literal 115 zcmeAS@N?(olHy`uVBq!ia0vp^5+KaM0wlfaz7_*1D^C~45R22v2@-!E>_7CM{eR+v zgY~R6ULP4=Whfl~yJVLAs>BdxJ>K;jR@FB~H~;@Xea5N(zxh7d@H058PdfN2J>(P6 O6b4UMKbLh*2~7YiM=IO^ literal 0 HcmV?d00001 diff --git a/src/main/res/layout/tag_settings_activity.xml b/src/main/res/layout/tag_settings_activity.xml index b1527fcea..27e9694cd 100644 --- a/src/main/res/layout/tag_settings_activity.xml +++ b/src/main/res/layout/tag_settings_activity.xml @@ -47,27 +47,6 @@ android:textSize="15sp" /> - - - - - -