Fixed a bug in DraggableListView that would fire click events for cancelled motion events

13 years ago · a0c2d7b7f5
parent 8d2c19c859
commit a0c2d7b7f5
1 changed files with 2 additions and 2 deletions
--- a/astrid/src/com/todoroo/astrid/ui/DraggableListView.java
+++ b/astrid/src/com/todoroo/astrid/ui/DraggableListView.java
@ -254,7 +254,8 @@ public class DraggableListView extends ListView {
                if (dragThread != null && mClickListener != null) {
                    dragThread.interrupt();
                    dragThread = null;
-                    mClickListener.onClick(viewAtPosition());
+                    if (action == MotionEvent.ACTION_UP)
+                        mClickListener.onClick(viewAtPosition());
                }

                else if (mSwipeListener != null &&
@ -482,7 +483,6 @@ public class DraggableListView extends ListView {
        unExpandViews(false);

        if (mDragView != null) {
-            System.err.println("removing view");
            WindowManager wm = (WindowManager) getContext().getSystemService(
                    Context.WINDOW_SERVICE);
            wm.removeView(mDragView);