From 9d23ba2c34544736e9557ee0ddd9d15a7516906c Mon Sep 17 00:00:00 2001 From: Sam Bosley Date: Tue, 6 Mar 2012 14:22:36 -0800 Subject: [PATCH] Handled exceptions with crittercism --- .../com/todoroo/astrid/actfm/sync/ActFmSyncService.java | 6 ++++++ .../com/todoroo/astrid/actfm/sync/ActFmSyncV2Provider.java | 3 +++ .../com/todoroo/astrid/gtasks/sync/GtasksSyncService.java | 4 +++- .../todoroo/astrid/gtasks/sync/GtasksSyncV2Provider.java | 3 +++ 4 files changed, 15 insertions(+), 1 deletion(-) diff --git a/astrid/plugin-src/com/todoroo/astrid/actfm/sync/ActFmSyncService.java b/astrid/plugin-src/com/todoroo/astrid/actfm/sync/ActFmSyncService.java index 7d9dc4549..4a7a93eb4 100644 --- a/astrid/plugin-src/com/todoroo/astrid/actfm/sync/ActFmSyncService.java +++ b/astrid/plugin-src/com/todoroo/astrid/actfm/sync/ActFmSyncService.java @@ -28,6 +28,7 @@ import android.text.TextUtils; import android.util.Log; import android.widget.Toast; +import com.crittercism.app.Crittercism; import com.timsu.astrid.R; import com.todoroo.andlib.data.AbstractModel; import com.todoroo.andlib.data.DatabaseDao; @@ -427,9 +428,12 @@ public final class ActFmSyncService { JsonHelper.taskFromJson(result, task, metadata); } catch (JSONException e) { handleException("task-save-json", e); + Crittercism.logHandledException(e); } catch (IOException e) { if (notPermanentError(e)) addFailedPush(new FailedPush(PUSH_TYPE_TASK, task.getId())); + else + Crittercism.logHandledException(e); handleException("task-save-io", e); task.setValue(Task.LAST_SYNC, DateUtilities.now() + 1000L); } @@ -1090,8 +1094,10 @@ public final class ActFmSyncService { handler.handleException("io-exception-list-" + model, e); else handleException("io-exception-list-" + model, e); + Crittercism.logHandledException(e); } catch (JSONException e) { handleException("json: " + result.toString(), e); + Crittercism.logHandledException(e); } } }).start(); diff --git a/astrid/plugin-src/com/todoroo/astrid/actfm/sync/ActFmSyncV2Provider.java b/astrid/plugin-src/com/todoroo/astrid/actfm/sync/ActFmSyncV2Provider.java index 225a008d7..376aa916c 100644 --- a/astrid/plugin-src/com/todoroo/astrid/actfm/sync/ActFmSyncV2Provider.java +++ b/astrid/plugin-src/com/todoroo/astrid/actfm/sync/ActFmSyncV2Provider.java @@ -11,6 +11,7 @@ import java.util.concurrent.atomic.AtomicInteger; import org.json.JSONException; +import com.crittercism.app.Crittercism; import com.timsu.astrid.C2DMReceiver; import com.timsu.astrid.R; import com.todoroo.andlib.data.TodorooCursor; @@ -132,8 +133,10 @@ public class ActFmSyncV2Provider extends SyncV2Provider { Preferences.setInt(LAST_TAG_FETCH_TIME, time); } catch (JSONException e) { handler.handleException("actfm-sync", e); //$NON-NLS-1$ + Crittercism.logHandledException(e); } catch (IOException e) { handler.handleException("actfm-sync", e); //$NON-NLS-1$ + Crittercism.logHandledException(e); } finally { callback.incrementProgress(20); if(finisher.decrementAndGet() == 0) { diff --git a/astrid/plugin-src/com/todoroo/astrid/gtasks/sync/GtasksSyncService.java b/astrid/plugin-src/com/todoroo/astrid/gtasks/sync/GtasksSyncService.java index e06ef87fb..124597a0a 100644 --- a/astrid/plugin-src/com/todoroo/astrid/gtasks/sync/GtasksSyncService.java +++ b/astrid/plugin-src/com/todoroo/astrid/gtasks/sync/GtasksSyncService.java @@ -7,6 +7,7 @@ import android.content.ContentValues; import android.text.TextUtils; import android.util.Log; +import com.crittercism.app.Crittercism; import com.todoroo.andlib.data.DatabaseDao.ModelUpdateListener; import com.todoroo.andlib.data.Property; import com.todoroo.andlib.service.Autowired; @@ -87,7 +88,8 @@ public final class GtasksSyncService { pushMetadataOnSave(move.metadata, invoker); } } - } catch (IOException e){ + } catch (IOException e) { + Crittercism.logHandledException(e); Log.w("gtasks-sync-error", "Sync on save failed", e); } } diff --git a/astrid/plugin-src/com/todoroo/astrid/gtasks/sync/GtasksSyncV2Provider.java b/astrid/plugin-src/com/todoroo/astrid/gtasks/sync/GtasksSyncV2Provider.java index 42aed8d84..cd93d3da1 100644 --- a/astrid/plugin-src/com/todoroo/astrid/gtasks/sync/GtasksSyncV2Provider.java +++ b/astrid/plugin-src/com/todoroo/astrid/gtasks/sync/GtasksSyncV2Provider.java @@ -11,6 +11,7 @@ import org.json.JSONException; import android.text.TextUtils; +import com.crittercism.app.Crittercism; import com.google.api.services.tasks.model.Tasks; import com.timsu.astrid.R; import com.todoroo.andlib.data.AbstractModel; @@ -112,6 +113,7 @@ public class GtasksSyncV2Provider extends SyncV2Provider { gtasksListService.updateLists(invoker.allGtaskLists()); } catch (IOException e) { handler.handleException("gtasks-sync=io", e); //$NON-NLS-1$ + Crittercism.logHandledException(e); } StoreObject[] lists = gtasksListService.getLists(); @@ -153,6 +155,7 @@ public class GtasksSyncV2Provider extends SyncV2Provider { gtasksSyncService.pushTaskOnSave(task, task.getMergedValues(), invoker, false); } catch (IOException e) { handler.handleException("gtasks-sync-io", e); //$NON-NLS-1$ + Crittercism.logHandledException(e); } finally { callback.incrementProgress(10); }