From 9746aa5fc0328cb69c5786901dfc03a8e00f9c55 Mon Sep 17 00:00:00 2001 From: Alex Baker Date: Mon, 23 Dec 2019 11:54:06 -0600 Subject: [PATCH] Don't schedule refresh after completion --- .../main/java/org/tasks/scheduling/RefreshScheduler.java | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/tasks/scheduling/RefreshScheduler.java b/app/src/main/java/org/tasks/scheduling/RefreshScheduler.java index bf3d5b5b2..38a635a96 100644 --- a/app/src/main/java/org/tasks/scheduling/RefreshScheduler.java +++ b/app/src/main/java/org/tasks/scheduling/RefreshScheduler.java @@ -10,18 +10,22 @@ import java.util.List; import java.util.SortedSet; import java.util.TreeSet; import javax.inject.Inject; +import org.tasks.R; import org.tasks.injection.ApplicationScope; import org.tasks.jobs.WorkManager; +import org.tasks.preferences.Preferences; @ApplicationScope public class RefreshScheduler { + private final Preferences preferences; private final WorkManager workManager; private final TaskDao taskDao; private final SortedSet jobs = new TreeSet<>(); @Inject - public RefreshScheduler(WorkManager workManager, TaskDao taskDao) { + RefreshScheduler(Preferences preferences, WorkManager workManager, TaskDao taskDao) { + this.preferences = preferences; this.workManager = workManager; this.taskDao = taskDao; } @@ -33,7 +37,8 @@ public class RefreshScheduler { } public synchronized void scheduleRefresh(Task task) { - if (task.isCompleted()) { + if (task.isCompleted() + && preferences.getBoolean(R.string.p_temporarily_show_completed_tasks, false)) { scheduleRefresh(task.getCompletionDate() + ONE_MINUTE); } else if (task.hasDueDate()) { scheduleRefresh(task.getDueDate());