From 95fe64fb65785900641dc9a3a3e5565dda384a75 Mon Sep 17 00:00:00 2001
From: Alex Baker <alex@tasks.org>
Date: Wed, 23 Sep 2020 13:18:53 -0500
Subject: [PATCH] Update uses-permission notes

---
 app/src/main/AndroidManifest.xml | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 9454a2bea..7441f9e0a 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -7,12 +7,15 @@
 
   <!-- ================================================== Used Permissions = -->
 
-  <!-- ********************************* -->
-  <!-- maps and location based reminders -->
-  <!-- ********************************* -->
+  <!-- ********************* -->
+  <!-- maps and place search -->
+  <!-- ********************* -->
   <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"/>
-  <uses-permission android:name="android.permission.ACCESS_BACKGROUND_LOCATION" />
 
+  <!-- ************************ -->
+  <!-- location based reminders -->
+  <!-- ************************ -->
+  <uses-permission android:name="android.permission.ACCESS_BACKGROUND_LOCATION" />
   <uses-feature
     android:name="android.hardware.location"
     android:required="false"/>
@@ -38,7 +41,8 @@
   <uses-permission android:name="com.android.launcher.permission.INSTALL_SHORTCUT"/>
 
   <!-- **************************************** -->
-  <!-- write backups and attachments to storage -->
+  <!-- this permission is no longer used, but   -->
+  <!-- remains for legacy compatibility reasons -->
   <!-- **************************************** -->
   <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
 
@@ -60,9 +64,9 @@
   <!-- *********************************** -->
   <uses-permission android:name="android.permission.WAKE_LOCK"/>
 
-  <!-- ****************************************************** -->
-  <!-- caldav sync, google task sync, and google drive upload -->
-  <!-- ****************************************************** -->
+  <!-- ******************************************************* -->
+  <!-- google task/etesync/caldav sync and google drive upload -->
+  <!-- ******************************************************* -->
   <uses-permission android:name="android.permission.INTERNET"/>
   <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
 
@@ -72,7 +76,6 @@
   <uses-permission android:name="com.google.android.providers.gsf.permission.READ_GSERVICES"/>
   <uses-permission android:name="com.google.android.googleapps.permission.GOOGLE_AUTH"/>
   <uses-permission android:name="android.permission.GET_ACCOUNTS" android:maxSdkVersion="25"/>
-  <uses-permission android:name="android.permission.USE_CREDENTIALS" android:maxSdkVersion="22" />
 
   <!-- ***************************** -->
   <!-- Exclude OpenTasks permissions -->