diff --git a/app/src/main/java/com/todoroo/astrid/core/SortHelper.java b/app/src/main/java/com/todoroo/astrid/core/SortHelper.java index 9c73205b6..5afe3c72f 100644 --- a/app/src/main/java/com/todoroo/astrid/core/SortHelper.java +++ b/app/src/main/java/com/todoroo/astrid/core/SortHelper.java @@ -59,14 +59,14 @@ public class SortHelper { if (preferences.getBoolean(R.string.p_show_completed_tasks, false)) { adjustedSql = adjustedSql.replace(Task.COMPLETION_DATE.eq(0).toString(), Criterion.all.toString()); - } else { + } else if (preferences.getBoolean(R.string.p_temporarily_show_completed_tasks, false)) { adjustedSql = - adjustedSql.replace( - Task.COMPLETION_DATE.eq(0).toString(), - Criterion.or( - Task.COMPLETION_DATE.lte(0), - Task.COMPLETION_DATE.gt(DateUtilities.now() - 60000)) - .toString()); + adjustedSql.replace( + Task.COMPLETION_DATE.eq(0).toString(), + Criterion.or( + Task.COMPLETION_DATE.lte(0), + Task.COMPLETION_DATE.gt(DateUtilities.now() - 60000)) + .toString()); } if (preferences.getBoolean(R.string.p_show_hidden_tasks, false)) { adjustedSql = adjustedSql.replace(isVisible().toString(), Criterion.all.toString()); diff --git a/app/src/main/res/values/keys.xml b/app/src/main/res/values/keys.xml index 81dcc6027..ee8ad92a7 100644 --- a/app/src/main/res/values/keys.xml +++ b/app/src/main/res/values/keys.xml @@ -188,6 +188,7 @@ TEA_ctrl_gtask show_hidden_tasks show_completed_tasks + temporarily_show_completed_tasks reverse_sort manual_sort diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 86a243a19..c5370f061 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -94,6 +94,9 @@ File %1$s contained %2$s.\n\n Calendar event time End calendar events at due time Start calendar events at due time + Temporarily show tasks upon completion + Tasks will remain temporarily visible in the list after completion + Tasks will immediately disappear from the list after completion Manage old tasks Purge deleted tasks Do you really want to purge all your deleted tasks?\n\nThese tasks will be gone forever! diff --git a/app/src/main/res/xml/preferences_misc.xml b/app/src/main/res/xml/preferences_misc.xml index 22a40b728..4faf4e129 100644 --- a/app/src/main/res/xml/preferences_misc.xml +++ b/app/src/main/res/xml/preferences_misc.xml @@ -25,4 +25,11 @@ android:summaryOn="@string/EPr_cal_start_at_due_time" android:title="@string/EPr_cal_end_or_start_at_due_time"/> + +