From 89ebfd88c0cb4005ae201da9145643081b5c6004 Mon Sep 17 00:00:00 2001 From: Alex Baker Date: Thu, 4 Jun 2020 16:03:26 -0500 Subject: [PATCH] Configure visibility for each chip type --- .../com/todoroo/astrid/service/Upgrader.kt | 5 +++ .../java/org/tasks/preferences/Preferences.kt | 16 +++++++ .../main/java/org/tasks/ui/ChipProvider.kt | 44 +++++++++---------- app/src/main/res/values-bg-rBG/strings.xml | 1 - app/src/main/res/values-de/strings.xml | 1 - app/src/main/res/values-es/strings.xml | 1 - app/src/main/res/values-eu/strings.xml | 1 - app/src/main/res/values-fi/strings.xml | 1 - app/src/main/res/values-fr/strings.xml | 1 - app/src/main/res/values-hu/strings.xml | 1 - app/src/main/res/values-id/strings.xml | 1 - app/src/main/res/values-it/strings.xml | 1 - app/src/main/res/values-iw/strings.xml | 1 - app/src/main/res/values-ja/strings.xml | 1 - app/src/main/res/values-ko/strings.xml | 1 - app/src/main/res/values-lt/strings.xml | 1 - app/src/main/res/values-nb/strings.xml | 1 - app/src/main/res/values-nl/strings.xml | 1 - app/src/main/res/values-pl/strings.xml | 1 - app/src/main/res/values-pt-rBR/strings.xml | 1 - app/src/main/res/values-ru/strings.xml | 1 - app/src/main/res/values-sk/strings.xml | 1 - app/src/main/res/values-sv/strings.xml | 1 - app/src/main/res/values-tr/strings.xml | 1 - app/src/main/res/values-uk/strings.xml | 1 - app/src/main/res/values-zh-rCN/strings.xml | 1 - app/src/main/res/values/keys.xml | 5 ++- app/src/main/res/values/strings.xml | 1 - .../res/xml/preferences_look_and_feel.xml | 25 ++++++++--- 29 files changed, 66 insertions(+), 53 deletions(-) diff --git a/app/src/main/java/com/todoroo/astrid/service/Upgrader.kt b/app/src/main/java/com/todoroo/astrid/service/Upgrader.kt index e4320386c..b94bd30c7 100644 --- a/app/src/main/java/com/todoroo/astrid/service/Upgrader.kt +++ b/app/src/main/java/com/todoroo/astrid/service/Upgrader.kt @@ -60,6 +60,11 @@ class Upgrader @Inject constructor( run(from, V8_10) { migrateWidgets() } run(from, V9_3) { applyCaldavOrder() } run(from, V9_6) { + val chips = preferences.getBoolean("show_list_indicators", true) + preferences.showSubtaskChip = chips + preferences.showPlaceChip = chips + preferences.showListChip = chips + preferences.showTagChip = chips preferences.setBoolean(R.string.p_astrid_sort_enabled, true) taskMover.migrateLocalTasks() } diff --git a/app/src/main/java/org/tasks/preferences/Preferences.kt b/app/src/main/java/org/tasks/preferences/Preferences.kt index b4d1b9a14..5a289197c 100644 --- a/app/src/main/java/org/tasks/preferences/Preferences.kt +++ b/app/src/main/java/org/tasks/preferences/Preferences.kt @@ -453,6 +453,22 @@ class Preferences @JvmOverloads constructor(private val context: Context, name: val themeBase: Int get() = getInt(R.string.p_theme, ThemeBase.DEFAULT_BASE_THEME) + var showSubtaskChip: Boolean + get() = getBoolean(R.string.p_subtask_chips, true) + set(value) = setBoolean(R.string.p_subtask_chips, value) + + var showPlaceChip: Boolean + get() = getBoolean(R.string.p_place_chips, true) + set(value) = setBoolean(R.string.p_place_chips, value) + + var showListChip: Boolean + get() = getBoolean(R.string.p_list_chips, true) + set(value) = setBoolean(R.string.p_list_chips, value) + + var showTagChip: Boolean + get() = getBoolean(R.string.p_tag_chips, true) + set(value) = setBoolean(R.string.p_tag_chips, value) + fun alreadyNotified(account: String?, scope: String?): Boolean { return getBoolean(context.getString(R.string.p_notified_oauth_error, account, scope), false) } diff --git a/app/src/main/java/org/tasks/ui/ChipProvider.kt b/app/src/main/java/org/tasks/ui/ChipProvider.kt index 7688c6938..ab7bc4952 100644 --- a/app/src/main/java/org/tasks/ui/ChipProvider.kt +++ b/app/src/main/java/org/tasks/ui/ChipProvider.kt @@ -63,33 +63,31 @@ class ChipProvider @Inject constructor( fun getChips(filter: Filter?, isSubtask: Boolean, task: TaskContainer): List { AndroidUtilities.assertMainThread() val chips = ArrayList() - if (task.hasChildren()) { + if (task.hasChildren() && preferences.showSubtaskChip) { chips.add(newSubtaskChip(task, !showText)) } - if (preferences.getBoolean(R.string.p_show_list_indicators, true)) { - if (task.hasLocation() && filter !is PlaceFilter) { - val location = task.getLocation() - newChip(PlaceFilter(location.place), R.drawable.ic_outline_place_24px)?.let(chips::add) - } - if (!isSubtask) { - if (!isNullOrEmpty(task.googleTaskList) && filter !is GtasksFilter) { - newChip(lists.getGoogleTaskList(task.googleTaskList), R.drawable.ic_list_24px) - ?.let(chips::add) - } else if (!isNullOrEmpty(task.caldav) && filter !is CaldavFilter) { - newChip(lists.getCaldavList(task.caldav), R.drawable.ic_list_24px)?.let(chips::add) - } + if (task.hasLocation() && filter !is PlaceFilter && preferences.showPlaceChip) { + val location = task.getLocation() + newChip(PlaceFilter(location.place), R.drawable.ic_outline_place_24px)?.let(chips::add) + } + if (!isSubtask && preferences.showListChip) { + if (!isNullOrEmpty(task.googleTaskList) && filter !is GtasksFilter) { + newChip(lists.getGoogleTaskList(task.googleTaskList), R.drawable.ic_list_24px) + ?.let(chips::add) + } else if (!isNullOrEmpty(task.caldav) && filter !is CaldavFilter) { + newChip(lists.getCaldavList(task.caldav), R.drawable.ic_list_24px)?.let(chips::add) } - val tagString = task.tagsString - if (!isNullOrEmpty(tagString)) { - val tags = tagString.split(",").toHashSet() - if (filter is TagFilter) { - tags.remove(filter.uuid) - } - tags.mapNotNull(lists::getTag) - .sortedBy(TagFilter::listingTitle) - .map { newChip(it, R.drawable.ic_outline_label_24px)!! } - .let(chips::addAll) + } + val tagString = task.tagsString + if (!isNullOrEmpty(tagString) && preferences.showTagChip) { + val tags = tagString.split(",").toHashSet() + if (filter is TagFilter) { + tags.remove(filter.uuid) } + tags.mapNotNull(lists::getTag) + .sortedBy(TagFilter::listingTitle) + .map { newChip(it, R.drawable.ic_outline_label_24px)!! } + .let(chips::addAll) } return chips } diff --git a/app/src/main/res/values-bg-rBG/strings.xml b/app/src/main/res/values-bg-rBG/strings.xml index 2703b52bf..fb07fcb05 100644 --- a/app/src/main/res/values-bg-rBG/strings.xml +++ b/app/src/main/res/values-bg-rBG/strings.xml @@ -449,7 +449,6 @@ Покажи пълното описание Покажи линкове Добавете връзки към уебсайтове, адреси и телефонни номера - Показване на индикатори в списъци Напомни при пристигане Напомни при заминаване Посетете уебсайта diff --git a/app/src/main/res/values-de/strings.xml b/app/src/main/res/values-de/strings.xml index f54112070..5be356217 100644 --- a/app/src/main/res/values-de/strings.xml +++ b/app/src/main/res/values-de/strings.xml @@ -441,7 +441,6 @@ Gesamte Beschreibung anzeigen Links anzeigen Links zu Websites, Adressen und Telefonnummern beifügen - Schlagwörter und Listen anzeigen Bei Ankunft erinnern Bei Abreise erinnern Website öffnen diff --git a/app/src/main/res/values-es/strings.xml b/app/src/main/res/values-es/strings.xml index e937acaeb..83659c430 100644 --- a/app/src/main/res/values-es/strings.xml +++ b/app/src/main/res/values-es/strings.xml @@ -449,7 +449,6 @@ Mostrar descripción completa Mostrar enlaces Añade enlaces a sitios web, direcciones y número de teléfono - Mostrar fichas de lista Recordar a la llegada Recordar a la salida Visitar página web diff --git a/app/src/main/res/values-eu/strings.xml b/app/src/main/res/values-eu/strings.xml index ae15d759a..098978366 100644 --- a/app/src/main/res/values-eu/strings.xml +++ b/app/src/main/res/values-eu/strings.xml @@ -455,7 +455,6 @@ Erakutsi deskripzio osoa Erakutsi estekak Gehitu web-estekak, helbideak, eta telefono zenbakiak - Erakutsi zerrenda-buletak Gogorarazi heltzerakoan Gogorarazi ateratzerakoan Bisitatu webgunea diff --git a/app/src/main/res/values-fi/strings.xml b/app/src/main/res/values-fi/strings.xml index 8827c0764..9926b9f35 100644 --- a/app/src/main/res/values-fi/strings.xml +++ b/app/src/main/res/values-fi/strings.xml @@ -404,7 +404,6 @@ Lisää paikka Piilota käyttämättömät paikat Piilota käyttämättömät tunnistimet - Näytä lisätietolaput listassa Uudelleenalustus Kalenterimerkintä luotu %s varten Päivämäärän ja kellonajan valitsimet sulkeutuvat itsestään valittuasi ajan diff --git a/app/src/main/res/values-fr/strings.xml b/app/src/main/res/values-fr/strings.xml index c8c6c57c2..d666ba23e 100644 --- a/app/src/main/res/values-fr/strings.xml +++ b/app/src/main/res/values-fr/strings.xml @@ -431,7 +431,6 @@ Montrer la description complète Afficher les liens Ajouter des liens vers des sites Web, des adresses et des numéros de téléphone - Afficher la liste des puces Rappel à l\'arrivée Rappel au départ Visiter le site internet diff --git a/app/src/main/res/values-hu/strings.xml b/app/src/main/res/values-hu/strings.xml index 4a0fc75ba..0cfd8e1a7 100644 --- a/app/src/main/res/values-hu/strings.xml +++ b/app/src/main/res/values-hu/strings.xml @@ -450,7 +450,6 @@ Teljes leírás megjelenítése Linkek megjelenítése Weboldalakra, címekre és telefonszámokra mutató linkek hozzáadása - Listajelölők megjelenítése Induláskor emlékeztet Érkezéskor emlékeztet Weboldal megnyitása diff --git a/app/src/main/res/values-id/strings.xml b/app/src/main/res/values-id/strings.xml index 83cf6c4d6..2875784bc 100644 --- a/app/src/main/res/values-id/strings.xml +++ b/app/src/main/res/values-id/strings.xml @@ -385,7 +385,6 @@ Tampilkan keseluruhan deskripsi Tampilkan tautan Menambahkan tautan ke situs web, alamat, dan nomor telepon - Tampilkan indikator daftar Kunjungi situs web Pilih lokasi Pilih lokasi ini diff --git a/app/src/main/res/values-it/strings.xml b/app/src/main/res/values-it/strings.xml index f536ffc7f..a5b4280ab 100644 --- a/app/src/main/res/values-it/strings.xml +++ b/app/src/main/res/values-it/strings.xml @@ -446,7 +446,6 @@ Mostra la descrizione completa Mostra link Aggiungi link a siti web, indirizzi, numeri telefonici - Mostra lista chip Ricorda all\'arrivo Ricorda alla partenza Visita sito web diff --git a/app/src/main/res/values-iw/strings.xml b/app/src/main/res/values-iw/strings.xml index 00ef7015c..9ee627140 100644 --- a/app/src/main/res/values-iw/strings.xml +++ b/app/src/main/res/values-iw/strings.xml @@ -484,7 +484,6 @@ הצג תיאור מלא הצג קישורים הוסף קישורים לאתרים, כתובות, ומספרי טלפון - הצג שבבי רשימה הזכר ברגע ההגעה הזכר ברגע העזיבה מעבר לאתר האינטרנט diff --git a/app/src/main/res/values-ja/strings.xml b/app/src/main/res/values-ja/strings.xml index 11985ba8c..81bb3ec79 100644 --- a/app/src/main/res/values-ja/strings.xml +++ b/app/src/main/res/values-ja/strings.xml @@ -447,7 +447,6 @@ すべての説明を表示 リンクを表示 ウェブサイト、住所、電話番号へのリンクを追加 - リストチップを表示 到着時に通知する 出発時に通知する Webサイトを参照 diff --git a/app/src/main/res/values-ko/strings.xml b/app/src/main/res/values-ko/strings.xml index 139f6193b..c9e048e6f 100644 --- a/app/src/main/res/values-ko/strings.xml +++ b/app/src/main/res/values-ko/strings.xml @@ -448,7 +448,6 @@ 전체 설명 보기 링크 보기 웹사이트, 주소, 전화번호에 링크 걸기 - 칩 보기 도착 시 알림 출발 시 알림 %s 에 도착 diff --git a/app/src/main/res/values-lt/strings.xml b/app/src/main/res/values-lt/strings.xml index f4d62f064..bbe4893d9 100644 --- a/app/src/main/res/values-lt/strings.xml +++ b/app/src/main/res/values-lt/strings.xml @@ -446,7 +446,6 @@ Rodyti pilną aprašymą Rodyti nuorodas Pridėti nuorodas į puslapius, adresus ir telefono numerius - Rodyti sąrašą lustų Priminti atvykus Priminti išvykstant Aplankyti svetainę diff --git a/app/src/main/res/values-nb/strings.xml b/app/src/main/res/values-nb/strings.xml index bb494c242..50dab2f55 100644 --- a/app/src/main/res/values-nb/strings.xml +++ b/app/src/main/res/values-nb/strings.xml @@ -455,7 +455,6 @@ Vis full beskrivelse Vis lenker Legg til lenker til nettsider, adresser, og telefonnumre - Vis listeindikatorer Påminn ved ankomst Påminn ved avgang Besøk nettside diff --git a/app/src/main/res/values-nl/strings.xml b/app/src/main/res/values-nl/strings.xml index ee076fc2c..31c04d458 100644 --- a/app/src/main/res/values-nl/strings.xml +++ b/app/src/main/res/values-nl/strings.xml @@ -439,7 +439,6 @@ Toon volledige beschrijving Toon links Voeg links toe nar websites, adressen en telefoonnummers - Toon lijst-fiches Herinner bij aankomst Herinner bij vertrek Bezoek website diff --git a/app/src/main/res/values-pl/strings.xml b/app/src/main/res/values-pl/strings.xml index 3a200304d..09d5991cb 100644 --- a/app/src/main/res/values-pl/strings.xml +++ b/app/src/main/res/values-pl/strings.xml @@ -484,7 +484,6 @@ ", " Nie znaleziono zestawu domowego Rozszerzenie do Dashclock - Pokaż listy Nieprawidłowy plik kopii zapasowej Nowe zadania na górze Ikona diff --git a/app/src/main/res/values-pt-rBR/strings.xml b/app/src/main/res/values-pt-rBR/strings.xml index 011dc53f7..055502a08 100644 --- a/app/src/main/res/values-pt-rBR/strings.xml +++ b/app/src/main/res/values-pt-rBR/strings.xml @@ -447,7 +447,6 @@ Mostrar descrição completa Mostrar links Adicionar links para websites, endereços e números de telefone - Mostrar fichas de listas Lembrar ao chegar Lembrar ao sair Visitar website diff --git a/app/src/main/res/values-ru/strings.xml b/app/src/main/res/values-ru/strings.xml index 337f6217b..8d1345dd1 100644 --- a/app/src/main/res/values-ru/strings.xml +++ b/app/src/main/res/values-ru/strings.xml @@ -491,7 +491,6 @@ URL Ошибка: %s ", " - Показать списки Генерация уведомлений Повысить, понизить уровень подписки или отменить ее Понизить уровень подписки diff --git a/app/src/main/res/values-sk/strings.xml b/app/src/main/res/values-sk/strings.xml index 359602f4b..afad17bc2 100644 --- a/app/src/main/res/values-sk/strings.xml +++ b/app/src/main/res/values-sk/strings.xml @@ -446,7 +446,6 @@ Ukázať plný popis Ukázať prepojenia Pridať prepojenia do stránok, adries a telefónnych čísel - Ukázať zoznamy Pripomenúť pri príchode Pripomenúť pri odchode Navštíviť stránky diff --git a/app/src/main/res/values-sv/strings.xml b/app/src/main/res/values-sv/strings.xml index 8ba3c0737..23bdb7638 100644 --- a/app/src/main/res/values-sv/strings.xml +++ b/app/src/main/res/values-sv/strings.xml @@ -450,7 +450,6 @@ Visa fullständig beskrivning Visa länkar Lägg till länkar till webbplatser, adresser och telefonnummer - Visa listindikatörer Påminn vid ankomst Påminn om avgång Besök hemsida diff --git a/app/src/main/res/values-tr/strings.xml b/app/src/main/res/values-tr/strings.xml index 4782fbdfd..eb3d43e71 100644 --- a/app/src/main/res/values-tr/strings.xml +++ b/app/src/main/res/values-tr/strings.xml @@ -452,7 +452,6 @@ Tam açıklamayı göster Bağlantıları göster Web sitelerine, adreslere ve telefon numaralarına bağlantı ekle - Liste yongalarını göster Varışta hatırlat Kalkışta hatırlat Web siteyi ziyaret et diff --git a/app/src/main/res/values-uk/strings.xml b/app/src/main/res/values-uk/strings.xml index 05bf084cd..a53798d1e 100644 --- a/app/src/main/res/values-uk/strings.xml +++ b/app/src/main/res/values-uk/strings.xml @@ -465,7 +465,6 @@ Показувати повний опис Показувати посилання Виділяти посилання на веб-сайти, адреси та телефони - Відображати індикатори списків Нагадати по прибуттю Нагадати при відправці Відвідати сторінку diff --git a/app/src/main/res/values-zh-rCN/strings.xml b/app/src/main/res/values-zh-rCN/strings.xml index 7b6b903e6..152563d39 100644 --- a/app/src/main/res/values-zh-rCN/strings.xml +++ b/app/src/main/res/values-zh-rCN/strings.xml @@ -432,7 +432,6 @@ 显示完整描述 显示链接 增加链接至网站,地址,电话号码 - 显示列表指示器 位置 默认位置提醒 默认半径 diff --git a/app/src/main/res/values/keys.xml b/app/src/main/res/values/keys.xml index f722bf1f2..87336dc45 100644 --- a/app/src/main/res/values/keys.xml +++ b/app/src/main/res/values/keys.xml @@ -340,7 +340,6 @@ show_full_description linkify_task_list linkify_task_edit - show_list_indicators Mapbox Google map_provider @@ -357,6 +356,10 @@ notified_oauth_error_%1$s_%2$s chip_style chip_appearance + chips_subtask + chips_place + chips_list + chips_tag desaturate_colors collapse_filters collapse_tags diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 3ccc818e4..2952ae6ac 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -507,7 +507,6 @@ File %1$s contained %2$s.\n\n Show full description Show links Add links to websites, addresses, and phone numbers - Show list chips Remind on arrival Remind on departure Visit website diff --git a/app/src/main/res/xml/preferences_look_and_feel.xml b/app/src/main/res/xml/preferences_look_and_feel.xml index 32940fb2b..cebbd11b8 100644 --- a/app/src/main/res/xml/preferences_look_and_feel.xml +++ b/app/src/main/res/xml/preferences_look_and_feel.xml @@ -78,11 +78,6 @@ android:key="@string/p_show_full_description" android:title="@string/show_full_description" /> - - + + + + + + + +