Fixed bug where rotation would lose subtasks setting

astrid/src/com/todoroo/astrid/activity/AstridActivity.java

@@ -201,12 +201,8 @@ public class AstridActivity extends FragmentActivity
     public void setupTasklistFragmentWithFilter(Filter filter, Bundle extras) {
         Class<?> customTaskList = TaskListFragment.class;
 
-        if(filter == null || CoreFilterExposer.isInbox(filter)) {
-            SharedPreferences publicPrefs = AstridPreferences.getPublicPrefs(this);
-            int sortFlags = publicPrefs.getInt(SortHelper.PREF_SORT_FLAGS, 0);
-            if(SortHelper.isManualSort(sortFlags))
-                customTaskList = SubtasksListFragment.class;
-        }
+        if (shouldUseSubtasksFragmentForFilter(filter))
+            customTaskList = SubtasksListFragment.class;
 
         setupTasklistFragmentWithFilterAndCustomTaskList(filter, extras, customTaskList);
     }
@@ -232,6 +228,16 @@ public class AstridActivity extends FragmentActivity
         }
     }
 
+    public boolean shouldUseSubtasksFragmentForFilter(Filter filter) {
+        if(filter == null || CoreFilterExposer.isInbox(filter)) {
+            SharedPreferences publicPrefs = AstridPreferences.getPublicPrefs(this);
+            int sortFlags = publicPrefs.getInt(SortHelper.PREF_SORT_FLAGS, 0);
+            if(SortHelper.isManualSort(sortFlags))
+                return true;
+        }
+        return false;
+    }
+
     @Override
     public void onTaskListItemClicked(long taskId) {
         Intent intent = new Intent(this, TaskEditActivity.class);

astrid/src/com/todoroo/astrid/activity/TaskListActivity.java

@@ -195,15 +195,6 @@ public class TaskListActivity extends AstridActivity implements MainMenuListener
         }
     }
 
-    @Override
-    public void setupTasklistFragmentWithFilter(Filter filter, Bundle extras) {
-        if (fragmentLayout == LAYOUT_SINGLE) {
-            tlfPager.showFilter(filter);
-        } else {
-            super.setupTasklistFragmentWithFilter(filter, extras);
-        }
-    }
-
     @Override
     public void setupTasklistFragmentWithFilterAndCustomTaskList(Filter filter, Bundle extras, Class<?> customTaskList) {
         if (fragmentLayout == LAYOUT_SINGLE) {