From 852087ba745465ad4e3d030df5b653667e2ca3c5 Mon Sep 17 00:00:00 2001 From: Sam Bosley Date: Wed, 20 Mar 2013 15:10:11 -0700 Subject: [PATCH] Bugfix to leaving list option --- .../plugin-src/com/todoroo/astrid/actfm/TagViewFragment.java | 2 +- astrid/plugin-src/com/todoroo/astrid/tags/TagService.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/astrid/plugin-src/com/todoroo/astrid/actfm/TagViewFragment.java b/astrid/plugin-src/com/todoroo/astrid/actfm/TagViewFragment.java index 96cf11755..a78280650 100644 --- a/astrid/plugin-src/com/todoroo/astrid/actfm/TagViewFragment.java +++ b/astrid/plugin-src/com/todoroo/astrid/actfm/TagViewFragment.java @@ -415,7 +415,7 @@ public class TagViewFragment extends TaskListFragment { public void onClick(DialogInterface dialog, int which) { String uuid = tagData.getUuid(); tagDataDao.delete(tagData.getId()); - metadataDao.deleteWhere(Criterion.and(MetadataCriteria.withKey(TaskToTagMetadata.KEY), TagMetadata.TAG_UUID.eq(uuid))); + metadataDao.deleteWhere(Criterion.and(MetadataCriteria.withKey(TaskToTagMetadata.KEY), TaskToTagMetadata.TAG_UUID.eq(uuid))); tagMetadataDao.deleteWhere(TagMetadata.TAG_UUID.eq(uuid)); tla.switchToActiveTasks(); } diff --git a/astrid/plugin-src/com/todoroo/astrid/tags/TagService.java b/astrid/plugin-src/com/todoroo/astrid/tags/TagService.java index bbeffbeb9..5ba662bad 100644 --- a/astrid/plugin-src/com/todoroo/astrid/tags/TagService.java +++ b/astrid/plugin-src/com/todoroo/astrid/tags/TagService.java @@ -397,13 +397,13 @@ public final class TagService { */ public ArrayList getTagList() { ArrayList tagList = new ArrayList(); - TodorooCursor cursor = tagDataService.query(Query.select(TagData.PROPERTIES).orderBy(Order.asc(Functions.upper(TagData.NAME)))); + TodorooCursor cursor = tagDataService.query(Query.select(TagData.PROPERTIES).where(Criterion.and(TagData.DELETION_DATE.eq(0), TagData.NAME.isNotNull())).orderBy(Order.asc(Functions.upper(TagData.NAME)))); try { TagData tagData = new TagData(); for(cursor.moveToFirst(); !cursor.isAfterLast(); cursor.moveToNext()) { tagData.readFromCursor(cursor); Tag tag = new Tag(tagData); - if(tagData.getValue(TagData.DELETION_DATE) > 0 || tagData.getFlag(TagData.FLAGS, TagData.FLAG_FEATURED)) { + if(tagData.getFlag(TagData.FLAGS, TagData.FLAG_FEATURED)) { continue; } if(TextUtils.isEmpty(tag.tag))