From 800519a5aef6929a67fa4a41ba876d8ed197dc1e Mon Sep 17 00:00:00 2001 From: Tim Su Date: Thu, 21 Jul 2011 01:11:03 -0700 Subject: [PATCH] Better checks for when not to push --- .../todoroo/astrid/actfm/sync/ActFmSyncService.java | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/astrid/plugin-src/com/todoroo/astrid/actfm/sync/ActFmSyncService.java b/astrid/plugin-src/com/todoroo/astrid/actfm/sync/ActFmSyncService.java index 884b81954..d94da21a7 100644 --- a/astrid/plugin-src/com/todoroo/astrid/actfm/sync/ActFmSyncService.java +++ b/astrid/plugin-src/com/todoroo/astrid/actfm/sync/ActFmSyncService.java @@ -50,6 +50,7 @@ import com.todoroo.astrid.data.TagData; import com.todoroo.astrid.data.Task; import com.todoroo.astrid.data.Update; import com.todoroo.astrid.service.MetadataService; +import com.todoroo.astrid.service.StartupService; import com.todoroo.astrid.service.StatisticsService; import com.todoroo.astrid.service.TagDataService; import com.todoroo.astrid.service.TaskService; @@ -193,6 +194,14 @@ public final class ActFmSyncService { ArrayList params = new ArrayList(); + // prevent creation of certain types of tasks + if(newlyCreated) { + if(task.getValue(Task.TITLE).length() == 0) + return; + if(task.getId() <= StartupService.INTRO_TASK_SIZE) + return; + } + if(values.containsKey(Task.TITLE.name)) { params.add("title"); params.add(task.getValue(Task.TITLE)); } @@ -252,8 +261,7 @@ public final class ActFmSyncService { if(!newlyCreated) { params.add("id"); params.add(remoteId); - } else if(!params.contains(Task.TITLE.name)) - return; + } try { params.add("token"); params.add(token);