Ixnay duplicated notes

astrid/plugin-src/com/todoroo/astrid/producteev/sync/ProducteevDataService.java

@@ -152,10 +152,10 @@ public final class ProducteevDataService {
         taskDao.save(task.task);
 
         task.metadata.add(task.pdvTask);
+        // note we don't include note metadata, since we only receive deltas
         metadataService.synchronizeMetadata(task.task.getId(), task.metadata,
                 Criterion.or(MetadataCriteria.withKey(ProducteevTask.METADATA_KEY),
-                        MetadataCriteria.withKey(TagService.KEY),
-                        MetadataCriteria.withKey(NoteMetadata.METADATA_KEY)));
+                        MetadataCriteria.withKey(TagService.KEY)));
     }
 
     /**

astrid/plugin-src/com/todoroo/astrid/producteev/sync/ProducteevSyncProvider.java

@@ -387,11 +387,10 @@ public class ProducteevSyncProvider extends SyncProvider<ProducteevTaskContainer
         JSONArray notes = remoteTask.getJSONArray("notes");
         for(int i = notes.length() - 1; i >= 0; i--) {
             JSONObject note = notes.getJSONObject(i).getJSONObject("note");
-            if(note.getLong("deleted") != 0) {
-                PluginServices.getMetadataService().deleteWhere(Criterion.and(Metadata.KEY.eq(NoteMetadata.METADATA_KEY),
-                                NoteMetadata.EXT_ID.eq(note.getString("id_note"))));
+            PluginServices.getMetadataService().deleteWhere(Criterion.and(Metadata.KEY.eq(NoteMetadata.METADATA_KEY),
+                    NoteMetadata.EXT_ID.eq(note.getString("id_note"))));
+            if(note.getLong("deleted") != 0)
                 continue;
-            }
 
             long creator = note.getLong("id_creator");
             metadata.add(ApiUtilities.createNoteMetadata(note, creatorName(container, creator)));