Fixed a bug where list members could be overwritten on first save

13 years ago · 7ac45fde56
parent 7e378078a9
commit 7ac45fde56
1 changed files with 4 additions and 5 deletions
--- a/astrid/plugin-src/com/todoroo/astrid/actfm/TagSettingsActivity.java
+++ b/astrid/plugin-src/com/todoroo/astrid/actfm/TagSettingsActivity.java
@ -163,13 +163,12 @@ public class TagSettingsActivity extends Activity {
            }
        }

-        if(newName.length() > 0 && oldName.length() == 0) {
-            tagDataService.save(tagData);
-            //setUpNewTag(newName);
-        }
-
        JSONArray members = tagMembers.toJSONArray();
+
        if(members.length() > 0 && !actFmPreferenceService.isLoggedIn()) {
+            if(newName.length() > 0 && oldName.length() == 0) {
+                tagDataService.save(tagData);
+            }
            startActivityForResult(new Intent(this, ActFmLoginActivity.class),
                        REQUEST_ACTFM_LOGIN);
            return;