Add list icon

app/src/main/java/com/todoroo/astrid/core/BuiltInFilterExposer.java

@@ -83,7 +83,7 @@ public final class BuiltInFilterExposer {
 
   public Filter getMyTasksFilter() {
     Filter myTasksFilter = getMyTasksFilter(context.getResources());
-    myTasksFilter.icon = CustomIcons.getALL_INBOX();
+    myTasksFilter.icon = CustomIcons.ALL_INBOX;
     return myTasksFilter;
   }
 
@@ -92,12 +92,12 @@ public final class BuiltInFilterExposer {
     List<Filter> filters = new ArrayList<>();
     if (preferences.getBoolean(R.string.p_show_today_filter, true)) {
       Filter todayFilter = getTodayFilter(r);
-      todayFilter.icon = CustomIcons.getTODAY();
+      todayFilter.icon = CustomIcons.TODAY;
       filters.add(todayFilter);
     }
     if (preferences.getBoolean(R.string.p_show_recently_modified_filter, true)) {
       Filter recentlyModifiedFilter = getRecentlyModifiedFilter(r);
-      recentlyModifiedFilter.icon = CustomIcons.getHISTORY();
+      recentlyModifiedFilter.icon = CustomIcons.HISTORY;
       filters.add(recentlyModifiedFilter);
     }
     return filters;

app/src/main/java/org/tasks/activities/BaseListSettingsActivity.java

@@ -182,7 +182,7 @@ public abstract class BaseListSettingsActivity extends ThemedInjectingAppCompatA
     themeColor.applyToSystemBars(this);
     Integer icon = CustomIcons.getIconResId(selectedIcon);
     if (icon == null) {
-      icon = CustomIcons.getIconResId(CustomIcons.getCLOUD());
+      icon = CustomIcons.getIconResId(CustomIcons.CLOUD);
     }
     DrawableUtil.setLeftDrawable(this, this.icon, icon);
     getLeftDrawable(this.icon).setTint(getColor(R.color.icon_tint_with_alpha));

app/src/main/java/org/tasks/themes/CustomIcons.kt

@@ -4,28 +4,16 @@ import org.tasks.R
 
 object CustomIcons {
 
-    @kotlin.jvm.JvmStatic
-    val LABEL = 1
+    const val LABEL = 1
+    const val FILTER = 2
+    const val CLOUD = 3
+    const val ALL_INBOX = 4
+    const val HISTORY = 6
+    const val TODAY = 7
+    const val LIST = 8
+    const val PLACE = 1050
 
-    @kotlin.jvm.JvmStatic
-    val FILTER = 2
-
-    @kotlin.jvm.JvmStatic
-    val CLOUD = 3
-
-    @kotlin.jvm.JvmStatic
-    val ALL_INBOX = 4
-
-    @kotlin.jvm.JvmStatic
-    val HISTORY = 6
-
-    @kotlin.jvm.JvmStatic
-    val TODAY = 7
-
-    @kotlin.jvm.JvmStatic
-    val PLACE = 1050
-
-    @kotlin.jvm.JvmField
+    @JvmStatic
     var ICONS = mapOf(
         LABEL to R.drawable.ic_outline_label_24px,
         FILTER to R.drawable.ic_outline_filter_list_24px,
@@ -34,6 +22,7 @@ object CustomIcons {
         5 to R.drawable.ic_outline_label_off_24px,
         HISTORY to R.drawable.ic_outline_history_24px,
         TODAY to R.drawable.ic_outline_today_24px,
+        LIST to R.drawable.ic_list_24px,
         1000 to R.drawable.ic_outline_flag_24px,
         1062 to R.drawable.ic_outline_home_24px,
         1041 to R.drawable.ic_outline_work_outline_24px,
@@ -197,12 +186,12 @@ object CustomIcons {
         1160 to R.drawable.ic_thumb_down_24px
     )
 
-    @kotlin.jvm.JvmStatic
+    @JvmStatic
     fun getIconList() = ICONS.keys.toList()
 
-    @kotlin.jvm.JvmStatic
+    @JvmStatic
     fun getIconResId(index: Int) = ICONS[index]
 
-    @kotlin.jvm.JvmStatic
+    @JvmStatic
     fun getIndex(position: Int) = getIconList()[position]
 }

app/src/main/res/drawable/ic_list_24px.xml

@@ -0,0 +1,5 @@
+<vector android:autoMirrored="true" android:height="24dp"
+    android:viewportHeight="24" android:viewportWidth="24"
+    android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android">
+    <path android:fillColor="#FF000000" android:pathData="M3,13h2v-2L3,11v2zM3,17h2v-2L3,15v2zM3,9h2L5,7L3,7v2zM7,13h14v-2L7,11v2zM7,17h14v-2L7,15v2zM7,7v2h14L21,7L7,7zM3,13h2v-2L3,11v2zM3,17h2v-2L3,15v2zM3,9h2L5,7L3,7v2zM7,13h14v-2L7,11v2zM7,17h14v-2L7,15v2zM7,7v2h14L21,7L7,7z"/>
+</vector>