Fix for a couple force closes

pull/14/head
Sam Bosley 14 years ago
parent 4abe77943d
commit 7641d01a43

@ -394,7 +394,7 @@ public class TagViewActivity extends TaskListActivity {
public void onReceive(Context context, Intent intent) { public void onReceive(Context context, Intent intent) {
if(!intent.hasExtra("tag_id")) if(!intent.hasExtra("tag_id"))
return; return;
if(!Long.toString(tagData.getValue(TagData.REMOTE_ID)).equals(intent.getStringExtra("tag_id"))) if(tagData == null || !Long.toString(tagData.getValue(TagData.REMOTE_ID)).equals(intent.getStringExtra("tag_id")))
return; return;
getActivity().runOnUiThread(new Runnable() { getActivity().runOnUiThread(new Runnable() {

@ -335,7 +335,7 @@ public class GtasksTaskListUpdater {
TodorooCursor<Metadata> metadata = metadataDao.query(Query.select(Metadata.PROPERTIES) TodorooCursor<Metadata> metadata = metadataDao.query(Query.select(Metadata.PROPERTIES)
.where(Criterion.and(Metadata.KEY.eq(GtasksMetadata.METADATA_KEY), GtasksMetadata.LIST_ID.eq(listId), GtasksMetadata.PARENT_TASK.eq(parent))) .where(Criterion.and(Metadata.KEY.eq(GtasksMetadata.METADATA_KEY), GtasksMetadata.LIST_ID.eq(listId), GtasksMetadata.PARENT_TASK.eq(parent)))
.orderBy(Order.asc(GtasksMetadata.GTASKS_ORDER))); .orderBy(Order.asc(GtasksMetadata.GTASKS_ORDER)));
try {
if (metadata.getCount() > 0) { if (metadata.getCount() > 0) {
Metadata curr = new Metadata(); Metadata curr = new Metadata();
for (metadata.moveToFirst(); !metadata.isAfterLast(); metadata.moveToNext()) { for (metadata.moveToFirst(); !metadata.isAfterLast(); metadata.moveToNext()) {
@ -347,6 +347,9 @@ public class GtasksTaskListUpdater {
orderAndIndentHelper(listId, order, curr.getValue(Metadata.TASK), indentLevel + 1); orderAndIndentHelper(listId, order, curr.getValue(Metadata.TASK), indentLevel + 1);
} }
} }
} finally {
metadata.close();
}
} }
/** /**

Loading…
Cancel
Save