Fixed a crash and a minor bug in handling undownloaded files

astrid/plugin-src/com/todoroo/astrid/actfm/sync/ActFmSyncService.java

@@ -1171,7 +1171,7 @@ public final class ActFmSyncService {
                         currentFiles.remove(id);
                     } else {
                         // Create new file attachment
-                        Metadata newAttachment = FileMetadata.createNewFileMetadata(model.getId(), null,
+                        Metadata newAttachment = FileMetadata.createNewFileMetadata(model.getId(), "",
                                 file.getString("name"), file.getString("content_type"));
                         String url = file.getString("url");
                         newAttachment.setValue(FileMetadata.URL, url);

astrid/plugin-src/com/todoroo/astrid/files/FilesControlSet.java

@@ -110,7 +110,7 @@ public class FilesControlSet extends PopupControlSet {
             if (m.containsNonNullValue(FileMetadata.FILE_PATH)) {
                 File f = new File(m.getValue(FileMetadata.FILE_PATH));
                 if (!f.exists()) {
-                    m.setValue(FileMetadata.FILE_PATH, null);
+                    m.setValue(FileMetadata.FILE_PATH, ""); //$NON-NLS-1$
                     if (m.containsNonNullValue(FileMetadata.URL)) { // We're ok, just the local file was deleted
                         metadataService.save(m);
                     } else { // No local file and no url -- delete the metadata
@@ -319,7 +319,7 @@ public class FilesControlSet extends PopupControlSet {
                         }
                     });
                 } finally {
-                    pd.dismiss();
+                    DialogUtilities.dismissDialog(activity, pd);
                 }
             }
         }.start();