From 7486006f4d9c6b48a46585798143949e6cedb022 Mon Sep 17 00:00:00 2001
From: Alex Baker <alex@tasks.org>
Date: Mon, 22 Jan 2018 15:53:35 -0600
Subject: [PATCH] Remove task.getUUID

---
 .../com/todoroo/andlib/data/DatabaseDao.java  |  4 +--
 .../astrid/activity/TaskListFragment.java     |  2 +-
 .../java/com/todoroo/astrid/dao/TaskDao.java  |  4 +--
 .../java/com/todoroo/astrid/data/Task.java    | 26 +++++--------------
 .../todoroo/astrid/tags/TagsControlSet.java   |  4 +--
 5 files changed, 14 insertions(+), 26 deletions(-)

diff --git a/app/src/main/java/com/todoroo/andlib/data/DatabaseDao.java b/app/src/main/java/com/todoroo/andlib/data/DatabaseDao.java
index f9f69d795..956cc72e1 100644
--- a/app/src/main/java/com/todoroo/andlib/data/DatabaseDao.java
+++ b/app/src/main/java/com/todoroo/andlib/data/DatabaseDao.java
@@ -134,8 +134,8 @@ public class DatabaseDao {
      * @return returns true on success.
      */
     public boolean createNew(final Task item) {
-        if (!item.containsValue(Task.UUID) || Task.isUuidEmpty(item.getUuidProperty())) {
-            item.setUuidProperty(UUIDHelper.newUUID());
+        if (!item.containsValue(Task.UUID) || Task.isUuidEmpty(item.getUuid())) {
+            item.setUuid(UUIDHelper.newUUID());
         }
 
         item.clearValue(AbstractModel.ID_PROPERTY);
diff --git a/app/src/main/java/com/todoroo/astrid/activity/TaskListFragment.java b/app/src/main/java/com/todoroo/astrid/activity/TaskListFragment.java
index 4d1eb00f9..79dcb83c3 100644
--- a/app/src/main/java/com/todoroo/astrid/activity/TaskListFragment.java
+++ b/app/src/main/java/com/todoroo/astrid/activity/TaskListFragment.java
@@ -514,7 +514,7 @@ public class TaskListFragment extends InjectingFragment implements
                     taskCreator.addToCalendar(task);
                     onTaskListItemClicked(task);
                     loadTaskListContent();
-                    onTaskCreated(task.getUUID());
+                    onTaskCreated(task.getUuid());
                 }
             }
         } else if (requestCode == REQUEST_EDIT_FILTER) {
diff --git a/app/src/main/java/com/todoroo/astrid/dao/TaskDao.java b/app/src/main/java/com/todoroo/astrid/dao/TaskDao.java
index f923a8c57..f13c36f52 100644
--- a/app/src/main/java/com/todoroo/astrid/dao/TaskDao.java
+++ b/app/src/main/java/com/todoroo/astrid/dao/TaskDao.java
@@ -223,7 +223,7 @@ public abstract class TaskDao {
 
     private ContentValues handleSQLiteConstraintException(Task task) {
         TodorooCursor cursor = dao.query(Query.select(Task.ID).where(
-                Task.UUID.eq(task.getUUID())));
+                Task.UUID.eq(task.getUuid())));
         if (cursor.getCount() > 0) {
             cursor.moveToFirst();
             task.setId(cursor.get(Task.ID));
@@ -315,7 +315,7 @@ public abstract class TaskDao {
             saveExisting(item);
         } catch (SQLiteConstraintException e) {
             Timber.e(e, e.getMessage());
-            String uuid = item.getUUID();
+            String uuid = item.getUuid();
             TodorooCursor tasksWithUUID = dao.query(Query.select(
                     SQL_CONSTRAINT_MERGE_PROPERTIES).where(
                     Task.UUID.eq(uuid)));
diff --git a/app/src/main/java/com/todoroo/astrid/data/Task.java b/app/src/main/java/com/todoroo/astrid/data/Task.java
index 601797333..04e3e7d8f 100644
--- a/app/src/main/java/com/todoroo/astrid/data/Task.java
+++ b/app/src/main/java/com/todoroo/astrid/data/Task.java
@@ -255,7 +255,13 @@ public class Task extends AbstractModel {
     }
 
     public String getUuid() {
-        return getUuidHelper(UUID);
+        if(setValues != null && setValues.containsKey(UUID.name)) {
+            return setValues.getAsString(UUID.name);
+        } else if(values != null && values.containsKey(UUID.name)) {
+            return values.getAsString(UUID.name);
+        } else {
+            return NO_UUID;
+        }
     }
 
     // --- parcelable helpers
@@ -659,16 +665,6 @@ public class Task extends AbstractModel {
         }
     }
 
-    private String getUuidHelper(StringProperty uuid) {
-        if(setValues != null && setValues.containsKey(uuid.name)) {
-            return setValues.getAsString(uuid.name);
-        } else if(values != null && values.containsKey(uuid.name)) {
-            return values.getAsString(uuid.name);
-        } else {
-            return NO_UUID;
-        }
-    }
-
     public void setUuid(String uuid) {
         if (setValues == null) {
             setValues = new ContentValues();
@@ -684,12 +680,4 @@ public class Task extends AbstractModel {
     public static boolean isUuidEmpty(String uuid) {
         return NO_UUID.equals(uuid) || TextUtils.isEmpty(uuid);
     }
-
-    public String getUuidProperty() {
-        return getValue(UUID);
-    }
-
-    public void setUuidProperty(String uuidProperty) {
-        setValue(UUID, uuidProperty);
-    }
 }
diff --git a/app/src/main/java/com/todoroo/astrid/tags/TagsControlSet.java b/app/src/main/java/com/todoroo/astrid/tags/TagsControlSet.java
index ba64c3deb..cbc69cb75 100644
--- a/app/src/main/java/com/todoroo/astrid/tags/TagsControlSet.java
+++ b/app/src/main/java/com/todoroo/astrid/tags/TagsControlSet.java
@@ -196,7 +196,7 @@ public final class TagsControlSet extends TaskEditControlFragment {
 
     @Override
     public void apply(Task task) {
-        if (synchronizeTags(task.getId(), task.getUUID())) {
+        if (synchronizeTags(task.getId(), task.getUuid())) {
             Flags.set(Flags.TAGS_CHANGED);
             task.setModificationDate(DateUtilities.now());
         }
@@ -362,7 +362,7 @@ public final class TagsControlSet extends TaskEditControlFragment {
 
     @Override
     public boolean hasChanges(Task original) {
-        Set<TagData> existingSet = newHashSet(tagService.getTagDataForTask(original.getUUID()));
+        Set<TagData> existingSet = newHashSet(tagService.getTagDataForTask(original.getUuid()));
         Set<TagData> selectedSet = newHashSet(selectedTags);
         return !existingSet.equals(selectedSet);
     }