diff --git a/astrid/plugin-src/com/todoroo/astrid/gtasks/GtasksListFragment.java b/astrid/plugin-src/com/todoroo/astrid/gtasks/GtasksListFragment.java index a22b15a5b..8a637649a 100644 --- a/astrid/plugin-src/com/todoroo/astrid/gtasks/GtasksListFragment.java +++ b/astrid/plugin-src/com/todoroo/astrid/gtasks/GtasksListFragment.java @@ -27,7 +27,9 @@ import com.todoroo.astrid.data.Task; import com.todoroo.astrid.helper.ProgressBarSyncResultCallback; import com.todoroo.astrid.service.SyncV2Service; import com.todoroo.astrid.service.ThemeService; -import com.todoroo.astrid.subtasks.NewOrderedListFragmentHelper; +import com.todoroo.astrid.subtasks.AstridOrderedListFragmentHelper; +import com.todoroo.astrid.subtasks.OrderedListFragmentHelperInterface; +import com.todoroo.astrid.subtasks.OrderedMetadataListFragmentHelper; import com.todoroo.astrid.subtasks.SubtasksListFragment; public class GtasksListFragment extends SubtasksListFragment { @@ -60,8 +62,8 @@ public class GtasksListFragment extends SubtasksListFragment { }; @Override - protected NewOrderedListFragmentHelper createFragmentHelper() { - return new NewOrderedListFragmentHelper(this, null /*gtasksTaskListUpdater*/); + protected OrderedListFragmentHelperInterface createFragmentHelper() { + return new OrderedMetadataListFragmentHelper(this, gtasksTaskListUpdater); } @Override @@ -75,7 +77,7 @@ public class GtasksListFragment extends SubtasksListFragment { long storeObjectId = extras.getLong(TOKEN_STORE_ID, 0); list = storeObjectDao.fetch(storeObjectId, LIST_PROPERTIES); - ((NewOrderedListFragmentHelper)helper).setList(list); + ((AstridOrderedListFragmentHelper)helper).setList(list); } @Override diff --git a/astrid/plugin-src/com/todoroo/astrid/gtasks/GtasksMetadataService.java b/astrid/plugin-src/com/todoroo/astrid/gtasks/GtasksMetadataService.java index d0498d5d8..7511a33d1 100644 --- a/astrid/plugin-src/com/todoroo/astrid/gtasks/GtasksMetadataService.java +++ b/astrid/plugin-src/com/todoroo/astrid/gtasks/GtasksMetadataService.java @@ -29,7 +29,7 @@ import com.todoroo.astrid.data.Metadata; import com.todoroo.astrid.data.StoreObject; import com.todoroo.astrid.data.Task; import com.todoroo.astrid.gtasks.sync.GtasksTaskContainer; -import com.todoroo.astrid.subtasks.OrderedListUpdater.OrderedListIterator; +import com.todoroo.astrid.subtasks.OrderedMetadataListUpdater.OrderedListIterator; import com.todoroo.astrid.sync.SyncMetadataService; import com.todoroo.astrid.sync.SyncProviderUtilities; diff --git a/astrid/plugin-src/com/todoroo/astrid/gtasks/GtasksTaskListUpdater.java b/astrid/plugin-src/com/todoroo/astrid/gtasks/GtasksTaskListUpdater.java index 35c98e065..255e3d51d 100644 --- a/astrid/plugin-src/com/todoroo/astrid/gtasks/GtasksTaskListUpdater.java +++ b/astrid/plugin-src/com/todoroo/astrid/gtasks/GtasksTaskListUpdater.java @@ -28,10 +28,10 @@ import com.todoroo.astrid.data.Metadata; import com.todoroo.astrid.data.StoreObject; import com.todoroo.astrid.data.Task; import com.todoroo.astrid.gtasks.sync.GtasksSyncService; -import com.todoroo.astrid.subtasks.OrderedListUpdater; -import com.todoroo.astrid.subtasks.OrderedListUpdater.OrderedListIterator; +import com.todoroo.astrid.subtasks.OrderedMetadataListUpdater; +import com.todoroo.astrid.subtasks.OrderedMetadataListUpdater.OrderedListIterator; -public class GtasksTaskListUpdater extends OrderedListUpdater { +public class GtasksTaskListUpdater extends OrderedMetadataListUpdater { /** map of task -> parent task */ final HashMap parents = new HashMap(); diff --git a/astrid/plugin-src/com/todoroo/astrid/subtasks/NewOrderedListFragmentHelper.java b/astrid/plugin-src/com/todoroo/astrid/subtasks/AstridOrderedListFragmentHelper.java similarity index 96% rename from astrid/plugin-src/com/todoroo/astrid/subtasks/NewOrderedListFragmentHelper.java rename to astrid/plugin-src/com/todoroo/astrid/subtasks/AstridOrderedListFragmentHelper.java index 2091e687c..a79199d00 100644 --- a/astrid/plugin-src/com/todoroo/astrid/subtasks/NewOrderedListFragmentHelper.java +++ b/astrid/plugin-src/com/todoroo/astrid/subtasks/AstridOrderedListFragmentHelper.java @@ -38,11 +38,11 @@ import com.todoroo.astrid.service.ThemeService; import com.todoroo.astrid.ui.DraggableListView; import com.todoroo.astrid.utility.AstridPreferences; -public class NewOrderedListFragmentHelper { +public class AstridOrderedListFragmentHelper implements OrderedListFragmentHelperInterface { private final DisplayMetrics metrics = new DisplayMetrics(); - private final NewOrderedListUpdater updater; + private final AstridOrderedListUpdater updater; private final TaskListFragment fragment; @Autowired TaskService taskService; @@ -52,7 +52,7 @@ public class NewOrderedListFragmentHelper { private LIST list; - public NewOrderedListFragmentHelper(TaskListFragment fragment, NewOrderedListUpdater updater) { + public AstridOrderedListFragmentHelper(TaskListFragment fragment, AstridOrderedListUpdater updater) { DependencyInjectionService.getInstance().inject(this); this.fragment = fragment; this.updater = updater; @@ -275,9 +275,9 @@ public class NewOrderedListFragmentHelper { } final ArrayList chained = new ArrayList(); - updater.applyToDescendants(itemId, new NewOrderedListUpdater.OrderedListNodeVisitor() { + updater.applyToDescendants(itemId, new AstridOrderedListUpdater.OrderedListNodeVisitor() { @Override - public void visitNode(NewOrderedListUpdater.Node node) { + public void visitNode(AstridOrderedListUpdater.Node node) { // Task childTask = taskService.fetchById(node.taskId, Task.RECURRENCE); // // if(!TextUtils.isEmpty(childTask.getValue(Task.RECURRENCE))) { diff --git a/astrid/plugin-src/com/todoroo/astrid/subtasks/NewOrderedListUpdater.java b/astrid/plugin-src/com/todoroo/astrid/subtasks/AstridOrderedListUpdater.java similarity index 99% rename from astrid/plugin-src/com/todoroo/astrid/subtasks/NewOrderedListUpdater.java rename to astrid/plugin-src/com/todoroo/astrid/subtasks/AstridOrderedListUpdater.java index 5380205a2..64f21c77e 100644 --- a/astrid/plugin-src/com/todoroo/astrid/subtasks/NewOrderedListUpdater.java +++ b/astrid/plugin-src/com/todoroo/astrid/subtasks/AstridOrderedListUpdater.java @@ -17,12 +17,12 @@ import com.todoroo.astrid.api.Filter; import com.todoroo.astrid.data.Task; import com.todoroo.astrid.service.TaskService; -public abstract class NewOrderedListUpdater { +public abstract class AstridOrderedListUpdater { @Autowired private TaskService taskService; - public NewOrderedListUpdater() { + public AstridOrderedListUpdater() { DependencyInjectionService.getInstance().inject(this); idToNode = new HashMap(); } diff --git a/astrid/plugin-src/com/todoroo/astrid/subtasks/OrderedListFragmentHelperInterface.java b/astrid/plugin-src/com/todoroo/astrid/subtasks/OrderedListFragmentHelperInterface.java new file mode 100644 index 000000000..450479bbe --- /dev/null +++ b/astrid/plugin-src/com/todoroo/astrid/subtasks/OrderedListFragmentHelperInterface.java @@ -0,0 +1,18 @@ +package com.todoroo.astrid.subtasks; + +import java.util.concurrent.atomic.AtomicReference; + +import com.todoroo.andlib.data.TodorooCursor; +import com.todoroo.astrid.adapter.TaskAdapter; +import com.todoroo.astrid.api.Filter; +import com.todoroo.astrid.data.Task; + +public interface OrderedListFragmentHelperInterface { + + void setUpUiComponents(); + void beforeSetUpTaskList(Filter filter); + void onCreateTask(Task task); + void onDeleteTask(Task task); + TaskAdapter createTaskAdapter(TodorooCursor cursor, AtomicReference queryTemplate); + +} diff --git a/astrid/plugin-src/com/todoroo/astrid/subtasks/OrderedListFragmentHelper.java b/astrid/plugin-src/com/todoroo/astrid/subtasks/OrderedMetadataListFragmentHelper.java similarity index 95% rename from astrid/plugin-src/com/todoroo/astrid/subtasks/OrderedListFragmentHelper.java rename to astrid/plugin-src/com/todoroo/astrid/subtasks/OrderedMetadataListFragmentHelper.java index 22fd07b54..90f34caf0 100644 --- a/astrid/plugin-src/com/todoroo/astrid/subtasks/OrderedListFragmentHelper.java +++ b/astrid/plugin-src/com/todoroo/astrid/subtasks/OrderedMetadataListFragmentHelper.java @@ -44,15 +44,15 @@ import com.todoroo.astrid.data.Task; import com.todoroo.astrid.service.MetadataService; import com.todoroo.astrid.service.TaskService; import com.todoroo.astrid.service.ThemeService; -import com.todoroo.astrid.subtasks.OrderedListUpdater.Node; -import com.todoroo.astrid.subtasks.OrderedListUpdater.OrderedListNodeVisitor; +import com.todoroo.astrid.subtasks.OrderedMetadataListUpdater.Node; +import com.todoroo.astrid.subtasks.OrderedMetadataListUpdater.OrderedListNodeVisitor; import com.todoroo.astrid.ui.DraggableListView; import com.todoroo.astrid.utility.AstridPreferences; -public class OrderedListFragmentHelper { +public class OrderedMetadataListFragmentHelper implements OrderedListFragmentHelperInterface { private final DisplayMetrics metrics = new DisplayMetrics(); - private final OrderedListUpdater updater; + private final OrderedMetadataListUpdater updater; private final TaskListFragment fragment; @Autowired TaskService taskService; @@ -62,7 +62,7 @@ public class OrderedListFragmentHelper { private LIST list; - public OrderedListFragmentHelper(TaskListFragment fragment, OrderedListUpdater updater) { + public OrderedMetadataListFragmentHelper(TaskListFragment fragment, OrderedMetadataListUpdater updater) { DependencyInjectionService.getInstance().inject(this); this.fragment = fragment; this.updater = updater; @@ -321,6 +321,11 @@ public class OrderedListFragmentHelper { this.list = list; } + @Override + public void onCreateTask(Task task) { + // + } + public void onDeleteTask(Task task) { updater.onDeleteTask(getFilter(), list, task.getId()); taskAdapter.notifyDataSetInvalidated(); diff --git a/astrid/plugin-src/com/todoroo/astrid/subtasks/OrderedListUpdater.java b/astrid/plugin-src/com/todoroo/astrid/subtasks/OrderedMetadataListUpdater.java similarity index 98% rename from astrid/plugin-src/com/todoroo/astrid/subtasks/OrderedListUpdater.java rename to astrid/plugin-src/com/todoroo/astrid/subtasks/OrderedMetadataListUpdater.java index b8dd7cf40..60acb9f9b 100644 --- a/astrid/plugin-src/com/todoroo/astrid/subtasks/OrderedListUpdater.java +++ b/astrid/plugin-src/com/todoroo/astrid/subtasks/OrderedMetadataListUpdater.java @@ -18,11 +18,11 @@ import com.todoroo.astrid.api.Filter; import com.todoroo.astrid.core.PluginServices; import com.todoroo.astrid.data.Metadata; import com.todoroo.astrid.data.Task; -import com.todoroo.astrid.subtasks.OrderedListUpdater.OrderedListIterator; +import com.todoroo.astrid.subtasks.OrderedMetadataListUpdater.OrderedListIterator; -abstract public class OrderedListUpdater { +abstract public class OrderedMetadataListUpdater { - public OrderedListUpdater() { + public OrderedMetadataListUpdater() { DependencyInjectionService.getInstance().inject(this); } diff --git a/astrid/plugin-src/com/todoroo/astrid/subtasks/SubtasksListFragment.java b/astrid/plugin-src/com/todoroo/astrid/subtasks/SubtasksListFragment.java index afe4a9157..55d8e3078 100644 --- a/astrid/plugin-src/com/todoroo/astrid/subtasks/SubtasksListFragment.java +++ b/astrid/plugin-src/com/todoroo/astrid/subtasks/SubtasksListFragment.java @@ -24,7 +24,7 @@ import com.todoroo.astrid.data.Task; */ public class SubtasksListFragment extends TaskListFragment { - protected NewOrderedListFragmentHelper helper; + protected OrderedListFragmentHelperInterface helper; @Override public void onActivityCreated(Bundle savedInstanceState) { @@ -32,9 +32,9 @@ public class SubtasksListFragment extends TaskListFragment { super.onActivityCreated(savedInstanceState); } - protected NewOrderedListFragmentHelper createFragmentHelper() { - NewOrderedListFragmentHelper olfh = - new NewOrderedListFragmentHelper(this, new SubtasksUpdater()); + protected OrderedListFragmentHelperInterface createFragmentHelper() { + AstridOrderedListFragmentHelper olfh = + new AstridOrderedListFragmentHelper(this, new SubtasksUpdater()); olfh.setList(getActiveTagData()); return olfh; } diff --git a/astrid/plugin-src/com/todoroo/astrid/subtasks/SubtasksMetadata.java b/astrid/plugin-src/com/todoroo/astrid/subtasks/SubtasksMetadata.java index 2b75df725..1eb8dfdc9 100644 --- a/astrid/plugin-src/com/todoroo/astrid/subtasks/SubtasksMetadata.java +++ b/astrid/plugin-src/com/todoroo/astrid/subtasks/SubtasksMetadata.java @@ -16,6 +16,7 @@ import com.todoroo.astrid.data.Metadata; * @author Tim Su * */ +@Deprecated public class SubtasksMetadata { public static final String LIST_ACTIVE_TASKS = "[AT]"; //$NON-NLS-1$ diff --git a/astrid/plugin-src/com/todoroo/astrid/subtasks/SubtasksTagListFragment.java b/astrid/plugin-src/com/todoroo/astrid/subtasks/SubtasksTagListFragment.java index 0ec4e5135..8742ffd8c 100644 --- a/astrid/plugin-src/com/todoroo/astrid/subtasks/SubtasksTagListFragment.java +++ b/astrid/plugin-src/com/todoroo/astrid/subtasks/SubtasksTagListFragment.java @@ -17,11 +17,11 @@ import com.todoroo.astrid.data.Task; public class SubtasksTagListFragment extends TagViewFragment { - private final NewOrderedListFragmentHelper helper; + private final AstridOrderedListFragmentHelper helper; public SubtasksTagListFragment() { super(); - helper = new NewOrderedListFragmentHelper(this, new SubtasksUpdater()); + helper = new AstridOrderedListFragmentHelper(this, new SubtasksUpdater()); } @Override diff --git a/astrid/plugin-src/com/todoroo/astrid/subtasks/SubtasksUpdater.java b/astrid/plugin-src/com/todoroo/astrid/subtasks/SubtasksUpdater.java index 8961fed96..ac1026695 100644 --- a/astrid/plugin-src/com/todoroo/astrid/subtasks/SubtasksUpdater.java +++ b/astrid/plugin-src/com/todoroo/astrid/subtasks/SubtasksUpdater.java @@ -15,7 +15,7 @@ import com.todoroo.astrid.data.Task; import com.todoroo.astrid.service.TagDataService; import com.todoroo.astrid.service.TaskService; -public class SubtasksUpdater extends NewOrderedListUpdater { +public class SubtasksUpdater extends AstridOrderedListUpdater { @Autowired TagDataService tagDataService; @Autowired TaskService taskService;