From fbaa2203b46ff0d5168633f5c4798769ac9b869e Mon Sep 17 00:00:00 2001 From: Arne Jans Date: Tue, 18 Oct 2011 14:15:07 +0200 Subject: [PATCH 1/5] Minor fix for wrong midnight-time in german localization. --- astrid/res/values-de/strings.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/astrid/res/values-de/strings.xml b/astrid/res/values-de/strings.xml index e93bcffe5..ea3c0a2c8 100644 --- a/astrid/res/values-de/strings.xml +++ b/astrid/res/values-de/strings.xml @@ -1652,7 +1652,7 @@ Achtung: diese Aufgaben sind unwiederbringlich verloren, wenn Sie kein Backup ge 21:00 22:00 23:00 - 24:00 + 00:00 01:00 02:00 03:00 From 3635dab3bada7c43cad4fa934e1690c8e616a99f Mon Sep 17 00:00:00 2001 From: Arne Jans Date: Tue, 18 Oct 2011 14:44:28 +0200 Subject: [PATCH 2/5] Symptom-fix for ArrayIndexOutOfBoundsException. Presumably happening during focusGain of the ReminderPreferences-activity for the default-remindertime settting. Details: https://www.crittercism.com/developers/crash-details/e0886dbfcf9e78a21d9f2e2a385c4c13e2f6ad2132ac24a3fa811144 --- .../com/todoroo/astrid/reminders/ReminderPreferences.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/astrid/plugin-src/com/todoroo/astrid/reminders/ReminderPreferences.java b/astrid/plugin-src/com/todoroo/astrid/reminders/ReminderPreferences.java index 26e35264e..3f3780cfd 100644 --- a/astrid/plugin-src/com/todoroo/astrid/reminders/ReminderPreferences.java +++ b/astrid/plugin-src/com/todoroo/astrid/reminders/ReminderPreferences.java @@ -54,8 +54,12 @@ public class ReminderPreferences extends TodorooPreferenceActivity { } } else if(r.getString(R.string.p_rmd_time).equals(preference.getKey())) { int index = AndroidUtilities.indexOf(r.getStringArray(R.array.EPr_rmd_time_values), (String)value); - String setting = r.getStringArray(R.array.EPr_rmd_time)[index]; - preference.setSummary(r.getString(R.string.rmd_EPr_rmd_time_desc, setting)); + if (index != -1 && index < r.getStringArray(R.array.EPr_rmd_time).length) { + // FIXME this does not fix the underlying cause of the ArrayIndexOutofBoundsException + // https://www.crittercism.com/developers/crash-details/e0886dbfcf9e78a21d9f2e2a385c4c13e2f6ad2132ac24a3fa811144 + String setting = r.getStringArray(R.array.EPr_rmd_time)[index]; + preference.setSummary(r.getString(R.string.rmd_EPr_rmd_time_desc, setting)); + } } else if(r.getString(R.string.p_rmd_ringtone).equals(preference.getKey())) { if(value == null || "content://settings/system/notification_sound".equals(value)) //$NON-NLS-1$ preference.setSummary(r.getString(R.string.rmd_EPr_ringtone_desc_default)); From c28ec6387b3b1395bad5d6941a7732f354b07dcc Mon Sep 17 00:00:00 2001 From: Arne Jans Date: Wed, 19 Oct 2011 12:35:01 +0200 Subject: [PATCH 3/5] Fixed some localized time-strings --- astrid/res/values-de/strings.xml | 4 ++-- astrid/res/values-pl/strings.xml | 6 +++--- astrid/res/values-pt/strings.xml | 6 +++--- astrid/res/values-zh-rCN/strings.xml | 2 +- astrid/res/values-zh-rTW/strings.xml | 6 +++--- 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/astrid/res/values-de/strings.xml b/astrid/res/values-de/strings.xml index ea3c0a2c8..3fc974c3e 100644 --- a/astrid/res/values-de/strings.xml +++ b/astrid/res/values-de/strings.xml @@ -1585,7 +1585,7 @@ Achtung: diese Aufgaben sind unwiederbringlich verloren, wenn Sie kein Backup ge 21:00 22:00 23:00 - 24:00 + 00:00 01:00 02:00 03:00 @@ -1624,7 +1624,7 @@ Achtung: diese Aufgaben sind unwiederbringlich verloren, wenn Sie kein Backup ge 21:00 22:00 23:00 - 24:00 + 00:00 01:00 02:00 03:00 diff --git a/astrid/res/values-pl/strings.xml b/astrid/res/values-pl/strings.xml index 3e6ff70f4..d42bdfae1 100644 --- a/astrid/res/values-pl/strings.xml +++ b/astrid/res/values-pl/strings.xml @@ -1586,7 +1586,7 @@ Astrid is open-source and proudly maintained by Todoroo, Inc. 21:00 22:00 23:00 - 24:00 + 00:00 01:00 02:00 03:00 @@ -1625,7 +1625,7 @@ Astrid is open-source and proudly maintained by Todoroo, Inc. 21:00 22:00 23:00 - 24:00 + 00:00 01:00 02:00 03:00 @@ -1653,7 +1653,7 @@ Astrid is open-source and proudly maintained by Todoroo, Inc. 21:00 22:00 23:00 - 24:00 + 00:00 01:00 02:00 03:00 diff --git a/astrid/res/values-pt/strings.xml b/astrid/res/values-pt/strings.xml index 84938ce97..c663bb5f9 100644 --- a/astrid/res/values-pt/strings.xml +++ b/astrid/res/values-pt/strings.xml @@ -1661,10 +1661,10 @@ Astrid might not let you know when your tasks are due.\n 21:00 22:00 23:00 - 12:00 - 13:00 - 02:00 + 00:00 + 01:00 02:00 + 03:00 04:00 05:00 06:00 diff --git a/astrid/res/values-zh-rCN/strings.xml b/astrid/res/values-zh-rCN/strings.xml index cdb5b3a5b..58667c831 100644 --- a/astrid/res/values-zh-rCN/strings.xml +++ b/astrid/res/values-zh-rCN/strings.xml @@ -1623,7 +1623,7 @@ 21:00 22:00 23:00 - 24:00 + 00:00 01:00 02:00 03:00 diff --git a/astrid/res/values-zh-rTW/strings.xml b/astrid/res/values-zh-rTW/strings.xml index 3a7160307..0b7677891 100644 --- a/astrid/res/values-zh-rTW/strings.xml +++ b/astrid/res/values-zh-rTW/strings.xml @@ -1575,7 +1575,7 @@ Astrid is open-source and proudly maintained by Todoroo, Inc. 21:00 22:00 23:00 - 24:00 + 00:00 01:00 02:00 03:00 @@ -1614,7 +1614,7 @@ Astrid is open-source and proudly maintained by Todoroo, Inc. 21:00 22:00 23:00 - 24:00 + 00:00 01:00 02:00 03:00 @@ -1642,7 +1642,7 @@ Astrid is open-source and proudly maintained by Todoroo, Inc. 21:00 22:00 23:00 - 24:00 + 00:00 01:00 02:00 03:00 From 9165b19fdd953a088f1f43a98583119755d65484 Mon Sep 17 00:00:00 2001 From: Arne Jans Date: Thu, 27 Oct 2011 00:19:19 +0200 Subject: [PATCH 4/5] Fixed the crittercism-crashes on the ActFmLoginActivity during screen-rotation. I configured this activity to not re-create itself after orientation change. See also this link for further description (approach no. 4): http://blog.doityourselfandroid.com/2010/11/14/handling-progress-dialogs-and-screen-orientation-changes/ --- astrid/AndroidManifest.xml | 3 ++- .../com/todoroo/astrid/actfm/ActFmLoginActivity.java | 11 +++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/astrid/AndroidManifest.xml b/astrid/AndroidManifest.xml index df649b261..d64293c7c 100644 --- a/astrid/AndroidManifest.xml +++ b/astrid/AndroidManifest.xml @@ -308,7 +308,8 @@ - + Date: Thu, 27 Oct 2011 01:31:57 +0200 Subject: [PATCH 5/5] Fixed the crittercism-NullPointerException for quickadding a task in a list without a name. I couldnt reproduce this myself, couldnt produce a list without a name (null-value in TagData.NAME) but this should fix it nevertheless. --- .../plugin-src/com/todoroo/astrid/actfm/TagViewActivity.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/astrid/plugin-src/com/todoroo/astrid/actfm/TagViewActivity.java b/astrid/plugin-src/com/todoroo/astrid/actfm/TagViewActivity.java index c94b0ff29..e2186d569 100644 --- a/astrid/plugin-src/com/todoroo/astrid/actfm/TagViewActivity.java +++ b/astrid/plugin-src/com/todoroo/astrid/actfm/TagViewActivity.java @@ -478,7 +478,8 @@ public class TagViewActivity extends TaskListActivity { @Override protected Task quickAddTask(String title, boolean selectNewTask) { - if(tagData.getValue(TagData.NAME).length() == 0) { + if(!tagData.containsNonNullValue(TagData.NAME) || + tagData.getValue(TagData.NAME).length() == 0) { DialogUtilities.okDialog(this, getString(R.string.tag_no_title_error), null); return null; }