archive
/
tasks
mirror of https://github.com/tasks/tasks
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

A/B test hiding the plus button for new users

Browse Source
pull/14/head
Sam Bosley 11 years ago
parent fc868963f1
commit 67641ec392
8 changed files with 31 additions and 3 deletions
Show Stats Download Patch File Download Diff File

2
astrid/res/values/keys.xml
Unescape Escape View File

@ -281,6 +281,8 @@
<string name="p_use_date_shortcuts">p_use_date_shortcuts</string>
<string name="p_hide_plus_button">p_hide_plus_button</string>
<!-- Configurations -->
<string name="p_configurations">p_configurations</string>
<string name="p_config_default">p_config_default</string>

3
astrid/res/values/strings-core.xml
Unescape Escape View File

@ -746,6 +746,9 @@
<!-- Preference: simple input box style -->
<string name="EPr_show_quickadd_controls">Advanced quickadd controls</string>
<!-- Preference: don't show plus button until input present -->
<string name="EPr_hide_plus_button">Hide plus button</string>
<!-- Preference: menu items -->
<string name="EPr_menu_items">Menu items</string>

5
astrid/res/xml/preferences.xml
Unescape Escape View File

@ -156,6 +156,11 @@
android:title="@string/EPr_show_quickadd_controls"
android:defaultValue="true" />
<com.todoroo.astrid.ui.MultilineCheckboxPreference
android:key="@string/p_hide_plus_button"
android:title="@string/EPr_hide_plus_button"
android:defaultValue="false"/>
<CheckBoxPreference
android:key="@string/p_swipe_lists_enabled"
android:title="@string/EPr_swipe_lists_performance_title"

2
astrid/src/com/todoroo/astrid/activity/EditPreferences.java
Unescape Escape View File

@ -646,6 +646,8 @@ public class EditPreferences extends TodorooPreferenceActivity {
findPreference(getString(R.string.p_fontSize)).setOnPreferenceChangeListener(new SetResultOnPreferenceChangeListener(RESULT_CODE_PERFORMANCE_PREF_CHANGED));
findPreference(getString(R.string.p_hide_plus_button)).setOnPreferenceChangeListener(new SetResultOnPreferenceChangeListener(RESULT_CODE_PERFORMANCE_PREF_CHANGED));
findPreference(getString(R.string.p_config_default)).setOnPreferenceClickListener(
new SetDefaultsClickListener(new AstridDefaultPreferenceSpec(), R.string.EPr_config_dialog_default_id, StatisticsConstants.PREFS_RESET_DEFAULT));

5
astrid/src/com/todoroo/astrid/service/abtesting/ABTests.java
Unescape Escape View File

@ -137,6 +137,9 @@ public class ABTests {
}
private void initialize() {
//
addTest(AB_HIDE_PLUS_BUTTON, new int[] { 1, 1 }, new int[] { 1, 0 },
new String[] { "plus-button-shown", "plus-button-hidden" }, true); //$NON-NLS-1$ //$NON-NLS-2$
}
public static final String AB_HIDE_PLUS_BUTTON = "android-hide-plus-button"; //$NON-NLS-1$
}

9
astrid/src/com/todoroo/astrid/ui/QuickAddBar.java
Unescape Escape View File

@ -143,12 +143,16 @@ public class QuickAddBar extends LinearLayout {
quickAddBox.addTextChangedListener(new TextWatcher() {
@Override
public void onTextChanged(CharSequence s, int start, int before, int count) {
final boolean visible = !TextUtils.isEmpty(s) && quickAddBox.hasFocus();
final boolean controlsVisible = !TextUtils.isEmpty(s) && quickAddBox.hasFocus();
final boolean showControls = Preferences.getBoolean(R.string.p_show_quickadd_controls, true);
final boolean plusVisible = !TextUtils.isEmpty(s);
final boolean hidePlus = Preferences.getBoolean(R.string.p_hide_plus_button, false);
quickAddControlsContainer.postDelayed(new Runnable() {
@Override
public void run() {
quickAddControlsContainer.setVisibility((showControls && visible) ? View.VISIBLE : View.GONE);
quickAddButton.setVisibility((plusVisible || !hidePlus) ? View.VISIBLE : View.GONE);
quickAddControlsContainer.setVisibility((showControls && controlsVisible) ? View.VISIBLE : View.GONE);
}
}, 10);
}
@ -165,6 +169,7 @@ public class QuickAddBar extends LinearLayout {
quickAddButton = ((ImageButton) findViewById(
R.id.quickAddButton));
quickAddButton.setVisibility(Preferences.getBoolean(R.string.p_hide_plus_button, false) ? View.GONE : View.VISIBLE);
// set listener for quick add button
quickAddButton.setOnClickListener(new OnClickListener() {

4
astrid/src/com/todoroo/astrid/utility/AstridDefaultPreferenceSpec.java
Unescape Escape View File

@ -12,6 +12,8 @@ import com.todoroo.astrid.activity.BeastModePreferences;
import com.todoroo.astrid.core.SortHelper;
import com.todoroo.astrid.data.Task;
import com.todoroo.astrid.service.ThemeService;
import com.todoroo.astrid.service.abtesting.ABChooser;
import com.todoroo.astrid.service.abtesting.ABTests;
public class AstridDefaultPreferenceSpec extends AstridPreferenceSpec {
@ -132,6 +134,8 @@ public class AstridDefaultPreferenceSpec extends AstridPreferenceSpec {
setPreference(prefs, editor, r, R.string.p_save_and_cancel, false, ifUnset);
setPreference(prefs, editor, r, R.string.p_hide_plus_button, ABChooser.readChoiceForTest(ABTests.AB_HIDE_PLUS_BUTTON) > 0, ifUnset);
extras.setExtras(context, prefs, editor, r, ifUnset);
editor.commit();

4
astrid/src/com/todoroo/astrid/utility/AstridLitePreferenceSpec.java
Unescape Escape View File

@ -12,6 +12,8 @@ import com.todoroo.astrid.activity.BeastModePreferences;
import com.todoroo.astrid.core.SortHelper;
import com.todoroo.astrid.data.Task;
import com.todoroo.astrid.service.ThemeService;
import com.todoroo.astrid.service.abtesting.ABChooser;
import com.todoroo.astrid.service.abtesting.ABTests;
import com.todoroo.astrid.utility.AstridDefaultPreferenceSpec.PreferenceExtras;
public class AstridLitePreferenceSpec extends AstridPreferenceSpec {
@ -119,6 +121,8 @@ public class AstridLitePreferenceSpec extends AstridPreferenceSpec {
setPreference(prefs, editor, r, R.string.p_use_date_shortcuts, false, ifUnset);
setPreference(prefs, editor, r, R.string.p_save_and_cancel, false, ifUnset);
setPreference(prefs, editor, r, R.string.p_hide_plus_button, ABChooser.readChoiceForTest(ABTests.AB_HIDE_PLUS_BUTTON) > 0, ifUnset);
extras.setExtras(context, prefs, editor, r, ifUnset);

Write Preview
Loading…
Cancel
Save