From 64040f20f3f966ff53d7c26c33b9344ae4d177f2 Mon Sep 17 00:00:00 2001
From: Tim Su <tim@todoroo.com>
Date: Mon, 9 Aug 2010 15:43:22 -0700
Subject: [PATCH] added a little view separator to addons page

---
 astrid/res/layout/gcal_control.xml                |  6 ++++++
 astrid/res/layout/timer_control.xml               |  8 +++++++-
 .../todoroo/astrid/activity/TaskEditActivity.java | 15 ---------------
 3 files changed, 13 insertions(+), 16 deletions(-)

diff --git a/astrid/res/layout/gcal_control.xml b/astrid/res/layout/gcal_control.xml
index 96c68ccf3..37596e5de 100644
--- a/astrid/res/layout/gcal_control.xml
+++ b/astrid/res/layout/gcal_control.xml
@@ -34,6 +34,12 @@
         android:visibility="gone" />
 
     </LinearLayout>
+
+    <View
+        android:layout_width="fill_parent"
+        android:layout_height="1dip"
+        android:padding="5dip"
+        android:background="@android:drawable/divider_horizontal_dark" />
   
 </merge>
 
diff --git a/astrid/res/layout/timer_control.xml b/astrid/res/layout/timer_control.xml
index ba181ca83..e6a123289 100644
--- a/astrid/res/layout/timer_control.xml
+++ b/astrid/res/layout/timer_control.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- See the file "LICENSE" for the full license governing this code. -->
 <merge xmlns:android="http://schemas.android.com/apk/res/android">
-    
+        
     <!-- estimated time -->
     <TextView
       android:layout_width="wrap_content"
@@ -23,6 +23,12 @@
       android:id="@+id/elapsedDuration"
       android:layout_width="fill_parent"
       android:layout_height="wrap_content" />
+
+    <View
+        android:layout_width="fill_parent"
+        android:layout_height="1dip"
+        android:padding="5dip"
+        android:background="@android:drawable/divider_horizontal_dark" />
   
 </merge>
 
diff --git a/astrid/src/com/todoroo/astrid/activity/TaskEditActivity.java b/astrid/src/com/todoroo/astrid/activity/TaskEditActivity.java
index 4d8eedd01..6289471f5 100644
--- a/astrid/src/com/todoroo/astrid/activity/TaskEditActivity.java
+++ b/astrid/src/com/todoroo/astrid/activity/TaskEditActivity.java
@@ -36,13 +36,11 @@ import android.content.DialogInterface.OnCancelListener;
 import android.content.Intent;
 import android.content.IntentFilter;
 import android.content.res.Resources;
-import android.graphics.Color;
 import android.os.Bundle;
 import android.view.LayoutInflater;
 import android.view.Menu;
 import android.view.MenuItem;
 import android.view.View;
-import android.view.ViewGroup;
 import android.view.ViewGroup.LayoutParams;
 import android.widget.AdapterView;
 import android.widget.AdapterView.OnItemSelectedListener;
@@ -219,9 +217,7 @@ public final class TaskEditActivity extends TabActivity {
         LinearLayout addonsAddons = (LinearLayout) findViewById(R.id.tab_addons_addons);
         if(addOnService.hasPowerPack()) {
             controls.add(new GCalControlSet(this, addonsAddons));
-            separator(addonsAddons);
             controls.add(new TimerControlSet(this, addonsAddons));
-            separator(addonsAddons);
             controls.add(new AlarmControlSet(this, addonsAddons));
         }
 
@@ -249,17 +245,6 @@ public final class TaskEditActivity extends TabActivity {
         setUpListeners();
     }
 
-    /**
-     * Creates a separator in the view group specified
-     * @return
-     */
-    private void separator(ViewGroup parent) {
-        View view = new View(this);
-        view.setBackgroundColor(Color.RED);
-        view.setPadding(2, 3, 2, 3);
-        parent.addView(view);
-    }
-
     /**
      * @return true if task is newly created
      */