From 5aad0b95cf01d52d47be1b315ce817a3ee93cf7c Mon Sep 17 00:00:00 2001 From: Tim Su Date: Thu, 14 Jul 2011 12:59:33 -0700 Subject: [PATCH] Fix for new list activity not getting a title --- api/src/com/todoroo/astrid/api/Filter.java | 5 +++-- .../com/todoroo/astrid/actfm/TagViewActivity.java | 7 ++----- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/api/src/com/todoroo/astrid/api/Filter.java b/api/src/com/todoroo/astrid/api/Filter.java index 0d7cf0857..2570cf691 100644 --- a/api/src/com/todoroo/astrid/api/Filter.java +++ b/api/src/com/todoroo/astrid/api/Filter.java @@ -164,10 +164,11 @@ public class Filter extends FilterListItem { }; /** + * @param title * @return a filter that matches nothing */ - public static Filter emptyFilter() { - return new Filter("", "", //$NON-NLS-1$ //$NON-NLS-2$ + public static Filter emptyFilter(String title) { + return new Filter(title, title, new QueryTemplate().where(Criterion.none), null); } } diff --git a/astrid/plugin-src/com/todoroo/astrid/actfm/TagViewActivity.java b/astrid/plugin-src/com/todoroo/astrid/actfm/TagViewActivity.java index f4fc50083..5ce377114 100644 --- a/astrid/plugin-src/com/todoroo/astrid/actfm/TagViewActivity.java +++ b/astrid/plugin-src/com/todoroo/astrid/actfm/TagViewActivity.java @@ -358,11 +358,8 @@ public class TagViewActivity extends TaskListActivity implements OnTabChangeList if(tag == null && remoteId == 0 && !newTag) return; - if(newTag) { - getIntent().putExtra(TOKEN_FILTER, Filter.emptyFilter()); - setTitle(getString(R.string.tag_new_list)); - findViewById(R.id.taskListFooter).setVisibility(View.GONE); - } + if(newTag) + getIntent().putExtra(TOKEN_FILTER, Filter.emptyFilter(getString(R.string.tag_new_list))); TodorooCursor cursor = tagDataService.query(Query.select(TagData.PROPERTIES).where(Criterion.or(TagData.NAME.eq(tag), Criterion.and(TagData.REMOTE_ID.gt(0), TagData.REMOTE_ID.eq(remoteId)))));