Use clear button for deleting comments

pull/1178/head
Alex Baker 5 years ago
parent a9849d4cea
commit 5a60819fc7

@ -15,12 +15,13 @@ import android.view.ViewGroup
import android.widget.Button import android.widget.Button
import android.widget.ImageView import android.widget.ImageView
import android.widget.TextView import android.widget.TextView
import android.widget.Toast
import androidx.appcompat.app.AppCompatActivity import androidx.appcompat.app.AppCompatActivity
import androidx.lifecycle.lifecycleScope import androidx.lifecycle.lifecycleScope
import com.todoroo.andlib.utility.DateUtilities import com.todoroo.andlib.utility.DateUtilities
import com.todoroo.astrid.data.Task import com.todoroo.astrid.data.Task
import kotlinx.coroutines.* import kotlinx.coroutines.NonCancellable
import kotlinx.coroutines.launch
import kotlinx.coroutines.withContext
import org.tasks.R import org.tasks.R
import org.tasks.data.UserActivity import org.tasks.data.UserActivity
import org.tasks.data.UserActivityDao import org.tasks.data.UserActivityDao
@ -31,7 +32,6 @@ import org.tasks.locale.Locale
import org.tasks.preferences.Preferences import org.tasks.preferences.Preferences
import java.util.* import java.util.*
import javax.inject.Inject import javax.inject.Inject
import kotlin.coroutines.coroutineContext
import kotlin.math.min import kotlin.math.min
class CommentsController @Inject constructor( class CommentsController @Inject constructor(
@ -99,7 +99,7 @@ class CommentsController @Inject constructor(
setupImagePopupForCommentView(view, commentPictureView, item.pictureUri, activity) setupImagePopupForCommentView(view, commentPictureView, item.pictureUri, activity)
// delete button // delete button
val deleteBtn = view.findViewById<ImageView>(R.id.delete) val deleteBtn = view.findViewById<ImageView>(R.id.clear)
deleteBtn.setOnClickListener(){ deleteBtn.setOnClickListener(){
val builder = AlertDialog.Builder(commentsContainer!!.context) val builder = AlertDialog.Builder(commentsContainer!!.context)

@ -8,9 +8,9 @@
android:id="@+id/comment_row" android:id="@+id/comment_row"
style="@style/CommentsRow" style="@style/CommentsRow"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackground"
android:paddingRight="@dimen/widget_padding"> android:padding="@dimen/keyline_first">
<include layout="@layout/control_set_delete_button" /> <include layout="@layout/control_set_clear_button" />
<LinearLayout <LinearLayout
xmlns:tools="http://schemas.android.com/tools" xmlns:tools="http://schemas.android.com/tools"
@ -18,7 +18,7 @@
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_alignParentStart="true" android:layout_alignParentStart="true"
android:layout_toStartOf="@id/delete" android:layout_toStartOf="@id/delete"
android:padding="@dimen/keyline_first" android:paddingEnd="@dimen/keyline_first"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackground"
android:orientation="vertical"> android:orientation="vertical">

@ -1,15 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
<ImageView xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
android:id="@+id/delete"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_weight="1"
android:layout_alignParentEnd="true"
android:layout_centerInParent="true"
android:alpha="@dimen/alpha_secondary"
android:background="?attr/selectableItemBackgroundBorderless"
android:src="@drawable/ic_outline_delete_24px"
android:padding="@dimen/widget_padding"
app:tint="@color/icon_tint"
android:clickable="true" />
Loading…
Cancel
Save