From 54fbbd9b6caa13094e7af0a8baa68d8f1835add7 Mon Sep 17 00:00:00 2001 From: Alex Baker Date: Wed, 21 Aug 2013 09:49:12 -0500 Subject: [PATCH] Add braces to control flow statements --- .idea/inspectionProfiles/Project_Default.xml | 1 + .../todoroo/andlib/data/AbstractDatabase.java | 15 +- .../todoroo/andlib/data/AbstractModel.java | 150 ++++++++++------ .../andlib/data/ContentResolverDao.java | 15 +- .../com/todoroo/andlib/data/DatabaseDao.java | 29 ++- api/src/com/todoroo/andlib/data/Property.java | 9 +- api/src/com/todoroo/andlib/data/Table.java | 9 +- .../todoroo/andlib/data/TodorooCursor.java | 12 +- .../andlib/service/ContextManager.java | 6 +- .../service/DependencyInjectionService.java | 18 +- .../andlib/service/ExceptionService.java | 19 +- .../andlib/service/HttpRestClient.java | 14 +- api/src/com/todoroo/andlib/sql/DBObject.java | 19 +- api/src/com/todoroo/andlib/sql/Field.java | 9 +- api/src/com/todoroo/andlib/sql/Join.java | 3 +- api/src/com/todoroo/andlib/sql/Order.java | 5 +- api/src/com/todoroo/andlib/sql/Query.java | 42 +++-- .../com/todoroo/andlib/sql/QueryTemplate.java | 3 +- .../todoroo/andlib/sql/UnaryCriterion.java | 7 +- .../andlib/utility/AndroidUtilities.java | 155 ++++++++++------ .../todoroo/andlib/utility/DateUtilities.java | 59 +++--- .../andlib/utility/DialogUtilities.java | 15 +- api/src/com/todoroo/andlib/utility/Pair.java | 3 +- .../todoroo/andlib/utility/Preferences.java | 15 +- .../utility/TodorooPreferenceActivity.java | 15 +- api/src/com/todoroo/astrid/api/Filter.java | 24 ++- .../todoroo/astrid/api/FilterCategory.java | 5 +- .../api/FilterCategoryWithNewButton.java | 5 +- .../astrid/api/FilterWithCustomIntent.java | 3 +- api/src/com/todoroo/astrid/api/PermaSql.java | 3 +- .../com/todoroo/astrid/api/SyncAction.java | 3 +- .../com/todoroo/astrid/core/SortHelper.java | 21 ++- .../com/todoroo/astrid/data/RemoteModel.java | 26 ++- api/src/com/todoroo/astrid/data/TagData.java | 5 +- api/src/com/todoroo/astrid/data/Task.java | 20 ++- .../com/todoroo/astrid/data/TaskApiDao.java | 15 +- api/src/com/todoroo/astrid/data/User.java | 12 +- .../astrid/sync/SyncBackgroundService.java | 11 +- .../todoroo/astrid/sync/SyncContainer.java | 3 +- .../com/todoroo/astrid/sync/SyncProvider.java | 30 ++-- .../astrid/sync/SyncProviderPreferences.java | 14 +- .../astrid/sync/SyncProviderUtilities.java | 3 +- .../astrid/sync/SyncV2BackgroundService.java | 14 +- .../todoroo/astrid/sync/SyncV2Provider.java | 3 +- .../commonsware/cwac/tlv/TouchListView.java | 10 +- .../com/timsu/astrid/GCMIntentService.java | 72 +++++--- .../astrid/actfm/ActFmCameraModule.java | 27 ++- .../astrid/actfm/ActFmGoogleAuthActivity.java | 6 +- .../astrid/actfm/ActFmLoginActivity.java | 48 +++-- .../astrid/actfm/ActFmPreferences.java | 16 +- .../astrid/actfm/ActFmSyncActionExposer.java | 3 +- .../astrid/actfm/CommentsFragment.java | 20 ++- .../astrid/actfm/EditPeopleControlSet.java | 86 +++++---- .../astrid/actfm/TagCommentsFragment.java | 18 +- .../astrid/actfm/TagSettingsActivity.java | 42 +++-- .../todoroo/astrid/actfm/TagViewFragment.java | 75 +++++--- .../astrid/actfm/WaitingOnMeFragment.java | 8 +- .../astrid/actfm/sync/ActFmInvoker.java | 58 +++--- .../actfm/sync/ActFmPreferenceService.java | 38 ++-- .../astrid/actfm/sync/ActFmSyncService.java | 52 ++++-- .../astrid/actfm/sync/ActFmSyncThread.java | 32 ++-- .../actfm/sync/ActFmSyncV2Provider.java | 21 ++- .../actfm/sync/ActFmSyncWaitingPool.java | 3 +- .../actfm/sync/AstridNewSyncMigrator.java | 115 ++++++++---- .../EmptyTitleOutstandingEntryMigration.java | 3 +- .../astrid/actfm/sync/SyncUpgradePrompt.java | 12 +- .../TaskListMetadataSyncDatabaseListener.java | 5 +- .../sync/messages/AcknowledgeChange.java | 18 +- .../actfm/sync/messages/ChangesHappened.java | 50 ++++-- .../sync/messages/ClientToServerMessage.java | 26 ++- ...structOutstandingTableFromMasterTable.java | 8 +- .../astrid/actfm/sync/messages/Debug.java | 3 +- .../actfm/sync/messages/FetchHistory.java | 22 ++- .../messages/JSONChangeToPropertyVisitor.java | 11 +- .../sync/messages/JSONPayloadBuilder.java | 3 +- .../actfm/sync/messages/MakeChanges.java | 58 +++--- .../astrid/actfm/sync/messages/NameMaps.java | 58 +++--- .../actfm/sync/messages/NowBriefed.java | 35 ++-- .../messages/ReplayOutstandingEntries.java | 15 +- .../ReplayTaskListMetadataOutstanding.java | 3 +- .../sync/messages/ServerToClientMessage.java | 49 ++--- .../astrid/actfm/sync/messages/UserData.java | 3 +- .../astrid/alarms/AlarmControlSet.java | 12 +- .../astrid/alarms/AlarmDetailExposer.java | 15 +- .../todoroo/astrid/alarms/AlarmService.java | 18 +- .../alarms/AlarmTaskRepeatListener.java | 12 +- .../astrid/backup/BackupPreferences.java | 11 +- .../todoroo/astrid/backup/BackupService.java | 9 +- .../astrid/backup/FilePickerBuilder.java | 3 +- .../astrid/backup/TasksXmlExporter.java | 30 ++-- .../astrid/backup/TasksXmlImporter.java | 70 +++++--- .../calls/PhoneStateChangedReceiver.java | 15 +- .../astrid/core/CoreFilterExposer.java | 9 +- .../astrid/core/CustomFilterActivity.java | 38 ++-- .../astrid/core/CustomFilterAdapter.java | 21 ++- .../astrid/core/CustomFilterExposer.java | 14 +- .../astrid/core/DefaultsPreferences.java | 13 +- .../astrid/core/LinkActionExposer.java | 20 ++- .../astrid/core/OldTaskPreferences.java | 6 +- .../todoroo/astrid/core/PluginServices.java | 6 +- .../com/todoroo/astrid/core/SavedFilter.java | 17 +- .../astrid/files/AACRecordingActivity.java | 3 +- .../com/todoroo/astrid/files/FileExplore.java | 9 +- .../todoroo/astrid/files/FileUtilities.java | 9 +- .../todoroo/astrid/files/FilesControlSet.java | 20 ++- .../astrid/gcal/CalendarAlarmListCreator.java | 11 +- .../astrid/gcal/CalendarAlarmReceiver.java | 21 ++- .../astrid/gcal/CalendarAlarmScheduler.java | 9 +- .../astrid/gcal/CalendarReminderActivity.java | 14 +- .../astrid/gcal/CalendarStartupReceiver.java | 3 +- .../com/todoroo/astrid/gcal/Calendars.java | 36 ++-- .../todoroo/astrid/gcal/GCalControlSet.java | 24 ++- .../com/todoroo/astrid/gcal/GCalHelper.java | 26 +-- .../astrid/gcal/GCalTaskCompleteListener.java | 6 +- .../gtasks/GtasksBackgroundService.java | 3 +- .../GtasksCustomFilterCriteriaExposer.java | 3 +- .../astrid/gtasks/GtasksDetailExposer.java | 18 +- .../astrid/gtasks/GtasksFilterExposer.java | 12 +- .../astrid/gtasks/GtasksListAdder.java | 2 + .../astrid/gtasks/GtasksListFragment.java | 8 +- .../astrid/gtasks/GtasksListService.java | 17 +- .../todoroo/astrid/gtasks/GtasksMetadata.java | 6 +- .../astrid/gtasks/GtasksMetadataService.java | 19 +- .../gtasks/GtasksSyncActionExposer.java | 3 +- .../astrid/gtasks/GtasksTaskListUpdater.java | 23 ++- .../gtasks/api/GoogleTasksException.java | 3 +- .../astrid/gtasks/api/GtasksApiUtilities.java | 16 +- .../gtasks/auth/GtasksTokenValidator.java | 16 +- .../gtasks/sync/GtasksLegacyMigrator.java | 3 +- .../astrid/gtasks/sync/GtasksSyncService.java | 51 ++++-- .../gtasks/sync/GtasksSyncV2Provider.java | 46 +++-- .../astrid/locale/LocaleEditAlerts.java | 31 ++-- .../todoroo/astrid/locale/LocaleReceiver.java | 12 +- .../astrid/notes/EditNoteActivity.java | 65 ++++--- .../astrid/notes/NotesDecorationExposer.java | 6 +- .../astrid/notes/NotesDetailExposer.java | 18 +- .../com/todoroo/astrid/notes/NotesPlugin.java | 6 +- .../astrid/opencrx/OpencrxControlSet.java | 34 ++-- .../astrid/opencrx/OpencrxCoreUtils.java | 5 +- .../astrid/people/PeopleFilterExposer.java | 14 +- .../astrid/people/PeopleListFragment.java | 5 +- .../astrid/people/PersonViewFragment.java | 32 ++-- .../astrid/reminders/Notifications.java | 78 +++++--- .../reminders/ReengagementReceiver.java | 9 +- .../ReminderDebugContextActions.java | 12 +- .../astrid/reminders/ReminderDialog.java | 33 ++-- .../astrid/reminders/ReminderPreferences.java | 46 +++-- .../astrid/reminders/ReminderService.java | 65 ++++--- .../astrid/repeats/RepeatControlSet.java | 58 +++--- .../astrid/repeats/RepeatDetailExposer.java | 19 +- .../repeats/RepeatTaskCompleteListener.java | 50 ++++-- .../AstridOrderedListFragmentHelper.java | 22 ++- .../subtasks/AstridOrderedListUpdater.java | 84 ++++++--- .../OrderedMetadataListFragmentHelper.java | 25 ++- .../subtasks/OrderedMetadataListUpdater.java | 68 ++++--- .../subtasks/SubtasksFilterUpdater.java | 11 +- .../astrid/subtasks/SubtasksHelper.java | 24 ++- .../subtasks/SubtasksMetadataMigration.java | 15 +- .../astrid/subtasks/SubtasksTagUpdater.java | 6 +- .../todoroo/astrid/tags/TagCaseMigrator.java | 9 +- .../tags/TagCustomFilterCriteriaExposer.java | 3 +- .../todoroo/astrid/tags/TagDetailExposer.java | 9 +- .../todoroo/astrid/tags/TagFilterExposer.java | 28 +-- .../com/todoroo/astrid/tags/TagService.java | 33 ++-- .../todoroo/astrid/tags/TagsControlSet.java | 35 ++-- .../reusable/FeaturedListFilterExposer.java | 3 +- .../tags/reusable/FeaturedListFilterMode.java | 5 +- .../tags/reusable/FeaturedListFragment.java | 5 +- .../reusable/FeaturedTaskListFragment.java | 8 +- .../tags/reusable/ReusableTaskAdapter.java | 3 +- .../astrid/timers/TimerActionControlSet.java | 14 +- .../astrid/timers/TimerControlSet.java | 18 +- .../astrid/timers/TimerDecorationExposer.java | 6 +- .../astrid/timers/TimerFilterExposer.java | 6 +- .../todoroo/astrid/timers/TimerPlugin.java | 6 +- .../timers/TimerTaskCompleteListener.java | 6 +- .../com/timsu/astrid/data/Identifier.java | 3 +- .../astrid/data/LegacyAbstractModel.java | 63 ++++--- .../astrid/data/alerts/AlertController.java | 6 +- .../astrid/data/enums/RepeatInterval.java | 5 +- .../astrid/data/sync/SyncDataController.java | 15 +- .../astrid/data/tag/AbstractTagModel.java | 7 +- .../timsu/astrid/data/tag/TagController.java | 46 +++-- .../astrid/data/tag/TagModelForView.java | 5 +- .../astrid/data/task/AbstractTaskModel.java | 91 ++++++---- .../astrid/data/task/TaskController.java | 56 ++++-- .../data/task/TaskModelForHandlers.java | 12 +- .../astrid/data/task/TaskModelForList.java | 25 +-- .../utilities/LegacyTasksXmlExporter.java | 3 +- .../astrid/activity/AddOnActivity.java | 22 ++- .../astrid/activity/AstridActivity.java | 45 +++-- .../astrid/activity/BeastModePreferences.java | 38 ++-- .../astrid/activity/EditPreferences.java | 105 +++++++---- .../src/com/todoroo/astrid/activity/Eula.java | 12 +- .../astrid/activity/FilterListFragment.java | 44 +++-- .../astrid/activity/ShareLinkActivity.java | 3 +- .../astrid/activity/ShortcutActivity.java | 46 +++-- .../activity/SortSelectionActivity.java | 57 +++--- .../astrid/activity/TaskEditActivity.java | 17 +- .../astrid/activity/TaskEditFragment.java | 129 ++++++++----- .../astrid/activity/TaskEditViewPager.java | 12 +- .../astrid/activity/TaskListActivity.java | 153 ++++++++++------ .../astrid/activity/TaskListFragment.java | 160 +++++++++++------ .../todoroo/astrid/adapter/AddOnAdapter.java | 5 +- .../todoroo/astrid/adapter/FilterAdapter.java | 40 +++-- .../todoroo/astrid/adapter/TaskAdapter.java | 169 +++++++++++------- .../adapter/TaskListFragmentPagerAdapter.java | 12 +- .../todoroo/astrid/adapter/UpdateAdapter.java | 163 ++++++++++------- .../billing/AstridPurchaseObserver.java | 6 +- .../astrid/billing/BillingActivity.java | 6 +- .../astrid/billing/BillingService.java | 3 +- .../todoroo/astrid/dao/ABTestEventDao.java | 15 +- .../src/com/todoroo/astrid/dao/Database.java | 15 +- .../com/todoroo/astrid/dao/HistoryDao.java | 6 +- .../com/todoroo/astrid/dao/MetadataDao.java | 9 +- .../todoroo/astrid/dao/RemoteModelDao.java | 11 +- .../todoroo/astrid/dao/TagMetadataDao.java | 36 ++-- .../todoroo/astrid/dao/TaskAttachmentDao.java | 5 +- .../src/com/todoroo/astrid/dao/TaskDao.java | 47 +++-- .../astrid/dao/TaskListMetadataDao.java | 6 +- .../todoroo/astrid/dao/UserActivityDao.java | 6 +- .../todoroo/astrid/helper/AsyncImageView.java | 6 +- .../helper/ProgressBarSyncResultCallback.java | 3 +- .../astrid/helper/SyncActionHelper.java | 11 +- .../helper/TaskAdapterAddOnManager.java | 25 ++- .../astrid/helper/TaskEditControlSet.java | 9 +- .../astrid/legacy/LegacyRepeatInfo.java | 3 +- .../astrid/provider/Astrid2TaskProvider.java | 40 +++-- .../provider/Astrid3ContentProvider.java | 16 +- .../todoroo/astrid/service/AddOnService.java | 43 +++-- .../service/Astrid2To3UpgradeHelper.java | 51 ++++-- .../service/AstridDependencyInjector.java | 6 +- .../astrid/service/GlobalEventReceiver.java | 3 +- .../astrid/service/MetadataService.java | 12 +- .../astrid/service/PremiumUnlockService.java | 5 +- .../astrid/service/StartupService.java | 28 ++- .../astrid/service/StatisticsService.java | 26 ++- .../todoroo/astrid/service/SyncV2Service.java | 13 +- .../astrid/service/TagDataService.java | 55 +++--- .../todoroo/astrid/service/TaskService.java | 68 ++++--- .../todoroo/astrid/service/ThemeService.java | 50 +++--- .../service/UpdateMessagePreference.java | 9 +- .../astrid/service/UpdateMessageService.java | 59 +++--- .../astrid/service/UpdateScreenFlow.java | 3 +- .../astrid/service/UpgradeService.java | 70 +++++--- .../astrid/service/abtesting/ABChooser.java | 13 +- .../ABTestEventReportingService.java | 20 ++- .../service/abtesting/ABTestInvoker.java | 6 +- .../astrid/service/abtesting/ABTests.java | 5 +- .../com/todoroo/astrid/ui/AstridDialog.java | 3 +- .../todoroo/astrid/ui/AstridTimePicker.java | 17 +- .../com/todoroo/astrid/ui/CalendarView.java | 17 +- .../todoroo/astrid/ui/ContactListAdapter.java | 22 ++- .../astrid/ui/ContactsAutoComplete.java | 11 +- .../todoroo/astrid/ui/DateAndTimeDialog.java | 14 +- .../todoroo/astrid/ui/DateAndTimePicker.java | 28 +-- .../todoroo/astrid/ui/DateChangedAlerts.java | 28 +-- .../todoroo/astrid/ui/DeadlineControlSet.java | 2 + .../astrid/ui/DeadlineTimePickerDialog.java | 5 +- .../todoroo/astrid/ui/DraggableListView.java | 44 +++-- .../astrid/ui/EditNotesControlSet.java | 5 +- .../astrid/ui/EditTitleControlSet.java | 8 +- .../todoroo/astrid/ui/FragmentPopover.java | 3 +- .../astrid/ui/HideUntilControlSet.java | 22 ++- .../astrid/ui/ImportanceControlSet.java | 18 +- .../todoroo/astrid/ui/MainMenuPopover.java | 23 ++- .../astrid/ui/NNumberPickerDialog.java | 8 +- .../com/todoroo/astrid/ui/NumberPicker.java | 9 +- .../todoroo/astrid/ui/PeopleContainer.java | 60 ++++--- .../todoroo/astrid/ui/PopupControlSet.java | 21 ++- .../com/todoroo/astrid/ui/QuickAddBar.java | 29 +-- .../astrid/ui/RandomReminderControlSet.java | 18 +- .../todoroo/astrid/ui/ReminderControlSet.java | 37 ++-- .../astrid/ui/TaskListFragmentPager.java | 12 +- .../astrid/ui/TimeDurationControlSet.java | 15 +- .../ui/TouchInterceptingFrameLayout.java | 3 +- .../astrid/utility/AstridPreferenceSpec.java | 15 +- .../astrid/utility/AstridPreferences.java | 16 +- .../astrid/utility/ResourceDrawableCache.java | 27 ++- .../astrid/utility/SyncMetadataService.java | 23 ++- .../todoroo/astrid/utility/TitleParser.java | 57 +++--- .../astrid/voice/VoiceInputAssistant.java | 26 +-- .../astrid/voice/VoiceOutputService.java | 6 +- .../todoroo/astrid/voice/VoiceRecognizer.java | 15 +- .../astrid/welcome/HelpInfoPopover.java | 9 +- .../welcome/tutorial/WelcomeWalkthrough.java | 12 +- .../todoroo/astrid/widget/TasksWidget.java | 52 ++++-- .../astrid/widget/WidgetConfigActivity.java | 6 +- 288 files changed, 4488 insertions(+), 2484 deletions(-) diff --git a/.idea/inspectionProfiles/Project_Default.xml b/.idea/inspectionProfiles/Project_Default.xml index 5bec54801..3f66edad8 100644 --- a/.idea/inspectionProfiles/Project_Default.xml +++ b/.idea/inspectionProfiles/Project_Default.xml @@ -2,6 +2,7 @@