From 54e9b707ac189999e0237f2cca3256276fa555ff Mon Sep 17 00:00:00 2001 From: Sam Bosley Date: Thu, 13 Sep 2012 10:52:01 -0700 Subject: [PATCH] Record statistics for some preference changes --- .../com/todoroo/astrid/activity/EditPreferences.java | 11 +++++++++++ .../todoroo/astrid/service/StatisticsConstants.java | 2 ++ 2 files changed, 13 insertions(+) diff --git a/astrid/src/com/todoroo/astrid/activity/EditPreferences.java b/astrid/src/com/todoroo/astrid/activity/EditPreferences.java index 4b5c4e04a..4f15ef673 100644 --- a/astrid/src/com/todoroo/astrid/activity/EditPreferences.java +++ b/astrid/src/com/todoroo/astrid/activity/EditPreferences.java @@ -481,6 +481,9 @@ public class EditPreferences extends TodorooPreferenceActivity { preference.setOnPreferenceChangeListener(new SetResultOnPreferenceChangeListener(RESULT_CODE_PERFORMANCE_PREF_CHANGED) { @Override public boolean onPreferenceChange(Preference p, Object newValue) { + String valueString = newValue.toString(); + StatisticsService.reportEvent(StatisticsConstants.PREF_CHANGED_PREFIX + "row-style", //$NON-NLS-1$ + "changed-to", valueString); //$NON-NLS-1$ Preference notes = findPreference(getString(R.string.p_showNotes)); notes.setEnabled(!(Boolean) newValue); return super.onPreferenceChange(p, newValue); @@ -675,6 +678,14 @@ public class EditPreferences extends TodorooPreferenceActivity { return true; } }); + + findPreference(getString(R.string.p_fullTaskTitle)).setOnPreferenceChangeListener(new OnPreferenceChangeListener() { + @Override + public boolean onPreferenceChange(Preference preference, Object newValue) { + StatisticsService.reportEvent(StatisticsConstants.PREF_CHANGED_PREFIX + "full-title", "full-title", newValue.toString()); //$NON-NLS-1$ //$NON-NLS-2$ + return true; + } + }); } private void onVoiceReminderStatusChanged(final Preference preference, boolean newValue) { diff --git a/astrid/src/com/todoroo/astrid/service/StatisticsConstants.java b/astrid/src/com/todoroo/astrid/service/StatisticsConstants.java index 5f978e019..ddb42b4c4 100644 --- a/astrid/src/com/todoroo/astrid/service/StatisticsConstants.java +++ b/astrid/src/com/todoroo/astrid/service/StatisticsConstants.java @@ -76,6 +76,8 @@ public class StatisticsConstants { public static final String PREF_SHOW_NOTES_IN_ROW = "pref-show-notes"; public static final String PREF_SHOW_FEATURED_LISTS = "pref-show-featured-lists"; + public static final String PREF_CHANGED_PREFIX = "pref-changed-"; + public static final String TASK_THREE_DAYS = "task-created-three-days"; public static final String TASK_ONE_WEEK = "task-created-one-week"; public static final String TASK_TWO_WEEKS = "task-created-two-weeks";