From 4f4b83bde3342c4a1001c6480801423ff0b62d47 Mon Sep 17 00:00:00 2001
From: Alex Baker <baker.alex@gmail.com>
Date: Tue, 29 Mar 2016 09:22:50 -0500
Subject: [PATCH] Return default if tagdata or gtask list is null

---
 .../astrid/activity/TaskListActivity.java     | 23 ++++++++++++-------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/src/main/java/com/todoroo/astrid/activity/TaskListActivity.java b/src/main/java/com/todoroo/astrid/activity/TaskListActivity.java
index c7be09d8f..beef572ea 100644
--- a/src/main/java/com/todoroo/astrid/activity/TaskListActivity.java
+++ b/src/main/java/com/todoroo/astrid/activity/TaskListActivity.java
@@ -145,9 +145,10 @@ public class TaskListActivity extends InjectingAppCompatActivity implements
             taskListFragment = newTaskListFragment(filter);
         } else {
             taskListFragment = getTaskListFragment();
-            if (taskListFragment == null) {
-                taskListFragment = newTaskListFragment(defaultFilterProvider.getDefaultFilter());
-            }
+        }
+
+        if (taskListFragment == null) {
+            taskListFragment = newTaskListFragment(defaultFilterProvider.getDefaultFilter());
         }
         loadTaskListFragment(taskListFragment);
 
@@ -234,18 +235,24 @@ public class TaskListActivity extends InjectingAppCompatActivity implements
         if (filter instanceof TagFilter) {
             TagFilter tagFilter = (TagFilter) filter;
             TagData tagData = tagDataDao.getByUuid(tagFilter.getUuid());
-            return preferences.getBoolean(R.string.p_manual_sort, false)
-                    ? SubtasksTagListFragment.newSubtasksTagListFragment(tagFilter, tagData)
-                    : TagViewFragment.newTagViewFragment(tagFilter, tagData);
+            if (tagData != null) {
+                return preferences.getBoolean(R.string.p_manual_sort, false)
+                        ? SubtasksTagListFragment.newSubtasksTagListFragment(tagFilter, tagData)
+                        : TagViewFragment.newTagViewFragment(tagFilter, tagData);
+            }
         } else if (filter instanceof GtasksFilter) {
             GtasksFilter gtasksFilter = (GtasksFilter) filter;
             GtasksList list = gtasksListService.getList(gtasksFilter.getStoreId());
-            return GtasksListFragment.newGtasksListFragment(gtasksFilter, list);
-        } else {
+            if (list != null) {
+                return GtasksListFragment.newGtasksListFragment(gtasksFilter, list);
+            }
+        } else if (filter != null) {
             return subtasksHelper.shouldUseSubtasksFragmentForFilter(filter)
                     ? SubtasksListFragment.newSubtasksListFragment(filter)
                     : TaskListFragment.newTaskListFragment(filter);
         }
+
+        return null;
     }
 
     @Override