Fix task list animations

* Update item before moving
* Retain scroll position after move
pull/699/head 5.3.5
Alex Baker 8 years ago
parent c2dae6bd53
commit 4e70c19cd9

@ -33,8 +33,8 @@ android {
defaultConfig {
testApplicationId "org.tasks.test"
applicationId "org.tasks"
versionCode 506
versionName "5.3.4"
versionCode 507
versionName "5.3.5"
targetSdkVersion 27
minSdkVersion 15
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"

@ -52,6 +52,7 @@ public class TaskListRecyclerAdapter extends RecyclerView.Adapter<ViewHolder>
private ActionMode mode = null;
private boolean dragging;
private boolean animate;
private RecyclerView recyclerView;
public TaskListRecyclerAdapter(Activity activity, TaskAdapter adapter,
ViewHolderFactory viewHolderFactory,
@ -71,6 +72,7 @@ public class TaskListRecyclerAdapter extends RecyclerView.Adapter<ViewHolder>
}
public void applyToRecyclerView(RecyclerView recyclerView) {
this.recyclerView = recyclerView;
recyclerView.setAdapter(this);
itemTouchHelper.attachToRecyclerView(recyclerView);
}
@ -242,7 +244,9 @@ public class TaskListRecyclerAdapter extends RecyclerView.Adapter<ViewHolder>
@Override
public void onMoved(int fromPosition, int toPosition) {
if (animate) {
notifyItemChanged(fromPosition);
notifyItemMoved(fromPosition, toPosition);
recyclerView.scrollToPosition(fromPosition);
} else {
notifyDataSetChanged();
}

Loading…
Cancel
Save