Billing activity should finish after dialog if billing not available, various robustness improvements to UpdateMessageService

astrid/src/com/todoroo/astrid/billing/BillingActivity.java

@@ -258,7 +258,12 @@ public class BillingActivity extends FragmentActivity {
             .setIcon(android.R.drawable.stat_sys_warning)
             .setMessage(messageId)
             .setCancelable(false)
-            .setPositiveButton(android.R.string.ok, null)
+            .setPositiveButton(android.R.string.ok, new DialogInterface.OnClickListener() {
+                @Override
+                public void onClick(DialogInterface dialog, int which) {
+                    finish();
+                }
+            })
             .setNegativeButton(R.string.subscriptions_learn_more, new DialogInterface.OnClickListener() {
                 @Override
                 public void onClick(DialogInterface dialog, int which) {

astrid/src/com/todoroo/astrid/service/UpdateMessageService.java

@@ -119,6 +119,7 @@ public class UpdateMessageService {
             textView.setTextSize(16);
             textView.setTextColor(activity.getResources().getColor(ThemeService.getDialogTextColor()));
             textView.setMovementMethod(LinkMovementMethod.getInstance());
+            textView.setPadding(10, 0, 10, 0);
             ds = new DialogShower() {
                 @Override
                 public void showDialog(Activity a) {
@@ -238,7 +239,9 @@ public class UpdateMessageService {
                     return null;
                 final ArrayList<String> screenList = new ArrayList<String>();
                 for (int i = 0; i < screens.length(); i++) {
-                    screenList.add(screens.getString(i));
+                    String screen = screens.getString(i).trim();
+                    if (!TextUtils.isEmpty(screen))
+                        screenList.add(screen);
                 }
                 return new ClickableSpan() {
                     @Override