From 49fe296a618ab34ddb66b212558db62510ad400f Mon Sep 17 00:00:00 2001
From: Alex Baker <alex@tasks.org>
Date: Tue, 6 Nov 2018 08:56:21 -0600
Subject: [PATCH] Fix tasker task creator

---
 .../com/todoroo/astrid/service/TaskCreator.java  | 16 ++++++----------
 .../tasks/locale/receiver/TaskerTaskCreator.java |  5 ++---
 2 files changed, 8 insertions(+), 13 deletions(-)

diff --git a/app/src/main/java/com/todoroo/astrid/service/TaskCreator.java b/app/src/main/java/com/todoroo/astrid/service/TaskCreator.java
index 97e10aa31..de1032b23 100644
--- a/app/src/main/java/com/todoroo/astrid/service/TaskCreator.java
+++ b/app/src/main/java/com/todoroo/astrid/service/TaskCreator.java
@@ -80,17 +80,9 @@ public class TaskCreator {
   }
 
   public Task basicQuickAddTask(String title) {
-    return createWithValues(null, title);
-  }
-
-  /**
-   * Create task from the given content values, saving it. This version doesn't need to start with a
-   * base task model.
-   */
-  public Task createWithValues(Map<String, Object> values, String title) {
     title = title.trim();
 
-    Task task = create(values, title);
+    Task task = createWithValues(null, title);
     taskDao.createNew(task);
 
     boolean gcalCreateEventEnabled =
@@ -123,7 +115,11 @@ public class TaskCreator {
     return task;
   }
 
-  private Task create(Map<String, Object> values, String title) {
+  /**
+   * Create task from the given content values, saving it. This version doesn't need to start with a
+   * base task model.
+   */
+  public Task createWithValues(Map<String, Object> values, String title) {
     Task task = new Task();
     task.setCreationDate(now());
     task.setModificationDate(now());
diff --git a/app/src/main/java/org/tasks/locale/receiver/TaskerTaskCreator.java b/app/src/main/java/org/tasks/locale/receiver/TaskerTaskCreator.java
index 52d771b68..0e536e681 100644
--- a/app/src/main/java/org/tasks/locale/receiver/TaskerTaskCreator.java
+++ b/app/src/main/java/org/tasks/locale/receiver/TaskerTaskCreator.java
@@ -30,7 +30,7 @@ public class TaskerTaskCreator {
   }
 
   public void handle(TaskCreationBundle bundle) {
-    Task task = taskCreator.createWithValues(null, bundle.getTitle());
+    Task task = taskCreator.basicQuickAddTask(bundle.getTitle());
 
     String dueDateString = bundle.getDueDate();
     if (!isNullOrEmpty(dueDateString)) {
@@ -72,8 +72,7 @@ public class TaskerTaskCreator {
 
     task.setNotes(bundle.getDescription());
 
-    taskDao.createNew(task);
-    taskDao.save(task, null); // TODO: delete me
+    taskDao.save(task);
 
     taskCreator.createTags(task);
   }