From 4865a7dedf7eb05fefb247a4f36774ecde4d4d43 Mon Sep 17 00:00:00 2001 From: Sam Bosley Date: Fri, 9 Nov 2012 17:25:29 -0800 Subject: [PATCH] AB test default edit tab --- astrid/src/com/todoroo/astrid/activity/TaskEditFragment.java | 5 ++++- astrid/src/com/todoroo/astrid/service/abtesting/ABTests.java | 5 +++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/astrid/src/com/todoroo/astrid/activity/TaskEditFragment.java b/astrid/src/com/todoroo/astrid/activity/TaskEditFragment.java index 87ca08bba..d3cbde85e 100755 --- a/astrid/src/com/todoroo/astrid/activity/TaskEditFragment.java +++ b/astrid/src/com/todoroo/astrid/activity/TaskEditFragment.java @@ -88,6 +88,8 @@ import com.todoroo.astrid.service.StatisticsConstants; import com.todoroo.astrid.service.StatisticsService; import com.todoroo.astrid.service.TaskService; import com.todoroo.astrid.service.ThemeService; +import com.todoroo.astrid.service.abtesting.ABChooser; +import com.todoroo.astrid.service.abtesting.ABTests; import com.todoroo.astrid.tags.TagsControlSet; import com.todoroo.astrid.taskrabbit.TaskRabbitControlSet; import com.todoroo.astrid.timers.TimerActionControlSet; @@ -418,7 +420,8 @@ ViewPager.OnPageChangeListener, EditNoteActivity.UpdatesChangedListener { commentsBar.setVisibility(View.VISIBLE); moreTab.setVisibility(View.VISIBLE); - if ((tabStyle & TaskEditViewPager.TAB_SHOW_MORE) > 0) { + if ((tabStyle & TaskEditViewPager.TAB_SHOW_MORE) > 0 + && ABChooser.readChoiceForTest(ABTests.AB_DEFAULT_EDIT_TAB) != 0) { setCurrentTab(TAB_VIEW_MORE); setPagerHeightForPosition(TAB_VIEW_MORE); } else { diff --git a/astrid/src/com/todoroo/astrid/service/abtesting/ABTests.java b/astrid/src/com/todoroo/astrid/service/abtesting/ABTests.java index 921e3da23..04c8a4d54 100644 --- a/astrid/src/com/todoroo/astrid/service/abtesting/ABTests.java +++ b/astrid/src/com/todoroo/astrid/service/abtesting/ABTests.java @@ -129,6 +129,8 @@ public class ABTests { public static final String AB_DRAG_DROP = "android_drag_drop"; //$NON-NLS-1$ + public static final String AB_DEFAULT_EDIT_TAB = "android_default_edit_tab"; //$NON-NLS-1$ + private void initialize() { addTest(AB_FEATURED_LISTS, new int[] { 1, 1 }, @@ -145,5 +147,8 @@ public class ABTests { addTest(AB_DRAG_DROP, new int[] { 3, 1 }, new int[] { 1, 0 }, new String[] { "off-by-default", "on-by-default" }); //$NON-NLS-1$ //$NON-NLS-2$ + + addTest(AB_DEFAULT_EDIT_TAB, new int[] { 1, 1 }, + new int[] { 1, 1 }, new String[] { "activity-tab", "details-tab" }); //$NON-NLS-1$ //$NON-NLS-2$ } }