Make the edit tab text color the right color. Get rid of empty activities. You know, polish stuff

astrid/plugin-src/com/todoroo/astrid/notes/EditNoteActivity.java

@@ -162,9 +162,12 @@ public class EditNoteActivity extends LinearLayout implements TimerActionListene
         commentField.addTextChangedListener(new TextWatcher() {
             @Override
             public void afterTextChanged(Editable s) {
-                commentButton.setVisibility((s.length() > 0 || pendingCommentPicture != null) ? View.VISIBLE : View.GONE);
-                timerView.setVisibility((s.length() > 0 || pendingCommentPicture != null) ? View.GONE : View.VISIBLE);
+                commentButton.setVisibility((s.length() > 0 || pendingCommentPicture != null) ? View.VISIBLE
+                        : View.GONE);
+                timerView.setVisibility((s.length() > 0 || pendingCommentPicture != null) ? View.GONE
+                        : View.VISIBLE);
             }
+
             @Override
             public void beforeTextChanged(CharSequence s, int start, int count, int after) {
                 //
@@ -221,11 +224,10 @@ public class EditNoteActivity extends LinearLayout implements TimerActionListene
             notes.setPadding(5, 10, 5, 10);
             Linkify.addLinks(notes, Linkify.ALL);
         }
+
         //TODO add loading text back in
         //        loadingText = (TextView) findViewById(R.id.loading);
         loadingText = new TextView(getContext());
-
-
     }
 
     private void setUpListAdapter() {
@@ -252,7 +254,9 @@ public class EditNoteActivity extends LinearLayout implements TimerActionListene
                 Update update = new Update();
                 for(updates.moveToFirst(); !updates.isAfterLast(); updates.moveToNext()) {
                     update.readFromCursor(updates);
-                    items.add(NoteOrUpdate.fromUpdate(update));
+                    NoteOrUpdate noa = NoteOrUpdate.fromUpdate(update);
+                    if(noa != null)
+                        items.add(noa);
                 }
             } finally {
                 updates.close();
@@ -509,6 +513,10 @@ public class EditNoteActivity extends LinearLayout implements TimerActionListene
                 description += " " + message;
             else
                 description = message;
+
+            if(TextUtils.isEmpty(description))
+                return null;
+
             String commentPicture = u.getValue(Update.PICTURE);
 
             return new NoteOrUpdate(user.optString("picture"),
@@ -565,8 +573,8 @@ public class EditNoteActivity extends LinearLayout implements TimerActionListene
             }
         };
 
-        return (ActFmCameraModule.activityResult((Activity)getContext(), requestCode, resultCode, data, callback));
-        //Handled
+        return (ActFmCameraModule.activityResult((Activity)getContext(),
+                requestCode, resultCode, data, callback));
     }
 
 }

astrid/res/layout/task_edit_activity.xml

@@ -70,7 +70,7 @@
                 android:layout_width="fill_parent"
                 android:layout_height="fill_parent"
                 android:orientation="vertical"
-                android:visibility="gone" >
+                android:visibility="gone">
 -                 
 
                 <TextView

astrid/res/values/styles.xml

@@ -351,10 +351,9 @@
     
     <style name="CustomTabPageIndicator" parent="Widget.TabPageIndicator">
         <item name="android:background">?attr/asEditTabBackground</item>
-        <item name="android:textColor">#FFFF00FF</item>
     </style>
     <style name="CustomTabPageIndicator.Text" parent="Widget.TabPageIndicator.Text">
-        <item name="android:textColor">#FF00FF00</item>
+        <item name="android:textColor">?attr/asTextColor</item>                                                                                                                                                              
         <item name="android:textSize">15sp</item>
         <item name="android:textStyle">bold</item>
         <item name="android:layout_marginLeft">5dip</item>

viewPagerIndicator/library/res/layout/vpi__tab.xml

@@ -8,5 +8,6 @@
         android:id="@android:id/text1"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
+        style="?attr/vpiTabTextStyle"
         android:gravity="center" />
 </view>