From 44ef49979d4635ca1e7ff8a96b99b7b80a756d6d Mon Sep 17 00:00:00 2001 From: Sam Bosley Date: Wed, 19 Dec 2012 17:21:55 -0800 Subject: [PATCH] Record statistic about how many people reset the preference defaults --- .../src/com/todoroo/astrid/activity/EditPreferences.java | 9 ++++++--- .../com/todoroo/astrid/service/StatisticsConstants.java | 2 ++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/astrid/src/com/todoroo/astrid/activity/EditPreferences.java b/astrid/src/com/todoroo/astrid/activity/EditPreferences.java index e481379a3..1ffdd69f5 100644 --- a/astrid/src/com/todoroo/astrid/activity/EditPreferences.java +++ b/astrid/src/com/todoroo/astrid/activity/EditPreferences.java @@ -127,9 +127,11 @@ public class EditPreferences extends TodorooPreferenceActivity { private class SetDefaultsClickListener implements OnPreferenceClickListener { private final AstridPreferenceSpec spec; private final int nameId; - public SetDefaultsClickListener(AstridPreferenceSpec spec, int nameId) { + private final String statistic; + public SetDefaultsClickListener(AstridPreferenceSpec spec, int nameId, String statistic) { this.spec = spec; this.nameId = nameId; + this.statistic = statistic; } @Override @@ -139,6 +141,7 @@ public class EditPreferences extends TodorooPreferenceActivity { @Override public void onClick(DialogInterface dialog, int which) { spec.resetDefaults(); + StatisticsService.reportEvent(statistic); setResult(RESULT_CODE_PERFORMANCE_PREF_CHANGED); finish(); } @@ -671,10 +674,10 @@ public class EditPreferences extends TodorooPreferenceActivity { findPreference(getString(R.string.p_fontSize)).setOnPreferenceChangeListener(new SetResultOnPreferenceChangeListener(RESULT_CODE_PERFORMANCE_PREF_CHANGED)); findPreference(getString(R.string.p_config_default)).setOnPreferenceClickListener( - new SetDefaultsClickListener(new AstridDefaultPreferenceSpec(), R.string.EPr_config_dialog_default_id)); + new SetDefaultsClickListener(new AstridDefaultPreferenceSpec(), R.string.EPr_config_dialog_default_id, StatisticsConstants.PREFS_RESET_DEFAULT)); findPreference(getString(R.string.p_config_lite)).setOnPreferenceClickListener( - new SetDefaultsClickListener(new AstridLitePreferenceSpec(), R.string.EPr_config_lite)); + new SetDefaultsClickListener(new AstridLitePreferenceSpec(), R.string.EPr_config_lite, StatisticsConstants.PREFS_RESET_LITE)); int[] menuPrefs = { R.string.p_show_menu_search, R.string.p_show_menu_friends, R.string.p_show_featured_lists, R.string.p_show_menu_sync, R.string.p_show_menu_sort, R.string.p_show_menu_addons diff --git a/astrid/src/com/todoroo/astrid/service/StatisticsConstants.java b/astrid/src/com/todoroo/astrid/service/StatisticsConstants.java index 5ace0b397..e918ef7c8 100644 --- a/astrid/src/com/todoroo/astrid/service/StatisticsConstants.java +++ b/astrid/src/com/todoroo/astrid/service/StatisticsConstants.java @@ -78,6 +78,8 @@ public class StatisticsConstants { public static final String PREMIUM_PAGE_VIEWED = "premium-page-viewed"; public static final String FEATURED_LIST_CLONED = "featured-list-cloned"; public static final String RANDOM_REMINDER_SAVED = "random-rmdr-save"; + public static final String PREFS_RESET_DEFAULT = "prefs-reset-default"; + public static final String PREFS_RESET_LITE = "prefs-reset-lite"; public static final String ACTFM_LOGIN_SIMPLE = "actfm-login-simple"; public static final String ACTFM_LOGIN_SIMPLE_REJECTED = "actfm-login-simple-rejected";