requery was always true

astrid/src/main/java/com/todoroo/astrid/actfm/TagViewFragment.java

@@ -154,8 +154,8 @@ public class TagViewFragment extends TaskListFragment {
     }
 
     @Override
-    public void loadTaskListContent(boolean requery) {
-        super.loadTaskListContent(requery);
+    public void loadTaskListContent() {
+        super.loadTaskListContent();
         if(taskAdapter == null || taskAdapter.getCursor() == null) {
             return;
         }
@@ -263,8 +263,7 @@ public class TagViewFragment extends TaskListFragment {
 
     @Override
     protected void refresh() {
-        loadTaskListContent(true);
+        loadTaskListContent();
         ((TextView)taskListView.findViewById(android.R.id.empty)).setText(R.string.TLA_no_items);
     }
-
 }

astrid/src/main/java/com/todoroo/astrid/activity/AstridActivity.java

@@ -238,7 +238,7 @@ public class AstridActivity extends InjectingActionBarActivity
 
             TaskListFragment tlf = getTaskListFragment();
             if (tlf != null) {
-                tlf.loadTaskListContent(true);
+                tlf.loadTaskListContent();
             }
 
         } else {

astrid/src/main/java/com/todoroo/astrid/activity/TaskListFragment.java

@@ -605,7 +605,7 @@ public class TaskListFragment extends InjectingListFragment implements OnSortSel
             taskAdapter.flushCaches();
         }
         taskDeleter.deleteTasksWithEmptyTitles();
-        loadTaskListContent(true);
+        loadTaskListContent();
     }
 
     /**
@@ -659,7 +659,7 @@ public class TaskListFragment extends InjectingListFragment implements OnSortSel
     /**
      * Load or re-load action items and update views
      */
-    public void loadTaskListContent(boolean requery) {
+    public void loadTaskListContent() {
         if (taskAdapter == null) {
             setUpTaskList();
             return;
@@ -667,11 +667,9 @@ public class TaskListFragment extends InjectingListFragment implements OnSortSel
 
         Cursor taskCursor = taskAdapter.getCursor();
 
-        if (requery) {
-            taskCursor.requery();
-            taskAdapter.flushCaches();
-            taskAdapter.notifyDataSetChanged();
-        }
+        taskCursor.requery();
+        taskAdapter.flushCaches();
+        taskAdapter.notifyDataSetChanged();
 
         if (getView() != null) { // This was happening sometimes
             int oldListItemSelected = getListView().getSelectedItemPosition();
@@ -732,7 +730,7 @@ public class TaskListFragment extends InjectingListFragment implements OnSortSel
         setListAdapter(taskAdapter);
         registerForContextMenu(getListView());
 
-        loadTaskListContent(true);
+        loadTaskListContent();
     }
 
     public Property<?>[] taskProperties() {
@@ -854,7 +852,7 @@ public class TaskListFragment extends InjectingListFragment implements OnSortSel
                     public void onClick(DialogInterface dialog, int which) {
                         onTaskDelete(task);
                         taskDeleter.delete(task);
-                        loadTaskListContent(true);
+                        loadTaskListContent();
                     }
                 }).setNegativeButton(android.R.string.cancel, null).show();
     }
@@ -928,7 +926,7 @@ public class TaskListFragment extends InjectingListFragment implements OnSortSel
             task.setId(itemId);
             task.setDeletionDate(0L);
             taskService.save(task);
-            loadTaskListContent(true);
+            loadTaskListContent();
             return true;
         }
         case CONTEXT_MENU_PURGE_TASK_ID: {
@@ -937,7 +935,7 @@ public class TaskListFragment extends InjectingListFragment implements OnSortSel
             task.setId(itemId);
             TimerPlugin.updateTimer(notificationManager, taskService, getActivity(), task, false);
             taskDeleter.purge(itemId);
-            loadTaskListContent(true);
+            loadTaskListContent();
             return true;
         }
             default:

astrid/src/main/java/com/todoroo/astrid/gtasks/GtasksListFragment.java

@@ -158,7 +158,7 @@ public class GtasksListFragment extends SubtasksListFragment {
                     activity.runOnUiThread(new Runnable() {
                         @Override
                         public void run() {
-                            loadTaskListContent(true);
+                            loadTaskListContent();
                         }
                     });
                 }

astrid/src/main/java/com/todoroo/astrid/subtasks/AstridOrderedListFragmentHelper.java

@@ -115,7 +115,7 @@ public class AstridOrderedListFragmentHelper<LIST> implements OrderedListFragmen
             }
 
             fragment.reconstructCursor();
-            fragment.loadTaskListContent(true);
+            fragment.loadTaskListContent();
         }
     };
 
@@ -142,7 +142,7 @@ public class AstridOrderedListFragmentHelper<LIST> implements OrderedListFragmen
             }
 
             fragment.reconstructCursor();
-            fragment.loadTaskListContent(true);
+            fragment.loadTaskListContent();
         }
     };
 
@@ -284,7 +284,7 @@ public class AstridOrderedListFragmentHelper<LIST> implements OrderedListFragmen
     public void onCreateTask(Task task) {
         updater.onCreateTask(list, getFilter(), task.getUuid());
         fragment.reconstructCursor();
-        fragment.loadTaskListContent(true);
+        fragment.loadTaskListContent();
         fragment.selectCustomId(task.getId());
     }
 

astrid/src/main/java/com/todoroo/astrid/subtasks/OrderedMetadataListFragmentHelper.java

@@ -132,7 +132,7 @@ public class OrderedMetadataListFragmentHelper<LIST> implements OrderedListFragm
                 log.error(e.getMessage(), e);
             }
 
-            fragment.loadTaskListContent(true);
+            fragment.loadTaskListContent();
         }
     };
 
@@ -157,7 +157,7 @@ public class OrderedMetadataListFragmentHelper<LIST> implements OrderedListFragm
             } catch (Exception e) {
                 log.error(e.getMessage(), e);
             }
-            fragment.loadTaskListContent(true);
+            fragment.loadTaskListContent();
         }
     };
 

astrid/src/main/java/com/todoroo/astrid/ui/QuickAddBar.java

@@ -278,7 +278,7 @@ public class QuickAddBar extends LinearLayout {
             quickAdd.setText(""); //$NON-NLS-1$
 
             if (selectNewTask) {
-                fragment.loadTaskListContent(true);
+                fragment.loadTaskListContent();
                 fragment.selectCustomId(task.getId());
                 if (task.getTransitory(TaskService.TRANS_QUICK_ADD_MARKUP) != null) {
                     showAlertForMarkupTask(activity, task, title);