Don't save sharing settings until after we've checked that user is logged in

13 years ago · 42311c8693
parent af2ace35e8
commit 42311c8693
1 changed files with 6 additions and 5 deletions
--- a/astrid/plugin-src/com/todoroo/astrid/actfm/EditPeopleControlSet.java
+++ b/astrid/plugin-src/com/todoroo/astrid/actfm/EditPeopleControlSet.java
@ -435,17 +435,18 @@ public class EditPeopleControlSet implements TaskEditControlSet {

            JSONObject sharedWith = parseSharedWithAndTags();
            dirty = dirty || sharedWith.has("p");
+            if(dirty && !actFmPreferenceService.isLoggedIn()) {
+                activity.startActivityForResult(new Intent(activity, ActFmLoginActivity.class),
+                        loginRequestCode);
+                return false;
+            }
+
            if(!TextUtils.isEmpty(task.getValue(Task.SHARED_WITH)) || sharedWith.length() != 0)
                task.setValue(Task.SHARED_WITH, sharedWith.toString());

            if(dirty)
                taskService.save(task);

-            if(dirty && !actFmPreferenceService.isLoggedIn()) {
-                activity.startActivityForResult(new Intent(activity, ActFmLoginActivity.class),
-                        loginRequestCode);
-                return false;
-            }

            if(dirty)
                shareTask(sharedWith);