From 40b9872566085128ab9aea81f99b8a40dc7dbb29 Mon Sep 17 00:00:00 2001 From: Alex Baker Date: Wed, 23 Aug 2017 14:05:58 -0500 Subject: [PATCH] Remove vibration pattern preferences --- .../astrid/reminders/ReminderPreferences.java | 2 +- .../org/tasks/preferences/Preferences.java | 17 +-------- app/src/main/res/values-ar/strings.xml | 3 -- app/src/main/res/values-bg-rBG/strings.xml | 3 -- app/src/main/res/values-cs/strings.xml | 3 -- app/src/main/res/values-de/strings.xml | 3 -- app/src/main/res/values-es/strings.xml | 3 -- app/src/main/res/values-fa/strings.xml | 3 -- app/src/main/res/values-fi/strings.xml | 3 -- app/src/main/res/values-fr/strings.xml | 3 -- app/src/main/res/values-gl/strings.xml | 3 -- app/src/main/res/values-hu/strings.xml | 3 -- app/src/main/res/values-it/strings.xml | 3 -- app/src/main/res/values-iw/strings.xml | 3 -- app/src/main/res/values-ja/strings.xml | 3 -- app/src/main/res/values-ko/strings.xml | 3 -- app/src/main/res/values-nl/strings.xml | 3 -- app/src/main/res/values-pl/strings.xml | 3 -- app/src/main/res/values-pt-rBR/strings.xml | 3 -- app/src/main/res/values-pt/strings.xml | 1 - app/src/main/res/values-ru/strings.xml | 3 -- app/src/main/res/values-sr/strings.xml | 1 - app/src/main/res/values-sv/strings.xml | 3 -- app/src/main/res/values-tr/strings.xml | 3 -- app/src/main/res/values-uk/strings.xml | 3 -- app/src/main/res/values/arrays.xml | 15 -------- app/src/main/res/values/keys.xml | 3 -- app/src/main/res/values/strings.xml | 3 -- .../main/res/xml/preferences_reminders.xml | 38 +++---------------- 29 files changed, 8 insertions(+), 135 deletions(-) diff --git a/app/src/main/java/com/todoroo/astrid/reminders/ReminderPreferences.java b/app/src/main/java/com/todoroo/astrid/reminders/ReminderPreferences.java index b1dd106ca..099be7604 100644 --- a/app/src/main/java/com/todoroo/astrid/reminders/ReminderPreferences.java +++ b/app/src/main/java/com/todoroo/astrid/reminders/ReminderPreferences.java @@ -80,7 +80,7 @@ public class ReminderPreferences extends InjectingPreferenceActivity { requires(R.string.notification_shade, atLeastJellybean(), R.string.p_notification_priority); requires(device.supportsLocationServices(), R.string.geolocation_reminders); - requires(preOreo(), R.string.p_rmd_ringtone, R.string.p_led_notification); + requires(preOreo(), R.string.p_rmd_ringtone, R.string.p_rmd_vibrate, R.string.p_led_notification); } private void rescheduleNotificationsOnChange(int... resIds) { diff --git a/app/src/main/java/org/tasks/preferences/Preferences.java b/app/src/main/java/org/tasks/preferences/Preferences.java index 584eeca19..a29445980 100644 --- a/app/src/main/java/org/tasks/preferences/Preferences.java +++ b/app/src/main/java/org/tasks/preferences/Preferences.java @@ -7,7 +7,6 @@ import android.preference.PreferenceManager; import android.support.v4.app.NotificationCompat; import android.text.TextUtils; -import com.google.common.primitives.Longs; import com.todoroo.astrid.activity.BeastModePreferences; import com.todoroo.astrid.api.AstridApiConstants; import com.todoroo.astrid.core.SortHelper; @@ -20,8 +19,6 @@ import org.tasks.themes.ThemeCache; import org.tasks.time.DateTime; import java.io.File; -import java.util.ArrayList; -import java.util.List; import java.util.concurrent.atomic.AtomicReference; import javax.inject.Inject; @@ -92,7 +89,7 @@ public class Preferences { } public boolean isVibrationEnabled() { - return getBoolean(R.string.p_rmd_vibrate, true); + return atLeastOreo() || getBoolean(R.string.p_rmd_vibrate, true); } public boolean isLEDNotificationEnabled() { @@ -415,17 +412,7 @@ public class Preferences { } public long[] getVibrationPattern() { - int vibrationCount = getIntegerFromString(R.string.p_vibrate_count, 3); - long vibrationDuration = getIntegerFromString(R.string.p_vibrate_duration, 1000); - long vibrationPause = getIntegerFromString(R.string.p_vibrate_pause, 500); - List pattern = new ArrayList<>(vibrationCount); - pattern.add(0L); - pattern.add(vibrationDuration); - for (int i = 1 ; i < vibrationCount ; i++) { - pattern.add(vibrationPause); - pattern.add(vibrationDuration); - } - return Longs.toArray(pattern); + return new long[] {0, 333, 333, 333}; } public void remove(int resId) { diff --git a/app/src/main/res/values-ar/strings.xml b/app/src/main/res/values-ar/strings.xml index cfa431451..4415ed64d 100644 --- a/app/src/main/res/values-ar/strings.xml +++ b/app/src/main/res/values-ar/strings.xml @@ -180,9 +180,6 @@ عال الإفتراضي منخفض - عدد الإهتزازات - إمتداد الهزة - التوقف أثناء الهزات تاسكس هو مشروع مفتوح المصدر مدموع من طرف مطور واحد. بعض الخيارات متوفرة عن الطريق الدفع من داخل التطبيق من أجل دعم التطوير التعتيم المزامنة التلقائية معطلة الآن من طرف أندرويد diff --git a/app/src/main/res/values-bg-rBG/strings.xml b/app/src/main/res/values-bg-rBG/strings.xml index 2c9808cc2..e42219446 100644 --- a/app/src/main/res/values-bg-rBG/strings.xml +++ b/app/src/main/res/values-bg-rBG/strings.xml @@ -317,9 +317,6 @@ По подразбиране Нисък Приоритет на уведомления - Брой вибрации - Продължителност на всяка вибрация (милисекунди) - Пауза между вибрациите (милисекунди) Заснемане Изберете от галерия Изберете от паметта diff --git a/app/src/main/res/values-cs/strings.xml b/app/src/main/res/values-cs/strings.xml index ecc203d2f..a1f529368 100644 --- a/app/src/main/res/values-cs/strings.xml +++ b/app/src/main/res/values-cs/strings.xml @@ -280,9 +280,6 @@ Výchozí Nízká Priorita oznámení - Počet vibrací - Délka každé vibrace (ms) - Pauza mezi vibracemi (ms) Soukromí Zásady ochrany osobních údajů Vylepšit Úkoly diff --git a/app/src/main/res/values-de/strings.xml b/app/src/main/res/values-de/strings.xml index ce65b485c..dafdd6415 100644 --- a/app/src/main/res/values-de/strings.xml +++ b/app/src/main/res/values-de/strings.xml @@ -310,9 +310,6 @@ Standard Niedrig Benachrichtigungspriorität - Anzahl Vibrationen - Dauer der Vibration in Millisekunden - Pause zwischen Vibrationen in Millisekunden Bild aufnehmen Aus Galerie wählen Von Speicher auswählen diff --git a/app/src/main/res/values-es/strings.xml b/app/src/main/res/values-es/strings.xml index 7f96e824d..cd71601f5 100644 --- a/app/src/main/res/values-es/strings.xml +++ b/app/src/main/res/values-es/strings.xml @@ -313,9 +313,6 @@ Por defecto Baja Prioridad de la notificación - Número de vibraciones - Duración de cada vibración (milisegundos) - Pausa entre vibraciones (milisegundos) Tomar fotografía Elegir desde la galería Elegir desde almacenamiento diff --git a/app/src/main/res/values-fa/strings.xml b/app/src/main/res/values-fa/strings.xml index 5ebcbd9fe..b59e9c303 100644 --- a/app/src/main/res/values-fa/strings.xml +++ b/app/src/main/res/values-fa/strings.xml @@ -242,9 +242,6 @@ پیش فرض کم اولویت اعلان - تعداد لرزش ها - مدت هر لرزش (میلی‌ثانیه) - مکث بین لرزش‌ها (میلی‌ثانیه) گرفتن عکس بهبود وظیفه این تگ قبلاً ایجاد شده است diff --git a/app/src/main/res/values-fi/strings.xml b/app/src/main/res/values-fi/strings.xml index aecc31ce5..a6a3eb72c 100644 --- a/app/src/main/res/values-fi/strings.xml +++ b/app/src/main/res/values-fi/strings.xml @@ -315,9 +315,6 @@ Oletuskalenteri Matala Muistutusten tärkeysjärjestys - Värinän määrä - Värinän pituus (millisekunteina) - Tauko värinässä (millisekuntia) Ota kuva Valitse galleriasta Valitse muistista diff --git a/app/src/main/res/values-fr/strings.xml b/app/src/main/res/values-fr/strings.xml index e985fc5eb..fc3129832 100644 --- a/app/src/main/res/values-fr/strings.xml +++ b/app/src/main/res/values-fr/strings.xml @@ -307,9 +307,6 @@ Par défaut Basse Priorité de notification - Nombre de vibrations - Durée de chaque vibration (millisecondes) - Pause entre les vibrations (millisecondes) Prendre une photo Choisir depuis la galerie Choisir depuis le stockage diff --git a/app/src/main/res/values-gl/strings.xml b/app/src/main/res/values-gl/strings.xml index 92b87826e..fb38dada9 100644 --- a/app/src/main/res/values-gl/strings.xml +++ b/app/src/main/res/values-gl/strings.xml @@ -314,9 +314,6 @@ Por defecto Baixa Prioridad de la notificación - Número de vibraciones - Duración de cada vibración (milisegundos) - Pausa entre vibraciones (milisegundos) Tomar fotografía Elegir desde la galería Elegir desde almacenamiento diff --git a/app/src/main/res/values-hu/strings.xml b/app/src/main/res/values-hu/strings.xml index 058b21760..b47e7b019 100644 --- a/app/src/main/res/values-hu/strings.xml +++ b/app/src/main/res/values-hu/strings.xml @@ -317,9 +317,6 @@ Alapértelmezett Alacsony Értesítés prioritása - Rezgések száma - Rezgések hossza (ezredmásodpercben) - Szünet a rezgések között (ezredmásodpercben) Kép készítése Kiválasztás a galériából Kiválasztás a tárhelyről diff --git a/app/src/main/res/values-it/strings.xml b/app/src/main/res/values-it/strings.xml index eb8edca93..6434029bb 100644 --- a/app/src/main/res/values-it/strings.xml +++ b/app/src/main/res/values-it/strings.xml @@ -313,9 +313,6 @@ Alta Bassa Priorità avvisi - Numero di vibrazioni - Durata di ogni vibrazione (millisecondi) - Durata intervallo vibrazioni (millisecondi) Scatta un foto Scegli dalla libreria Scegli dalla memoria diff --git a/app/src/main/res/values-iw/strings.xml b/app/src/main/res/values-iw/strings.xml index a9d526bbb..f9092edb1 100644 --- a/app/src/main/res/values-iw/strings.xml +++ b/app/src/main/res/values-iw/strings.xml @@ -315,9 +315,6 @@ ברירת מחדל נמוך חשיבות ההתראה - מספר פעימות הרטט - אורך כל פעימת רטט (במילישניות) - אורך הפסקה בין פעימות רטט (במילישניות) צלם תמונה בחירה מהגלריה בחירה מאחסון diff --git a/app/src/main/res/values-ja/strings.xml b/app/src/main/res/values-ja/strings.xml index 347c3624e..a0bff4c9f 100644 --- a/app/src/main/res/values-ja/strings.xml +++ b/app/src/main/res/values-ja/strings.xml @@ -315,9 +315,6 @@ デフォルト 通知優先度 - 振動の数 - それぞれの振動の長さ (ミリ秒) - 振動の間のポーズ (ミリ秒) 写真を撮影 ギャラリーから選択 ストレージから選択 diff --git a/app/src/main/res/values-ko/strings.xml b/app/src/main/res/values-ko/strings.xml index 1d1e5c3c1..a839d4a67 100644 --- a/app/src/main/res/values-ko/strings.xml +++ b/app/src/main/res/values-ko/strings.xml @@ -319,9 +319,6 @@ 기본값 낮음 알림 우선순위 - 진동 횟수 - 진동 길이 (밀리초) - 진동 사이의 간격 (밀리초) 사진 촬영 갤러리에서 선택 저장소에서 가져오기 diff --git a/app/src/main/res/values-nl/strings.xml b/app/src/main/res/values-nl/strings.xml index 5b739ad9a..9632e6be9 100644 --- a/app/src/main/res/values-nl/strings.xml +++ b/app/src/main/res/values-nl/strings.xml @@ -310,9 +310,6 @@ Standaard Laag Notificatie prioriteit - Aantal trillingen - Lengte van elke trilling (miliseconden) - Pauze tussen trillingen (miliseconden) Maak een foto Kies uit de gallerij Kies van opslag diff --git a/app/src/main/res/values-pl/strings.xml b/app/src/main/res/values-pl/strings.xml index 8a33f0dc9..44f783ca6 100644 --- a/app/src/main/res/values-pl/strings.xml +++ b/app/src/main/res/values-pl/strings.xml @@ -314,9 +314,6 @@ Domyślne Mało ważne Priorytet powiadomienia - Powtórzenia wibracji - Długość wibracji (milisekundy) - Przerwa pomiędzy wibracjami (milisekundy) Wybierz obrazek Wybierz z galerii Wybierz z pamięci diff --git a/app/src/main/res/values-pt-rBR/strings.xml b/app/src/main/res/values-pt-rBR/strings.xml index c7f6959dd..aab9e0698 100644 --- a/app/src/main/res/values-pt-rBR/strings.xml +++ b/app/src/main/res/values-pt-rBR/strings.xml @@ -308,9 +308,6 @@ Padrão Baixa Prioridade da Notificação - Número de vibrações - Duração de cada vibração (milissegundos) - Pausa entre vibrações (milissegundos) Tirar uma foto Selecionar da galeria Privacidade diff --git a/app/src/main/res/values-pt/strings.xml b/app/src/main/res/values-pt/strings.xml index d517b1ead..6879e39e7 100644 --- a/app/src/main/res/values-pt/strings.xml +++ b/app/src/main/res/values-pt/strings.xml @@ -281,7 +281,6 @@ Reverter Compras na aplicação Adicionar anexo - Número de vibrações Privacidade Política de privacidade Lista padrão diff --git a/app/src/main/res/values-ru/strings.xml b/app/src/main/res/values-ru/strings.xml index 763e96526..ca81683f8 100644 --- a/app/src/main/res/values-ru/strings.xml +++ b/app/src/main/res/values-ru/strings.xml @@ -314,9 +314,6 @@ По умолчанию Низкий Приоритет уведомлений - Количество вибраций - Продолжительность каждой вибрации (миллисекунды) - Пауза между вибрациями (миллисекунды) Выбрать изображение Выбрать из галереи Выбрать с диска diff --git a/app/src/main/res/values-sr/strings.xml b/app/src/main/res/values-sr/strings.xml index 52bf10ca8..0dfc173bd 100644 --- a/app/src/main/res/values-sr/strings.xml +++ b/app/src/main/res/values-sr/strings.xml @@ -39,7 +39,6 @@ Visok Podrazumevano Nisak - Broj vibracija Raspored komandi Sleva nadesno Zdesna nalevo diff --git a/app/src/main/res/values-sv/strings.xml b/app/src/main/res/values-sv/strings.xml index ebc885e97..269c7b53d 100644 --- a/app/src/main/res/values-sv/strings.xml +++ b/app/src/main/res/values-sv/strings.xml @@ -311,9 +311,6 @@ Standard Låg Prioritering för påminnelser - Antal vibrationer - Längd på varje vibration (millisekunder) - Paus mellan varje vibration (millisekunder) Ta en bild Välj från album Välj från lagring diff --git a/app/src/main/res/values-tr/strings.xml b/app/src/main/res/values-tr/strings.xml index 61e941599..ad9735c03 100644 --- a/app/src/main/res/values-tr/strings.xml +++ b/app/src/main/res/values-tr/strings.xml @@ -233,9 +233,6 @@ Yüksek Varsayılan Düşük - Titreşim sayısı - Her titreşimin uzunluğu (milisaniye) - Titreşimler arasında duraklama (milisaniye) Gizlilik Gizlilik politikası Task\'ı İyileştir diff --git a/app/src/main/res/values-uk/strings.xml b/app/src/main/res/values-uk/strings.xml index d0685aa18..0a7ca4358 100644 --- a/app/src/main/res/values-uk/strings.xml +++ b/app/src/main/res/values-uk/strings.xml @@ -316,9 +316,6 @@ За замовчуванням Низький Пріоритет сповіщення - Кількість вібрацій - Довжина кожної вібрації (мілісекунди) - Пауза між вібраціями (мілісекунди) Зробити фото Обрати з галереї Обрати зі сховища diff --git a/app/src/main/res/values/arrays.xml b/app/src/main/res/values/arrays.xml index 7ec2ba1cc..5559b302a 100644 --- a/app/src/main/res/values/arrays.xml +++ b/app/src/main/res/values/arrays.xml @@ -1,21 +1,6 @@ - - 1 - 2 - 3 - 4 - 5 - - - - 250 - 500 - 750 - 1000 - - 75 125 diff --git a/app/src/main/res/values/keys.xml b/app/src/main/res/values/keys.xml index 2a9c4c3f6..c096429e3 100644 --- a/app/src/main/res/values/keys.xml +++ b/app/src/main/res/values/keys.xml @@ -41,9 +41,6 @@ notif_vibrate - vibrate_count - vibrate_duration - vibrate_pause notification_ringtone diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index d3e061cb0..9c9c32788 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -709,9 +709,6 @@ File %1$s contained %2$s.\n\n Default Low Notification priority - Number of vibrations - Length of each vibration (milliseconds) - Pause between vibrations (milliseconds) Take a picture Pick from gallery Pick from storage diff --git a/app/src/main/res/xml/preferences_reminders.xml b/app/src/main/res/xml/preferences_reminders.xml index a8a2b90a5..f0ab6295c 100644 --- a/app/src/main/res/xml/preferences_reminders.xml +++ b/app/src/main/res/xml/preferences_reminders.xml @@ -20,6 +20,11 @@ android:showDefault="true" android:showSilent="true" android:title="@string/sound" /> + - - - - - - - - - -