From 3bd89978b074c495a6b4ce4a5270fdde8400414c Mon Sep 17 00:00:00 2001 From: Sam Bosley Date: Thu, 17 Jan 2013 16:10:56 -0800 Subject: [PATCH] Replace the task edit delete menu item with a button directly in the layout --- astrid/res/layout/task_edit_activity.xml | 7 +++++++ astrid/res/values/strings-core.xml | 2 +- .../todoroo/astrid/activity/TaskEditFragment.java | 14 +++++++------- 3 files changed, 15 insertions(+), 8 deletions(-) diff --git a/astrid/res/layout/task_edit_activity.xml b/astrid/res/layout/task_edit_activity.xml index 9f5c45826..6d075ad5e 100644 --- a/astrid/res/layout/task_edit_activity.xml +++ b/astrid/res/layout/task_edit_activity.xml @@ -87,6 +87,13 @@ android:text="@string/EPr_beastMode_shortcut" android:textColor="?attr/asTextColor"/> + + diff --git a/astrid/res/values/strings-core.xml b/astrid/res/values/strings-core.xml index e37a85092..d7eeb5282 100644 --- a/astrid/res/values/strings-core.xml +++ b/astrid/res/values/strings-core.xml @@ -238,7 +238,7 @@ Show deleted tasks - Drag & drop with subtasks + Manual order with subtasks Smart sort diff --git a/astrid/src/com/todoroo/astrid/activity/TaskEditFragment.java b/astrid/src/com/todoroo/astrid/activity/TaskEditFragment.java index 6cb17a01d..45205b0ae 100755 --- a/astrid/src/com/todoroo/astrid/activity/TaskEditFragment.java +++ b/astrid/src/com/todoroo/astrid/activity/TaskEditFragment.java @@ -178,7 +178,6 @@ ViewPager.OnPageChangeListener, EditNoteActivity.UpdatesChangedListener { private static final int MENU_SAVE_ID = R.string.TEA_menu_save; private static final int MENU_DISCARD_ID = R.string.TEA_menu_discard; - private static final int MENU_DELETE_ID = R.string.TEA_menu_delete; private static final int MENU_COMMENTS_REFRESH_ID = R.string.TEA_menu_refresh_comments; private static final int MENU_SHOW_COMMENTS_ID = R.string.TEA_menu_comments; private static final int MENU_ATTACH_ID = R.string.premium_attach_file; @@ -619,6 +618,13 @@ ViewPager.OnPageChangeListener, EditNoteActivity.UpdatesChangedListener { setupBeastModeButton(); + getView().findViewById(R.id.delete_task).setOnClickListener(new OnClickListener() { + @Override + public void onClick(View v) { + deleteButtonClick(); + } + }); + loadEditPageOrder(false); // Load task data in background @@ -1192,9 +1198,6 @@ ViewPager.OnPageChangeListener, EditNoteActivity.UpdatesChangedListener { case MENU_DISCARD_ID: discardButtonClick(); return true; - case MENU_DELETE_ID: - deleteButtonClick(); - return true; case MENU_ATTACH_ID: startAttachFile(); return true; @@ -1260,9 +1263,6 @@ ViewPager.OnPageChangeListener, EditNoteActivity.UpdatesChangedListener { item.setShowAsAction(MenuItem.SHOW_AS_ACTION_ALWAYS); } - item = menu.add(Menu.NONE, MENU_DELETE_ID, 0, R.string.TEA_menu_delete); - item.setIcon(android.R.drawable.ic_menu_delete); - } @Override