Fixed a bug that could cause task duplicates and web overwriting due dates when adding from widget

pull/14/head
Sam Bosley 13 years ago
parent 73f65385cb
commit 386c6fc723

@ -55,7 +55,6 @@ import com.todoroo.astrid.data.TagData;
import com.todoroo.astrid.data.Task;
import com.todoroo.astrid.data.Update;
import com.todoroo.astrid.service.MetadataService;
import com.todoroo.astrid.service.StartupService;
import com.todoroo.astrid.service.StatisticsConstants;
import com.todoroo.astrid.service.StatisticsService;
import com.todoroo.astrid.service.TagDataService;
@ -292,8 +291,13 @@ public final class ActFmSyncService {
if(newlyCreated) {
if(task.getValue(Task.TITLE).length() == 0)
return;
if(task.getId() <= StartupService.INTRO_TASK_SIZE)
return;
for(int taskTitle : new int[] { R.string.intro_task_1_summary,
R.string.intro_task_2_summary, R.string.intro_task_3_summary }) {
String title = ContextManager.getString(taskTitle);
if(task.getValue(Task.TITLE).equals(title))
return;
}
values = task.getMergedValues();
}
if(values.containsKey(Task.TITLE.name)) {

Before

Width:  |  Height:  |  Size: 6.7 KiB

After

Width:  |  Height:  |  Size: 6.7 KiB

@ -506,8 +506,10 @@ public final class TaskEditActivity extends TabActivity {
if(!onPause && peopleControlSet != null && !peopleControlSet.saveSharingSettings(processedToast))
return;
if (!onPause) // Saving during on pause could cause a double finish
if (!onPause) { // Saving during on pause could cause a double finish
shouldSaveState = false;
finish();
}
}
@Override

@ -6,6 +6,7 @@
package com.todoroo.astrid.dao;
import android.content.ContentValues;
import android.util.Log;
import com.timsu.astrid.R;
import com.todoroo.andlib.data.DatabaseDao;
@ -169,10 +170,12 @@ public class TaskDao extends DatabaseDao<Task> {
*/
public boolean save(Task task) {
boolean saveSuccessful;
Log.e("SAVING", "SAVING - " + task.getSetValues().toString(), new Throwable());
if (task.getId() == Task.NO_ID) {
System.err.println("Creating new");
saveSuccessful = createNew(task);
} else {
System.err.println("Saving existing");
saveSuccessful = saveExisting(task);
}

Loading…
Cancel
Save