From 2c60d25634d2e87d94cf5a0a84a3ddf8d0f53760 Mon Sep 17 00:00:00 2001 From: Alex Baker Date: Tue, 2 Jul 2019 15:54:45 -0500 Subject: [PATCH] Fix location chip and description RTL issue --- app/src/main/java/org/tasks/tasklist/ViewHolder.java | 5 ++--- app/src/main/res/layout/task_adapter_row_body.xml | 4 +++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/org/tasks/tasklist/ViewHolder.java b/app/src/main/java/org/tasks/tasklist/ViewHolder.java index 553552457..95bb22fe7 100644 --- a/app/src/main/java/org/tasks/tasklist/ViewHolder.java +++ b/app/src/main/java/org/tasks/tasklist/ViewHolder.java @@ -146,9 +146,8 @@ public class ViewHolder extends RecyclerView.ViewHolder { dueDate.setTextSize(fontSizeDetails); if (atLeastJellybeanMR1()) { - int direction = locale.isRtl() ? View.LAYOUT_DIRECTION_LTR : View.LAYOUT_DIRECTION_RTL; - chipGroup.setLayoutDirection(direction); - locationChip.setLayoutDirection(direction); + chipGroup.setLayoutDirection( + locale.isRtl() ? View.LAYOUT_DIRECTION_LTR : View.LAYOUT_DIRECTION_RTL); } else { MarginLayoutParams lp = (MarginLayoutParams) chipGroup.getLayoutParams(); lp.setMargins(lp.rightMargin, lp.topMargin, lp.leftMargin, lp.bottomMargin); diff --git a/app/src/main/res/layout/task_adapter_row_body.xml b/app/src/main/res/layout/task_adapter_row_body.xml index 50a578c24..8ff1da921 100644 --- a/app/src/main/res/layout/task_adapter_row_body.xml +++ b/app/src/main/res/layout/task_adapter_row_body.xml @@ -85,6 +85,8 @@ android:paddingEnd="@dimen/keyline_first" android:paddingLeft="@dimen/keyline_content_inset" android:paddingRight="@dimen/keyline_first" + android:gravity="start" + android:textAlignment="viewStart" android:ellipsize="end" android:maxLines="2" android:textColor="@color/text_secondary" @@ -99,7 +101,7 @@ android:layout_marginLeft="@dimen/keyline_content_inset" android:layout_marginRight="@dimen/keyline_first" android:layout_gravity="center_vertical|end" - android:textAlignment="center" + android:gravity="end" android:textColor="@color/text_secondary" android:visibility="gone" app:chipBackgroundColor="?attr/asContentBackground"