Fix for force close when you have an orphaned top-level child

13 years ago · 2b56bc11eb
parent 69d6bfb51a
commit 2b56bc11eb
1 changed files with 6 additions and 3 deletions
--- a/astrid/plugin-src/com/todoroo/astrid/subtasks/OrderedListUpdater.java
+++ b/astrid/plugin-src/com/todoroo/astrid/subtasks/OrderedListUpdater.java
@ -268,10 +268,13 @@ abstract public class OrderedListUpdater<LIST> {
                    parent.children.add(currentNode.get());
                } else { // in a different tree
                    Node node = currentNode.get().parent;
-                    for(int i = indent; i < previousIndentValue; i++)
+                    for(int i = indent; i < previousIndentValue; i++) {
                        node = node.parent;
-                    if(node == null)
-                        node = root;
+                        if(node == null) {
+                            node = root;
+                            break;
+                        }
+                    }
                    currentNode.set(new Node(taskId, node));
                    node.children.add(currentNode.get());
                }