diff --git a/app/src/main/java/com/todoroo/astrid/activity/TaskEditFragment.java b/app/src/main/java/com/todoroo/astrid/activity/TaskEditFragment.java index 66949c692..5c383fbf1 100755 --- a/app/src/main/java/com/todoroo/astrid/activity/TaskEditFragment.java +++ b/app/src/main/java/com/todoroo/astrid/activity/TaskEditFragment.java @@ -23,6 +23,7 @@ import android.os.Bundle; import android.text.format.DateUtils; import android.text.method.ScrollingMovementMethod; import android.view.LayoutInflater; +import android.view.Menu; import android.view.MenuItem; import android.view.View; import android.view.ViewGroup; @@ -135,24 +136,21 @@ public final class TaskEditFragment extends InjectingFragment themeColor = arguments.getParcelable(EXTRA_THEME); Toolbar toolbar = binding.toolbar; - final boolean backButtonSavesTask = preferences.backButtonSavesTask(); - toolbar.setNavigationIcon( - ContextCompat.getDrawable( - context, - backButtonSavesTask - ? R.drawable.ic_outline_clear_24px - : R.drawable.ic_outline_save_24px)); - toolbar.setNavigationOnClickListener( - v -> { - if (backButtonSavesTask) { - discardButtonClick(); - } else { - save(); - } - }); - if (!model.isNew()) { - toolbar.inflateMenu(R.menu.menu_task_edit_fragment); - } + toolbar.setNavigationIcon(ContextCompat.getDrawable(context, R.drawable.ic_outline_save_24px)); + toolbar.setNavigationOnClickListener(v -> save()); + + boolean backButtonSavesTask = preferences.backButtonSavesTask(); + toolbar.inflateMenu(R.menu.menu_task_edit_fragment); + Menu menu = toolbar.getMenu(); + MenuItem delete = menu.findItem(R.id.menu_delete); + delete.setVisible(!model.isNew()); + delete.setShowAsAction( + backButtonSavesTask ? MenuItem.SHOW_AS_ACTION_NEVER : MenuItem.SHOW_AS_ACTION_IF_ROOM); + MenuItem discard = menu.findItem(R.id.menu_discard); + discard.setVisible(backButtonSavesTask); + discard.setShowAsAction( + model.isNew() ? MenuItem.SHOW_AS_ACTION_IF_ROOM : MenuItem.SHOW_AS_ACTION_NEVER); + if (savedInstanceState == null) { showKeyboard = model.isNew() && Strings.isNullOrEmpty(model.getTitle()); completed = model.isCompleted(); diff --git a/app/src/main/java/org/tasks/locale/ui/activity/TaskerCreateTaskActivity.java b/app/src/main/java/org/tasks/locale/ui/activity/TaskerCreateTaskActivity.java index c1de10d3e..2ec25a36f 100755 --- a/app/src/main/java/org/tasks/locale/ui/activity/TaskerCreateTaskActivity.java +++ b/app/src/main/java/org/tasks/locale/ui/activity/TaskerCreateTaskActivity.java @@ -15,12 +15,10 @@ import org.tasks.billing.PurchaseActivity; import org.tasks.databinding.ActivityTaskerCreateBinding; import org.tasks.injection.ActivityComponent; import org.tasks.locale.bundle.TaskCreationBundle; -import org.tasks.preferences.Preferences; public final class TaskerCreateTaskActivity extends AbstractFragmentPluginAppCompatActivity implements Toolbar.OnMenuItemClickListener { - @Inject Preferences preferences; @Inject Inventory inventory; @Inject LocalBroadcastManager localBroadcastManager; @@ -37,21 +35,8 @@ public final class TaskerCreateTaskActivity extends AbstractFragmentPluginAppCom Toolbar toolbar = binding.toolbar.toolbar; toolbar.setTitle(R.string.tasker_create_task); - final boolean backButtonSavesTask = preferences.backButtonSavesTask(); - toolbar.setNavigationIcon( - ContextCompat.getDrawable( - this, - backButtonSavesTask - ? R.drawable.ic_outline_clear_24px - : R.drawable.ic_outline_save_24px)); - toolbar.setNavigationOnClickListener( - v -> { - if (backButtonSavesTask) { - discardButtonClick(); - } else { - save(); - } - }); + toolbar.setNavigationIcon(ContextCompat.getDrawable(this, R.drawable.ic_outline_save_24px)); + toolbar.setNavigationOnClickListener(v -> save()); toolbar.setOnMenuItemClickListener(this); toolbar.inflateMenu(R.menu.menu_tasker_create_task); themeColor.apply(toolbar); @@ -118,12 +103,7 @@ public final class TaskerCreateTaskActivity extends AbstractFragmentPluginAppCom @Override public void onBackPressed() { - final boolean backButtonSavesTask = preferences.backButtonSavesTask(); - if (backButtonSavesTask) { - save(); - } else { - discardButtonClick(); - } + discardButtonClick(); } private void save() { diff --git a/app/src/main/res/menu/menu_task_edit_fragment.xml b/app/src/main/res/menu/menu_task_edit_fragment.xml index 05f88eef4..ba2122791 100644 --- a/app/src/main/res/menu/menu_task_edit_fragment.xml +++ b/app/src/main/res/menu/menu_task_edit_fragment.xml @@ -1,10 +1,15 @@ + xmlns:app="http://schemas.android.com/apk/res-auto"> + + app:showAsAction="never"/> \ No newline at end of file diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 8caff509a..bd8101e1c 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -352,6 +352,7 @@ File %1$s contained %2$s.\n\n %1$s must come before %2$s %1$s must come after %2$s Discard changes? + Discard changes Discard Tag settings List settings